Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0035313Openbravo ERPA. Platformpublic2017-02-20 18:402017-03-15 20:19
malsasua 
caristu 
immediateminoralways
closedfixed 
5
 
3.0PR17Q2 
alostale
Core
Production - Confirmed Stable
2016-04-18
3.0PR16Q3
https://code.openbravo.com/erp/devel/pi/rev/82f27ac1b1497b3a82646b140ab1b6e048f2b766 [^]
No
0035313: invoice PDF is not attached from "email" button in sales invoice window
in sales invoice window, it is possible to send one email with the PDF invoice, clicking in "email" button (in toolbar).

From 16Q3, the email is sent, but the PDF is not attached
in "Client" window, "Email Configuration" tab, configure it
in Sales Invoice window, select one record, and click in "email" button. Click in option "Archive" (see attachment)
send email

the email is sent, but PDF is not attached to the email
No tags attached.
depends on backport 00353173.0PR16Q3.6 closed caristu invoice PDF is not attached from "email" button in sales invoice window 
depends on backport 00353183.0PR17Q1 closed caristu invoice PDF is not attached from "email" button in sales invoice window 
depends on backport 00353193.0PR16Q4.3 closed caristu invoice PDF is not attached from "email" button in sales invoice window 
caused by feature request 0029771 closed naiaramartinez different attachment method infrastructure 
has duplicate defect 0035332 closed platform Process send documents by email only send attachments if 'Archive' checkbox is not checked 
related to defect 0035356 closed caristu print & attach doc logs error using (old) commons jdbc pool 
png email.png (325,747) 2017-02-20 18:41
https://issues.openbravo.com/file_download.php?file_id=10468&type=bug
Issue History
2017-02-20 18:40malsasuaNew Issue
2017-02-20 18:40malsasuaAssigned To => platform
2017-02-20 18:40malsasuaModules => Core
2017-02-20 18:40malsasuaRegression level => Production - Confirmed Stable
2017-02-20 18:40malsasuaTriggers an Emergency Pack => No
2017-02-20 18:41malsasuaFile Added: email.png
2017-02-20 18:44malsasuaResolution time => 1487890800
2017-02-21 09:33caristuRegression date => 2016-04-18
2017-02-21 09:33caristuRegression introduced in release => 3.0PR16Q3
2017-02-21 09:33caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/82f27ac1b1497b3a82646b140ab1b6e048f2b766 [^]
2017-02-21 09:34caristuStatusnew => scheduled
2017-02-21 09:38caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14650#r14650
2017-02-21 09:38caristuRelationship addedcaused by 0029771
2017-02-21 13:39caristuAssigned Toplatform => caristu
2017-02-21 13:40hgbotCheckin
2017-02-21 13:40hgbotNote Added: 0094508
2017-02-21 13:40hgbotStatusscheduled => resolved
2017-02-21 13:40hgbotResolutionopen => fixed
2017-02-21 13:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/24eba52754e38628d78c943c3b8892acdb0c6462 [^]
2017-02-21 16:00caristuReview Assigned To => alostale
2017-02-21 19:32caristuRelationship addedhas duplicate 0035332
2017-02-24 09:56alostaleNote Added: 0094598
2017-02-24 09:56alostaleStatusresolved => closed
2017-02-24 09:56alostaleFixed in Version => 3.0PR17Q2
2017-02-24 10:11caristuNote Added: 0094603
2017-02-24 10:30alostaleRelationship addedrelated to 0035356
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095200

Notes
(0094508)
hgbot   
2017-02-21 13:40   
Repository: erp/devel/pi
Changeset: 24eba52754e38628d78c943c3b8892acdb0c6462
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Feb 21 13:39:12 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/24eba52754e38628d78c943c3b8892acdb0c6462 [^]

fixes issue 35313: documents were not being attached after send them by e-mail

The CoreAttachImplementation class is deleting the original report file after completing the upload process. When attaching a document using the e-mail pop-up this is done before attaching the document into the e-mail. This explains why the document was not being received on the e-mail.

To avoid this problem, now a copy of the original document is sent to the AttachImplementationManager, this way the original file will never be deleted by an upload process handler.

Together with this, now when attaching a document after printing (not by e-mail) we have to delete the original file because in other case it will be kept on disk.

---
M src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0094598)
alostale   
2017-02-24 09:56   
code reviewed + tested
(0094603)
caristu   
2017-02-24 10:11   
Added test case into TestLink: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10557 [^]
(0095200)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test