Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0035303 | Openbravo ERP | A. Platform | public | 2017-02-19 13:59 | 2017-04-04 16:59 |
|
| Reporter | shuehner | |
| Assigned To | shuehner | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0PR17Q2 | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0035303: Skip grid config related junit tests if any module shipping grid configuration is installed - part2 |
| Description | Same case as already reported and partially fixed in issue 34769.
The SortingFilteringGridConfiguration rely on the grid config setting being not modified for:
private static final String BUSINESS_PARTNER_TAB_ID = "220";
private static final String BUSINESS_PARTNER_CATEGORY_FIELD_ID = "3955";
If any grid config module is installed which modify those the tests can no longer work.
Same fix as 34769 the tests should check this and skip itself.
Attached patch copies the fix from 34769 to this 2nd junit class.
1 change: it uses @BeforeClass instead of @Before to do the check once for the whole test class and not chekc for all 1820 parametrized combination over and over again.
Note: Maybe that same change could improve the auto-skip in the 34769.
|
| Steps To Reproduce | Run this SortingFilteringGridConfiguration junit test with an grid-config module instaleld i.e. the org.openbravo.retail.highvolumesconfig module.
|
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0034769 | | closed | alostale | Skip grid config related junit tests if any module shipping grid configuration is installed. | | related to | defect | 0038319 | | closed | shuehner | Skip grid config related junit tests if any module shipping grid configuration is installed - part3 |
|
| Attached Files |  35303.diff (2,423) 2017-02-19 14:00
https://issues.openbravo.com/file_download.php?file_id=10463&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-02-19 13:59 | shuehner | New Issue | |
| 2017-02-19 13:59 | shuehner | Assigned To | => platform |
| 2017-02-19 13:59 | shuehner | Modules | => Core |
| 2017-02-19 13:59 | shuehner | Triggers an Emergency Pack | => No |
| 2017-02-19 13:59 | shuehner | Relationship added | related to 0034769 |
| 2017-02-19 14:00 | shuehner | File Added: 35303.diff | |
| 2017-02-19 14:00 | shuehner | Note Added: 0094447 | |
| 2017-02-20 09:14 | hgbot | Checkin | |
| 2017-02-20 09:14 | hgbot | Note Added: 0094453 | |
| 2017-02-20 09:14 | hgbot | Status | new => resolved |
| 2017-02-20 09:14 | hgbot | Resolution | open => fixed |
| 2017-02-20 09:14 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/678eb7a367b73a2a8d4d894e18199fa72747edc5 [^] |
| 2017-02-20 09:15 | alostale | Review Assigned To | => alostale |
| 2017-02-20 09:15 | alostale | Note Added: 0094454 | |
| 2017-02-20 09:15 | alostale | Status | resolved => closed |
| 2017-02-20 09:15 | alostale | Fixed in Version | => 3.0PR17Q2 |
| 2017-03-15 20:19 | hudsonbot | Checkin | |
| 2017-03-15 20:19 | hudsonbot | Note Added: 0095194 | |
| 2017-04-04 16:59 | alostale | Assigned To | platform => shuehner |
| 2018-04-10 19:45 | shuehner | Relationship added | related to 0038319 |