0035268: Request timeout message is not handled properly in the UI

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0035268

Openbravo ERP

A. Platform

public

2017-02-14 19:34

2018-02-22 18:18

Reporter

caristu

Assigned To

jarmendariz

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0PR18Q2

Merge Request Status

Review Assigned To

caristu

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0035268: Request timeout message is not handled properly in the UI

Description

The request timeout message is not being handled properly. If a request is not completed because the client timeout expires, then no message is displayed in the User Interface.

Note that the only case where the message is displayed is when the timeout is expired when saving/updating a record in form view. This is because the ob-view detects that the response of the request is not successful.

Steps To Reproduce

Artificial Test, using Eclipse:

1) Open any window, for example [Sales Order]
2) Put a breakpoint in the DefaultJsonDataService class, at the beginning of the fetch method.
3) Click on refresh button, wait 4 minutes without moving from the breakpoint. Once that time has passed, you will see in the UI that the "Loading data..." message in the header is gone but it does not appear any message informing about the timeout expiration.

The same behavior happens when firing a call with OB.RemoteCallManager, but also in this case a js error is fired in the evalResult function because the timeout expiration result is not being handled properly:

Uncaught TypeError: results.match is not a function
    at cons.evalResult (RPCManager.js:4291)
    at cons.fireReplyCallbacks (RPCManager.js:4308)
    at cons.performOperationReply (RPCManager.js:4265)
    at cons._performTransactionReply (RPCManager.js:4178)
    at cons.performTransactionReply (RPCManager.js:3595)
    at eval (eval at isc__makeFunction (Object.js:129), <anonymous>:3:16)
    at cons.fireCallback (Class.js:1789)
    at cons.performXmlTransactionReply (Comm.js:383)
    at eval (eval at isc__makeFunction (Object.js:129), <anonymous>:3:10)
    at Object.fireCallback (Class.js:1792)

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0027621	closed	AugustoMauch	If you get a network interruption when clicking on the edit item button , then the button does not work anymore
related to	defect	0035357	closed	caristu	The timeout error message displayed in the UI is not user readable
related to	design defect	0040099	new	Triage Platform Base	Could be fine to configure the defaultTimeout
related to	feature request	0040342	acknowledged	Triage Platform Base	Define a default query timeout profile for the standard grids
related to	defect	0042153	closed	alostale	Grid timeout returns unclear message in the backoffice
causes	defect	0040253	closed	jarmendariz	Responses from OB.RemoteCallManager calls are not handled if the Smartclient timeout is fired

Attached Files

bug-35268.patch (2,223) 2018-01-05 14:53
https://issues.openbravo.com/file_download.php?file_id=11429&type=bug
patch

bug-35268-1.patch (1,569) 2018-01-08 12:58
https://issues.openbravo.com/file_download.php?file_id=11434&type=bug

Issue History

Date Modified

Username

Field

Change

2017-02-14 19:34