Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0035268Openbravo ERPA. Platformpublic2017-02-14 19:342018-02-22 18:18
caristu 
jarmendariz 
normalminoralways
closedfixed 
5
 
3.0PR18Q2 
caristu
Core
No
0035268: Request timeout message is not handled properly in the UI
The request timeout message is not being handled properly. If a request is not completed because the client timeout expires, then no message is displayed in the User Interface.

Note that the only case where the message is displayed is when the timeout is expired when saving/updating a record in form view. This is because the ob-view detects that the response of the request is not successful.
Artificial Test, using Eclipse:

1) Open any window, for example [Sales Order]
2) Put a breakpoint in the DefaultJsonDataService class, at the beginning of the fetch method.
3) Click on refresh button, wait 4 minutes without moving from the breakpoint. Once that time has passed, you will see in the UI that the "Loading data..." message in the header is gone but it does not appear any message informing about the timeout expiration.

The same behavior happens when firing a call with OB.RemoteCallManager, but also in this case a js error is fired in the evalResult function because the timeout expiration result is not being handled properly:

Uncaught TypeError: results.match is not a function
    at cons.evalResult (RPCManager.js:4291)
    at cons.fireReplyCallbacks (RPCManager.js:4308)
    at cons.performOperationReply (RPCManager.js:4265)
    at cons._performTransactionReply (RPCManager.js:4178)
    at cons.performTransactionReply (RPCManager.js:3595)
    at eval (eval at isc__makeFunction (Object.js:129), <anonymous>:3:16)
    at cons.fireCallback (Class.js:1789)
    at cons.performXmlTransactionReply (Comm.js:383)
    at eval (eval at isc__makeFunction (Object.js:129), <anonymous>:3:10)
    at Object.fireCallback (Class.js:1792)
No tags attached.
related to defect 0027621 closed AugustoMauch If you get a network interruption when clicking on the edit item button , then the button does not work anymore 
related to defect 0035357 closed caristu The timeout error message displayed in the UI is not user readable 
related to design defect 0040099 new platform Could be fine to configure the defaultTimeout 
related to feature request 0040342 acknowledged platform Define a default query timeout profile for the standard grids 
related to defect 0042153 closed alostale Grid timeout returns unclear message in the backoffice 
causes defect 0040253 closed jarmendariz Responses from OB.RemoteCallManager calls are not handled if the Smartclient timeout is fired 
patch bug-35268.patch (2,223) 2018-01-05 14:53
https://issues.openbravo.com/file_download.php?file_id=11429&type=bug
patch bug-35268-1.patch (1,569) 2018-01-08 12:58
https://issues.openbravo.com/file_download.php?file_id=11434&type=bug
Issue History
2017-02-14 19:34caristuNew Issue
2017-02-14 19:34caristuAssigned To => platform
2017-02-14 19:34caristuModules => Core
2017-02-14 19:34caristuTriggers an Emergency Pack => No
2017-02-15 08:37caristuSummaryRequest timeout message are not handled properly in the UI => Request timeout message is not handled properly in the UI
2017-02-15 08:37caristuDescription Updatedbug_revision_view_page.php?rev_id=14589#r14589
2017-02-15 08:37caristuDescription Updatedbug_revision_view_page.php?rev_id=14590#r14590
2017-02-15 08:41caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14592#r14592
2017-02-15 08:51caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14593#r14593
2017-02-15 08:51caristuRelationship addedrelated to 0027621
2017-02-24 10:30caristuDescription Updatedbug_revision_view_page.php?rev_id=14667#r14667
2017-02-24 10:43caristuRelationship addedrelated to 0035357
2017-02-24 10:48alostaleStatusnew => acknowledged
2017-12-13 19:27caristuAssigned Toplatform => jarmendariz
2018-01-04 16:15jarmendarizStatusacknowledged => scheduled
2018-01-05 14:53jarmendarizFile Added: bug-35268.patch
2018-01-08 12:58jarmendarizFile Added: bug-35268-1.patch
2018-01-08 12:59jarmendarizReview Assigned To => caristu
2018-02-02 15:06hgbotCheckin
2018-02-02 15:06hgbotNote Added: 0102155
2018-02-02 15:06hgbotStatusscheduled => resolved
2018-02-02 15:06hgbotResolutionopen => fixed
2018-02-02 15:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0b908a2c7f992827a230b06193ad7f8f9bd2ce9b [^]
2018-02-09 08:19caristuNote Added: 0102281
2018-02-09 08:19caristuStatusresolved => closed
2018-02-09 08:19caristuFixed in Version => 3.0PR18Q2
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102713
2019-02-01 11:00JONHMRelationship addedrelated to 0040099
2019-02-21 13:30caristuRelationship addedcauses 0040253
2019-03-08 11:07caristuRelationship addedrelated to 0040342
2019-10-31 08:00alostaleRelationship addedrelated to 0042153

Notes
(0102155)
hgbot   
2018-02-02 15:06   
Repository: erp/devel/pi
Changeset: 0b908a2c7f992827a230b06193ad7f8f9bd2ce9b
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Feb 02 15:00:04 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0b908a2c7f992827a230b06193ad7f8f9bd2ce9b [^]

Fixed bug 35268: No message displayed on request timeout responses.

The RPC response handler does not show any message when the request fails. Now it shows an error in the messageBar if its a server timeout.

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0102281)
caristu   
2018-02-09 08:19   
Code reviewed + tested OK.
(0102713)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test