Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035234Retail ModulesWeb POSpublic2017-02-13 10:432017-03-06 12:41
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035234: HandlePayments method in OrderLoader has been changed, and the API has been broken
DescriptionA new parameter has been added in handlePayments method in the OrderLoader class. The method is public, so this is not a valid change unless the previous method is also preserved.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0035235RR17Q1 closed marvintm HandlePayments method in OrderLoader has been changed, and the API has been broken 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-13 10:43marvintmNew Issue
2017-02-13 10:43marvintmAssigned To => marvintm
2017-02-13 10:43marvintmOBNetwork customer => No
2017-02-13 10:43marvintmTriggers an Emergency Pack => No
2017-02-13 10:44marvintmStatusnew => scheduled
2017-02-13 10:45hgbotCheckin
2017-02-13 10:45hgbotNote Added: 0094254
2017-02-13 10:45hgbotStatusscheduled => resolved
2017-02-13 10:45hgbotResolutionopen => fixed
2017-02-13 10:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2f3090b02d31fbc790db4c82f89b1ff14542ceaa [^]
2017-02-17 08:56hgbotCheckin
2017-02-17 08:56hgbotNote Added: 0094443
2017-03-06 12:41guilleaerReview Assigned To => guilleaer
2017-03-06 12:41guilleaerStatusresolved => closed
2017-03-06 12:41guilleaerFixed in Version => RR17Q2

Notes
(0094254)
hgbot   
2017-02-13 10:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2f3090b02d31fbc790db4c82f89b1ff14542ceaa
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Feb 13 10:44:30 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2f3090b02d31fbc790db4c82f89b1ff14542ceaa [^]

Fixed issue 35234. Preserve previous version of the handlePayments method for API compatibility purposes.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0094443)
hgbot   
2017-02-17 08:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b1993add07d7060a6bef372f7a1e5c0cf38d678c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Feb 17 08:55:38 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b1993add07d7060a6bef372f7a1e5c0cf38d678c [^]

Related to issue 35234. Changed type of parameter

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---