Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035216Retail ModulesCash uppublic2017-02-09 18:352017-06-19 12:45
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket43392
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035216: during cashup, it is possible duplicate invoice lines when one orderline generates two or more invoice lines
Descriptionwhen one orderline is related with two or more goods shipment lines, tow invoice lines are generated, and in some cases, one extra line is generated and the sum of qty invoiced is higher than qty ordered
Steps To Reproducestock prod1:
  locator 1 - prod1 (with lot1) - qty 1.25
  locator 1 - prod1 (with lot2) - qty 0.72
in POS:
. create one receipt with the check "invoice this receipt"
. add one line:prod1
 qty 2
. complete the receipt

create new receipt without check "invoice this receipt":
 . prod2 (it is not important)
  qty 1
. complete the receipt

in backoffice:
 invoice1 has been created:
   line1 prod1: qty 1.25
   line2 prod1: qty 0.75

in POS:
 do cashup

in backoffice:
 invoice1 has been updated:
   line1 prod1: qty 1.25
   line2 prod1: qty 0.75
   line3 prod1: qty 0.75

It is reproducible randomly
Proposed Solutionattached a patch with a possible solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0036273RR17Q1.3 closed ranjith_qualiantech_com during cashup, it is possible duplicate invoice lines when one orderline generates two or more invoice lines 
causes defect 0035680 closed jorge-garcia Error in OrderGroupingProcessor in Oracle 11 
Attached Filesdiff issueSplitLines.diff (644) 2017-02-09 19:12
https://issues.openbravo.com/file_download.php?file_id=10432&type=bug
patch issue 35216 source posterminal.patch (2,719) 2017-02-28 06:44
https://issues.openbravo.com/file_download.php?file_id=10507&type=bug
patch issue 35216 test.patch (10,265) 2017-02-28 06:44
https://issues.openbravo.com/file_download.php?file_id=10508&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-02-09 18:35malsasuaNew Issue
2017-02-09 18:35malsasuaAssigned To => Retail
2017-02-09 18:35malsasuaOBNetwork customer => Yes
2017-02-09 18:35malsasuaSupport ticket => 43392
2017-02-09 18:35malsasuaResolution time => 1488236400
2017-02-09 18:35malsasuaTriggers an Emergency Pack => No
2017-02-09 19:12malsasuaFile Added: issueSplitLines.diff
2017-02-09 19:13malsasuaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14543#r14543
2017-02-13 07:43ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-02-13 07:43ranjith_qualiantech_comStatusnew => scheduled
2017-02-28 06:44ranjith_qualiantech_comFile Added: issue 35216 source posterminal.patch
2017-02-28 06:44ranjith_qualiantech_comFile Added: issue 35216 test.patch
2017-03-07 08:56hgbotCheckin
2017-03-07 08:56hgbotNote Added: 0094783
2017-03-07 08:56hgbotStatusscheduled => resolved
2017-03-07 08:56hgbotResolutionopen => fixed
2017-03-07 08:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8467cfbe97a880b1946632bac69c9d2453a4961d [^]
2017-03-07 08:57hgbotCheckin
2017-03-07 08:57hgbotNote Added: 0094784
2017-03-09 12:31marvintmReview Assigned To => marvintm
2017-03-09 12:31marvintmStatusresolved => closed
2017-03-09 12:31marvintmFixed in Version => RR17Q2
2017-04-04 10:33ranjith_qualiantech_comRelationship addedcauses 0035680
2017-06-19 12:45marvintmStatusclosed => new
2017-06-19 12:45marvintmResolutionfixed => open
2017-06-19 12:45marvintmFixed in VersionRR17Q2 =>
2017-06-19 12:45marvintmStatusnew => scheduled
2017-06-19 12:45marvintmStatusscheduled => resolved
2017-06-19 12:45marvintmFixed in Version => RR17Q2
2017-06-19 12:45marvintmResolutionopen => fixed
2017-06-19 12:45marvintmStatusresolved => closed

Notes
(0094783)
hgbot   
2017-03-07 08:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8467cfbe97a880b1946632bac69c9d2453a4961d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Mar 07 13:25:16 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8467cfbe97a880b1946632bac69c9d2453a4961d [^]

Fixes issue 35216 : Invoice Line should not be created again, if it is already created in OrderLoader

* If Invoice Line are already created in OrderLoader, then while doing cashup, Invoice line should not be created/splited again
* Invoice are filterted by CashUp identifier

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql
---
(0094784)
hgbot   
2017-03-07 08:57   
Repository: tools/automation/pi-mobile
Changeset: a5ce5032be44b6a5e128f23f6692fca8a32fba35
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Mar 07 13:23:41 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a5ce5032be44b6a5e128f23f6692fca8a32fba35 [^]

Verifies issue 35216 : Added automated test 'I35216_VerifyCashUpSplitLines'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I35216_VerifyCashUpSplitLines.java
---