Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035202Retail ModulesWeb POSpublic2017-02-07 17:582017-03-06 10:37
Reporterguillermogil 
Assigned Tomarvintm 
PriorityhighSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q4.2Fixed in VersionRR16Q4.2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035202: It is possible to have duplicated primary keys on WebSQL
DescriptionIt is possible to have duplicated primary keys on WebSQL if you have a lot of products with duplicated names and an small pagination.
When the query is done it orders by name and since there are a lot that have the same value it can rely on errors in WebPOS console and losses of some record.

It will be needed to review each masterdata to ensure the proper behavior of them.
Steps To ReproduceN/A
Proposed SolutionSee diff attached for product query and apply it on the other queries.
It is needed to order by a unique constraint.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0035191 closed marvintm It is possible to have duplicated primary keys on WebSQL 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-08 15:34marvintmTypedefect => backport
2017-02-08 15:34marvintmTarget Version => RR16Q4.2
2017-02-08 19:10hgbotCheckin
2017-02-08 19:10hgbotNote Added: 0094160
2017-02-08 19:10hgbotStatusscheduled => resolved
2017-02-08 19:10hgbotResolutionopen => fixed
2017-02-08 19:10hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR16Q4.2/org.openbravo.retail.posterminal/rev/a778e59fed09501e5f3fc690121161235b6775e0 [^]
2017-03-01 15:19marvintmAssigned ToRetail => marvintm
2017-03-06 10:37guilleaerReview Assigned To => guilleaer
2017-03-06 10:37guilleaerStatusresolved => closed
2017-03-06 10:37guilleaerFixed in Version => RR16Q4.2

Notes
(0094160)
hgbot   
2017-02-08 19:10   
Repository: retail/backports/3.0RR16Q4.2/org.openbravo.retail.posterminal
Changeset: a778e59fed09501e5f3fc690121161235b6775e0
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Feb 08 19:00:21 2017 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4.2/org.openbravo.retail.posterminal/rev/a778e59fed09501e5f3fc690121161235b6775e0 [^]

Fixed issue 35202. Added id in the order by of masterdata queries to ensure that pagination works even if several records have the same name

---
M src/org/openbravo/retail/posterminal/master/BPCategory.java
M src/org/openbravo/retail/posterminal/master/BPLocation.java
M src/org/openbravo/retail/posterminal/master/Brand.java
M src/org/openbravo/retail/posterminal/master/BusinessPartner.java
M src/org/openbravo/retail/posterminal/master/Category.java
M src/org/openbravo/retail/posterminal/master/CategoryTree.java
M src/org/openbravo/retail/posterminal/master/Characteristic.java
M src/org/openbravo/retail/posterminal/master/CharacteristicValue.java
M src/org/openbravo/retail/posterminal/master/Product.java
M src/org/openbravo/retail/posterminal/master/ReturnReason.java
M src/org/openbravo/retail/posterminal/master/SalesRepresentative.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRuleRange.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRuleVersion.java
M src/org/openbravo/retail/posterminal/master/ServiceProduct.java
M src/org/openbravo/retail/posterminal/master/ServiceProductCategory.java
M src/org/openbravo/retail/posterminal/master/TaxRate.java
---