Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035201Retail ModulesWeb POSpublic2017-02-07 17:582017-03-06 10:34
Reporterguillermogil 
Assigned Tomarvintm 
PriorityhighSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q1Fixed in VersionRR17Q1 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035201: It is possible to have duplicated primary keys on WebSQL
DescriptionIt is possible to have duplicated primary keys on WebSQL if you have a lot of products with duplicated names and an small pagination.
When the query is done it orders by name and since there are a lot that have the same value it can rely on errors in WebPOS console and losses of some record.

It will be needed to review each masterdata to ensure the proper behavior of them.
Steps To ReproduceN/A
Proposed SolutionSee diff attached for product query and apply it on the other queries.
It is needed to order by a unique constraint.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0035191 closed marvintm It is possible to have duplicated primary keys on WebSQL 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-08 15:34marvintmTypedefect => backport
2017-02-08 15:34marvintmTarget Version => RR17Q1
2017-02-08 18:52hgbotCheckin
2017-02-08 18:52hgbotNote Added: 0094159
2017-02-08 18:52hgbotStatusscheduled => resolved
2017-02-08 18:52hgbotResolutionopen => fixed
2017-02-08 18:52hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR17Q1/org.openbravo.retail.posterminal/rev/5443763fb43cb7fe96ecd4b467e6d01967624cf2 [^]
2017-03-01 15:19marvintmAssigned ToRetail => marvintm
2017-03-06 10:34guilleaerReview Assigned To => guilleaer
2017-03-06 10:34guilleaerStatusresolved => closed
2017-03-06 10:34guilleaerFixed in Version => RR17Q1

Notes
(0094159)
hgbot   
2017-02-08 18:52   
Repository: retail/backports/3.0RR17Q1/org.openbravo.retail.posterminal
Changeset: 5443763fb43cb7fe96ecd4b467e6d01967624cf2
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Feb 08 18:52:14 2017 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR17Q1/org.openbravo.retail.posterminal/rev/5443763fb43cb7fe96ecd4b467e6d01967624cf2 [^]

Fixed issue 35201. Added id in the order by of masterdata queries to ensure that pagination works even if several records have the same name

---
M src/org/openbravo/retail/posterminal/master/BPCategory.java
M src/org/openbravo/retail/posterminal/master/BPLocation.java
M src/org/openbravo/retail/posterminal/master/Brand.java
M src/org/openbravo/retail/posterminal/master/BusinessPartner.java
M src/org/openbravo/retail/posterminal/master/Category.java
M src/org/openbravo/retail/posterminal/master/CategoryTree.java
M src/org/openbravo/retail/posterminal/master/Characteristic.java
M src/org/openbravo/retail/posterminal/master/CharacteristicValue.java
M src/org/openbravo/retail/posterminal/master/Product.java
M src/org/openbravo/retail/posterminal/master/ReturnReason.java
M src/org/openbravo/retail/posterminal/master/SalesRepresentative.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRuleRange.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRuleVersion.java
M src/org/openbravo/retail/posterminal/master/ServiceProduct.java
M src/org/openbravo/retail/posterminal/master/ServiceProductCategory.java
M src/org/openbravo/retail/posterminal/master/TaxRate.java
---