Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035181Openbravo ERP09. Financial managementpublic2017-02-07 11:112017-09-21 16:50
Reporterngarcia 
Assigned ToCSousa 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket45358
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035181: createAccDefRevenueFact function should be public in DocInvoice class
DescriptioncreateAccDefRevenueFact function should be public in DocInvoice class
Steps To ReproduceCreate a DocInvoiceTemplate class and check you cannot access the function:

docInvoice.createAccDefRevenueFact
Proposed SolutionSet the method as public
Additional Information
TagsNo tags attached.
Relationships
related to design defect 00248003.0PR14Q2 closed dmiguelez createAccDefExpenseFact and computeTaxUndeductableLine methods of DocInvoice class must be public 
related to design defect 0032342 new Triage Omni OMS Accounting Templates: some data from DocInvoice_data.xsql is not accessible from the DocInvoice object 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-07 11:11ngarciaNew Issue
2017-02-07 11:11ngarciaAssigned To => Triage Finance
2017-02-07 11:11ngarciaOBNetwork customer => Yes
2017-02-07 11:11ngarciaModules => Core
2017-02-07 11:11ngarciaSupport ticket => 45358
2017-02-07 11:11ngarciaTriggers an Emergency Pack => No
2017-02-07 11:11ngarciaRelationship addedrelated to 0024800
2017-02-07 11:11ngarciaRelationship addedrelated to 0032342
2017-02-07 11:12ngarciaIssue Monitored: networkb
2017-04-20 08:58CSousaNote Added: 0096082
2017-05-08 13:30CSousaStatusnew => scheduled
2017-05-08 13:30CSousaAssigned ToTriage Finance => CSousa
2017-09-18 14:30hgbotCheckin
2017-09-18 14:30hgbotNote Added: 0099115
2017-09-18 14:30hgbotStatusscheduled => resolved
2017-09-18 14:30hgbotResolutionopen => fixed
2017-09-18 14:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fc659d8303635171d724ff74681e6303e1e9cfb4 [^]
2017-09-18 14:31aferrazReview Assigned To => aferraz
2017-09-18 14:31aferrazNote Added: 0099116
2017-09-18 14:31aferrazStatusresolved => closed
2017-09-18 14:31aferrazFixed in Version => 3.0PR17Q4
2017-09-21 16:50hudsonbotCheckin
2017-09-21 16:50hudsonbotNote Added: 0099409

Notes
(0096082)
CSousa   
2017-04-20 08:58   
Create a DocInvoiceTemplate class and check you can access the function:

docInvoice.createAccDefRevenueFact
(0099115)
hgbot   
2017-09-18 14:30   
Repository: erp/devel/pi
Changeset: fc659d8303635171d724ff74681e6303e1e9cfb4
Author: Carlos Sousa <carlos.sousa <at> openbravo.com>
Date: Thu Apr 20 08:56:30 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fc659d8303635171d724ff74681e6303e1e9cfb4 [^]

Fixes issue 35181: createAccDefRevenueFact function
should be public in DocInvoice class.

createAccDefRevenueFact function set as public

---
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
---
(0099116)
aferraz   
2017-09-18 14:31   
Code review + Testing OK
(0099409)
hudsonbot   
2017-09-21 16:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test