Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035171Openbravo ERPA. Platformpublic2017-02-06 17:242017-03-15 20:19
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q2Fixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035171: Support basic authentication in the default authentication manager
DescriptionThe OB authentication manager supports basic authentication in case of webservice calls [1]. For other authentication we support login/password in the request parameters [2] but we don't support basic authentication.

[1]
https://code.openbravo.com/erp/devel/pi/file/01c864252395/src/org/openbravo/authentication/AuthenticationManager.java#l479 [^]

[2]
https://code.openbravo.com/erp/devel/pi/file/01c864252395/src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java#l87 [^]
Steps To ReproduceDo a retail webservice request using basic authentication.
Proposed SolutionSupport basic authentication in the DefaultAuthenticationManager [1]

[1]
https://code.openbravo.com/erp/devel/pi/file/01c864252395/src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java#l87 [^]
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0035140 closed mtaal Retail Modules [Store Server 2401]Basic Authentication not working with External Order Loader 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-06 17:24mtaalNew Issue
2017-02-06 17:24mtaalAssigned To => mtaal
2017-02-06 17:24mtaalModules => Core
2017-02-06 17:24mtaalTriggers an Emergency Pack => No
2017-02-06 17:25mtaalRelationship addedblocks 0035140
2017-02-08 09:38hgbotCheckin
2017-02-08 09:38hgbotNote Added: 0094140
2017-02-08 09:39mtaalReview Assigned To => alostale
2017-02-08 09:42hgbotCheckin
2017-02-08 09:42hgbotNote Added: 0094141
2017-02-08 09:42hgbotStatusnew => resolved
2017-02-08 09:42hgbotResolutionopen => fixed
2017-02-08 09:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/200a7c792da248caf9ae395d117904c3e5f1fb83 [^]
2017-02-08 09:43mtaalRelationship replacedhas duplicate 0035140
2017-02-10 08:51alostaleNote Added: 0094207
2017-02-10 08:51alostaleStatusresolved => closed
2017-02-10 08:51alostaleFixed in Version => 3.0PR17Q2
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095168

Notes
(0094140)
hgbot   
2017-02-08 09:38   
Repository: tools/automation/pi-mobile
Changeset: c55fdc10cb2447a5d75887ba82739f7be9ceb27a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Feb 08 09:38:12 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/c55fdc10cb2447a5d75887ba82739f7be9ceb27a [^]

Related to issue 35172 and issue 35171: added testcases for stateless/basic authentication
Use new class TestExternalOrderLoader to validate on the server that requests are indeed
stateless.
Explicitly add basic authentication headers

---
M src-test/org/openbravo/test/mobile/retail/extmodules/unittest/suites/StatelessTestSuite.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/webservice/WebServicesHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/BaseRetailOrderLoaderTest.java
A src-test/org/openbravo/test/mobile/retail/extmodules/unittest/tests/statelesswebservice/StatelessRetailOrderLoaderTest.java
A src-test/org/openbravo/test/mobile/retail/extmodules/unittest/tests/statelesswebservice/message-order-minimal-1.json
A src-test/org/openbravo/test/mobile/retail/extmodules/unittest/tests/statelesswebservice/message-order-multiline-1.json
---
(0094141)
hgbot   
2017-02-08 09:42   
Repository: erp/devel/pi
Changeset: 200a7c792da248caf9ae395d117904c3e5f1fb83
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Feb 08 09:40:46 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/200a7c792da248caf9ae395d117904c3e5f1fb83 [^]

Fixes issue 35171: Support basic authentication in the default authentication manager
Add basic authentication support to DefaultAuthenticationManager

---
M src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
---
(0094207)
alostale   
2017-02-10 08:51   
code reviewed + tested
(0095168)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test