Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035170Retail ModulesWeb POSpublic2017-02-06 17:232017-05-25 11:49
Reporterguillermogil 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035170: If you have a popup opened and you raise a showLoading the popup is behind and clickable
DescriptionIf you have a popup opened and you raise a showLoading the popup is behind and clickable.
This behavior in creating confusion and can rely on wrong data
Steps To Reproduce- Login on WebPOS
- Open developers tools
- Put the following code:
  OB.MobileApp.view.waterfall('onShowPopup', {
    popup: 'receiptPropertiesDialog'
  });

- Put the following code:
  OB.UTIL.showLoading(true);

You will notice that the popup is still in there
Proposed SolutionHide the popup too or put it behind the showLoading scrim
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036081 closed guillermogil If you raise a showLoading and then raises a popup it is shown and becomes clickable 
causes defect 0035305 closed ranjith_qualiantech_com Verified returns popup stops working after it is used for the first time 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-06 17:23guillermogilNew Issue
2017-02-06 17:23guillermogilAssigned To => Retail
2017-02-06 17:23guillermogilResolution time => 1488150000
2017-02-06 17:23guillermogilTriggers an Emergency Pack => No
2017-02-07 11:39jorge-garciaStatusnew => scheduled
2017-02-07 11:39jorge-garciaAssigned ToRetail => jorge-garcia
2017-02-16 16:38hgbotCheckin
2017-02-16 16:38hgbotNote Added: 0094395
2017-02-16 16:39hgbotCheckin
2017-02-16 16:39hgbotNote Added: 0094396
2017-02-16 16:39hgbotStatusscheduled => resolved
2017-02-16 16:39hgbotResolutionopen => fixed
2017-02-16 16:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/616a50b2eb90eb78b46670f10be6c0e22fb8ee05 [^]
2017-02-20 12:24marvintmReview Assigned To => marvintm
2017-02-20 12:24marvintmStatusresolved => closed
2017-02-20 12:24marvintmFixed in Version => RR17Q2
2017-02-20 12:57ranjith_qualiantech_comRelationship addedcauses 0035305
2017-05-24 10:40guillermogilRelationship addedrelated to 0036081
2017-05-25 11:49hgbotCheckin
2017-05-25 11:49hgbotNote Added: 0096789

Notes
(0094395)
hgbot   
2017-02-16 16:38   
Repository: tools/automation/pi-mobile
Changeset: d46b2b7301bfeb20f9391e5793bfdae72701043a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Feb 15 12:42:13 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d46b2b7301bfeb20f9391e5793bfdae72701043a [^]

Verifies issue 35170: If you have a popup opened and you raise a showLoading
the popup is behind and clickable

Added test I35170_HideOpenedPopupOnShowLoading.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35170_HideOpenedPopupOnShowLoading.java
---
(0094396)
hgbot   
2017-02-16 16:39   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 616a50b2eb90eb78b46670f10be6c0e22fb8ee05
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Feb 15 12:26:57 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/616a50b2eb90eb78b46670f10be6c0e22fb8ee05 [^]

Fixed issue 35170: If you have a popup opened and you raise a showLoading
the popup is behind and clickable

The opened popup is hidden when the loading bar is raised and is shown
again wen the loading screen is canceled.

---
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0096789)
hgbot   
2017-05-25 11:49   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 234a37ef5a652d8e5128407a76b02e6ddeda0f4d
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Thu May 25 11:49:15 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/234a37ef5a652d8e5128407a76b02e6ddeda0f4d [^]

Fixed issue 36081: raising a showLoading and then a popup

This was an unhandled case from issue 35170.
Now if showLoading is showing we set the display of the opened popup to none.
Once showLoading popup gets hidden it will automatically remove the display:none

---
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---