Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035138Retail ModulesWeb POSpublic2017-02-02 13:342017-02-07 18:00
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q2Fixed in VersionRR17Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelQA functional test
Regression date2016-11-01
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/19f3df300f234399cf2a42837690936fc8eb8542 [^]
Triggers an Emergency PackNo
Summary0035138: Taxes at header level are not computed correctly when using price including taxes, and taxes are defined at line level
DescriptionThere is a problem when calculating taxes when using price including taxes, if taxes are defined at line level. In this case, the tax information is not shown in the Web POS screen, and finally the tax information at header level is not properly saved in the backend.
Steps To Reproduce- Configure the usual taxes in the Web POS to be calculated at line level.
- Create a ticket with this configuration in the Web POS. Notice that taxes are not shown in the screen, and they are also not saved in the backend.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034360 closed marvintm Retail Modules Web POS is not calculating taxes at header level correctly if there are cascade taxes, with price including taxes 
depends on backport 0035139RR17Q1 closed marvintm Retail Modules Taxes at header level are not computed correctly when using price including taxes, and taxes are defined at line level 
related to design defect 0032265 closed aferraz Openbravo ERP [SER QA 1434] Taxes at document level are not properly calculated in some cases 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-02 13:34marvintmNew Issue
2017-02-02 13:34marvintmAssigned To => marvintm
2017-02-02 13:34marvintmRegression level => QA functional test
2017-02-02 13:34marvintmRegression date => 2016-11-01
2017-02-02 13:34marvintmRegression introduced in release => main
2017-02-02 13:34marvintmRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/19f3df300f234399cf2a42837690936fc8eb8542 [^]
2017-02-02 13:34marvintmTriggers an Emergency Pack => No
2017-02-02 13:35marvintmStatusnew => scheduled
2017-02-02 19:22marvintmRelationship addedrelated to 0034360
2017-02-06 13:54hgbotCheckin
2017-02-06 13:54hgbotNote Added: 0094083
2017-02-06 13:55hgbotCheckin
2017-02-06 13:55hgbotNote Added: 0094084
2017-02-06 13:55hgbotStatusscheduled => resolved
2017-02-06 13:55hgbotResolutionopen => fixed
2017-02-06 13:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d0d6d86c29a41986265b87bfaf63d4122f4f0064 [^]
2017-02-07 18:00guilleaerReview Assigned To => guilleaer
2017-02-07 18:00guilleaerStatusresolved => closed
2017-02-07 18:00guilleaerFixed in Version => RR17Q2
2017-03-06 14:24aferrazRelationship addedrelated to 0032265

Notes
(0094083)
hgbot   
2017-02-06 13:54   
Repository: tools/automation/pi-mobile
Changeset: 8d200a98f662e9b5465c17511fae6ac0ae2bc5e1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Feb 06 11:27:49 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/8d200a98f662e9b5465c17511fae6ac0ae2bc5e1 [^]

Related to issue 35138. Added automated tests

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/taxes/DifferentNonDependantTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/taxes/MultipleLinesSameProductCascadeTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/taxes/ThreeProductsCascadeTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/taxes/TwoProductsCascadeTaxes.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/taxes/WebPOSTaxTerminalHelper.java
---
(0094084)
hgbot   
2017-02-06 13:55   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d0d6d86c29a41986265b87bfaf63d4122f4f0064
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Feb 02 19:24:48 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d0d6d86c29a41986265b87bfaf63d4122f4f0064 [^]

Fixed issue 35138. Now taxes at header level will be calculated correctly in price including taxes+taxes at line level.
The taxes object will not be reset, so the previously calculated value (which comes from the sum of the taxes of each line) will be preserved in case the taxes are defined to be calculated at line level. If they are defined to be calculated at header level, the value will be overwritten in the loop which iterates through the taxGroups.

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---