Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035136Openbravo ERPA. Platformpublic2017-02-02 11:292018-01-03 12:38
Reporterngarcia 
Assigned Tocaristu 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035136: Line seems to be saved with error when editing and saving the header
DescriptionLine seems to be saved with error when editing and saving the header
Steps To ReproduceAs group admin role:
   Create a Sales Order
   Add a product with stock to it
   Book it
   Create a goods shipment
   Select the previously created order line in the Create Lines From process
   Increase the Movement Quantity in form view
   Check the following error message is shown
      Saving failed. Movement Quantity is greater than the Ordered Quantity
   Increase the Movement Quantity in grid view
   Check the following error message is shown
      One or more rows could not be saved. Fix the problem or cancel all pending changes to return to the last saved state.
   Go to header, edit the Description and save it
   The error message is removed from the line and it seems to be saved
   Complete the shipment and check the movement quantity remains modified
   Cancel changes and check the first value is shown in the movement quantity field
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036970 closed caristu Focus placed at wrong place when editing with errors and saving the parent record 
Attached Filesdiff issue35136.diff (1,880) 2017-09-28 10:06
https://issues.openbravo.com/file_download.php?file_id=11113&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-02-02 11:29ngarciaNew Issue
2017-02-02 11:29ngarciaAssigned To => platform
2017-02-02 11:29ngarciaModules => Core
2017-02-02 11:29ngarciaTriggers an Emergency Pack => No
2017-02-10 09:13alostalePriorityhigh => urgent
2017-02-10 09:13alostaleStatusnew => acknowledged
2017-09-27 12:37caristuAssigned Toplatform => caristu
2017-09-27 12:37caristuStatusacknowledged => scheduled
2017-09-28 10:06caristuFile Added: issue35136.diff
2017-09-28 13:02caristuRelationship addedrelated to 0036970
2017-10-03 16:51hgbotCheckin
2017-10-03 16:51hgbotNote Added: 0099731
2017-10-03 16:51hgbotStatusscheduled => resolved
2017-10-03 16:51hgbotResolutionopen => fixed
2017-10-03 16:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/24a9c90c9189579484d0f1f25406b7dbb3c174b8 [^]
2017-10-03 16:52caristuReview Assigned To => alostale
2017-10-09 10:07alostaleNote Added: 0099821
2017-10-09 10:07alostaleStatusresolved => closed
2017-10-09 10:07alostaleFixed in Version => 3.0PR18Q1
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101313

Notes
(0099731)
hgbot   
2017-10-03 16:51   
Repository: erp/devel/pi
Changeset: 24a9c90c9189579484d0f1f25406b7dbb3c174b8
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Sep 28 09:47:25 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/24a9c90c9189579484d0f1f25406b7dbb3c174b8 [^]

fixes bug 35136: Line seems to be saved with error after saving the header

  When saving a record, the content of its child tabs is automatically refreshed. In case we leave a child record in error status and then we edit and save its parent record, the content of the child record is automatically refreshed with the server data and the error state in the UI disappears, nevertheless, the problem was that the edits was not being discarded properly causing the record to show outdated information.

  Now when the tab is refreshed if it contains records with errors, then the edits are discarded allowing to show the real contents of the records.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0099821)
alostale   
2017-10-09 10:07   
reviewed + tested
(0101313)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test