Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035130Openbravo ERP09. Financial managementpublic2017-02-01 14:512017-03-15 20:19
Reportervmromanos 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035130: Integrate module Cashflow Forecast into Openbravo 3 distribution
DescriptionThe Cashflow Forecast Report is currently distributed as a module, which can be easily installed through the Module Management window.

However this module is quite important from the user perspective, and it should be installed by default in every Openbravo 3 instance.

Besides adding the module into Core, we should take the chance to remove the dependencies to old Openbravo 2.50 API, and substitute them by the new Openbravo 3 API based on Process Definition.
Steps To ReproduceNA
Proposed SolutionWhen merging the module, be careful about:
1. Translation modules and packs
2. C.I. process, specially in Retail

Additional Information
TagsNo tags attached.
Relationships
related to feature request 00350893.0PR17Q2 closed nonofrancisco Openbravo ERP Integrate module Aging Balance Report into Openbravo 3 distribution 
depends on defect 0035124 closed inigosanchez Openbravo ERP Selectors in Process Definition invoked from menu show only records of organizations in the context organization's natural tree 
depends on feature request 0028947 closed nonofrancisco Openbravo ERP Add HTML output to Process Definition reports 
related to defect 0036872 closed tegik_forge Openbravo Localizations [Openbravo for Retail Spanish (Mexico)Translation]: Updates for 3.0PR17Q2 not shown in Module Management window 
related to defect 0050721 closed alostale Openbravo ERP Compilation should fail if a merged module is present in the modules source folder 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-01 14:51vmromanosNew Issue
2017-02-01 14:51vmromanosAssigned To => nonofrancisco
2017-02-01 14:51vmromanosModules => Core
2017-02-01 14:51vmromanosTriggers an Emergency Pack => No
2017-02-01 14:51vmromanosIssue generated from0035089
2017-02-01 14:51vmromanosRelationship addedrelated to 0035089
2017-02-01 14:52vmromanosRelationship addeddepends on 0035124
2017-02-01 14:52vmromanosRelationship addeddepends on 0035123
2017-02-01 14:52vmromanosStatusnew => scheduled
2017-02-01 14:52vmromanosAssigned Tononofrancisco => rqueralta
2017-02-01 14:53vmromanosRelationship addeddepends on 0028947
2017-02-01 16:22vmromanosRelationship deleteddepends on 0035123
2017-02-23 11:31hgbotCheckin
2017-02-23 11:31hgbotNote Added: 0094547
2017-02-23 11:31hgbotCheckin
2017-02-23 11:31hgbotNote Added: 0094549
2017-02-23 11:31hgbotCheckin
2017-02-23 11:31hgbotNote Added: 0094551
2017-02-23 11:32hgbotCheckin
2017-02-23 11:32hgbotNote Added: 0094554
2017-02-23 11:32hgbotStatusscheduled => resolved
2017-02-23 11:32hgbotResolutionopen => fixed
2017-02-23 11:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5db62ca1cb1427bfc226906a07a9874367ec59b4 [^]
2017-02-23 11:32hgbotCheckin
2017-02-23 11:32hgbotNote Added: 0094555
2017-02-23 11:33hgbotCheckin
2017-02-23 11:33hgbotNote Added: 0094558
2017-02-23 11:33hgbotCheckin
2017-02-23 11:33hgbotNote Added: 0094560
2017-02-23 11:33hgbotCheckin
2017-02-23 11:33hgbotNote Added: 0094562
2017-02-23 11:33hgbotCheckin
2017-02-23 11:33hgbotNote Added: 0094564
2017-02-23 11:33hgbotCheckin
2017-02-23 11:33hgbotNote Added: 0094566
2017-02-23 11:33hgbotCheckin
2017-02-23 11:33hgbotNote Added: 0094568
2017-02-23 11:33hgbotCheckin
2017-02-23 11:33hgbotNote Added: 0094570
2017-02-23 11:33hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/5db62ca1cb1427bfc226906a07a9874367ec59b4 [^] => http://code.openbravo.com/erp/devel/pi/rev/078a7874e6d0a0a8a0c1fb6cd07f2c19cfcc2cc3 [^]
2017-02-23 12:13hgbotCheckin
2017-02-23 12:13hgbotNote Added: 0094574
2017-02-23 12:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/078a7874e6d0a0a8a0c1fb6cd07f2c19cfcc2cc3 [^] => http://code.openbravo.com/erp/devel/pi/rev/3edc1a4902b1afae153a1e2c54f49e15108323fc [^]
2017-02-23 12:56vmromanosNote Added: 0094576
2017-03-03 15:05vmromanosReview Assigned To => vmromanos
2017-03-03 15:05vmromanosNote Added: 0094749
2017-03-03 15:05vmromanosStatusresolved => closed
2017-03-03 15:05vmromanosFixed in Version => 3.0PR17Q2
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095207
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095208
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095211
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095213
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095215
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095217
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095219
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095221
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095223
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095225
2017-09-18 10:37ngarciaRelationship addedrelated to 0036872
2022-11-08 08:02caristuRelationship addedrelated to 0050721

Notes
(0094547)
hgbot   
2017-02-23 11:31   
Repository: erp/pmods/org.openbravo.proflocalization.spain30.cashvat
Changeset: aaa6cd77839a8b2b719606806e7c15542e9d5fad
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Feb 03 15:17:07 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.proflocalization.spain30.cashvat/rev/aaa6cd77839a8b2b719606806e7c15542e9d5fad [^]

Related to issue 35089 and related to issue 35130:

Updated major version inclusion for Localization pack Spain (España)

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---
(0094549)
hgbot   
2017-02-23 11:31   
Repository: erp/pmods/org.openbravo.proflocalization.spain30
Changeset: 53fabea979cdee92ea4c4205449434507f916ed3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Feb 03 15:11:49 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.proflocalization.spain30/rev/53fabea979cdee92ea4c4205449434507f916ed3 [^]

Related to issue 35089 and related to issue 35130:

Updated major version inclusion for Localization pack Spain (España)

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---
(0094551)
hgbot   
2017-02-23 11:31   
Repository: erp/mods/org.openbravo.localization.spain30
Changeset: dcf7956720ad49d102fc7e8dbae54e7ca4608615
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Feb 03 14:53:37 2017 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.localization.spain30/rev/dcf7956720ad49d102fc7e8dbae54e7ca4608615 [^]

Related to issue 35089 and related to issue 35130:

Included new major version of translation pack

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---
(0094554)
hgbot   
2017-02-23 11:32   
Repository: erp/devel/pi
Changeset: 5db62ca1cb1427bfc226906a07a9874367ec59b4
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Wed Dec 21 14:06:05 2016 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/5db62ca1cb1427bfc226906a07a9874367ec59b4 [^]

Fixed issue 35130: Merged Cashflow Forecast Report into Core

---
M src-db/database/sourcedata/AD_MENU.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src-db/database/sourcedata/AD_TREENODE.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src-db/database/sourcedata/OBUIAPP_REPORT.xml
A src-db/database/model/functions/C_CONVERT_DOC_CURRENCY.xml
A src/org/openbravo/common/actionhandler/CashflowForecastReportActionHandler.java
A src/org/openbravo/common/actionhandler/CashflowForecast_data.xsql
A src/org/openbravo/erpCommon/ad_reports/CashflowForecast.jrxml
A src/org/openbravo/erpCommon/ad_reports/CashflowForecastExcel.jrxml
A src/org/openbravo/erpCommon/ad_reports/CashflowForecastLines.jrxml
A src/org/openbravo/erpCommon/ad_reports/CashflowForecastLinesByDate.jrxml
A src/org/openbravo/erpCommon/ad_reports/CashflowForecastSummary.jrxml
A src/org/openbravo/erpCommon/ad_reports/FinaccDetailByDate.jrxml
A src/org/openbravo/erpCommon/ad_reports/FinaccDetailMain.jrxml
---
(0094555)
hgbot   
2017-02-23 11:32   
Repository: erp/devel/pi
Changeset: 9c6dcce3bb7770cd03eaafeea577ad1256a792e8
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Feb 01 18:01:07 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9c6dcce3bb7770cd03eaafeea577ad1256a792e8 [^]

Related to issue 35130: code review improvements

Fixed db consistency.
Reused core's messages instead of creating new ones.
Deleted 2 jrxml files that are not needed.
Properly set menu entry for new report.
Fixed issue that hid the first record in HTML/PDF view (not XLS).
Usage of AMOUNTFORMAT and patternExpression based on it.
Removed useless SQL queries in JRXML files.
Make Strings in reports translatable.
Several jasper UI improvements: padding, link behavior, borders...

---
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src-db/database/sourcedata/AD_TREENODE.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-db/database/sourcedata/OBUIAPP_REPORT.xml
M src/org/openbravo/common/actionhandler/CashflowForecastReportActionHandler.java
M src/org/openbravo/common/actionhandler/CashflowForecast_data.xsql
M src/org/openbravo/erpCommon/ad_reports/CashflowForecast.jrxml
M src/org/openbravo/erpCommon/ad_reports/CashflowForecastExcel.jrxml
M src/org/openbravo/erpCommon/ad_reports/CashflowForecastLines.jrxml
M src/org/openbravo/erpCommon/ad_reports/CashflowForecastLinesByDate.jrxml
M src/org/openbravo/erpCommon/ad_reports/CashflowForecastSummary.jrxml
R src/org/openbravo/erpCommon/ad_reports/FinaccDetailByDate.jrxml
R src/org/openbravo/erpCommon/ad_reports/FinaccDetailMain.jrxml
---
(0094558)
hgbot   
2017-02-23 11:33   
Repository: erp/devel/pi
Changeset: f929731149b4ad7e190f62d3de37c2c44c593779
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Feb 02 17:21:08 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f929731149b4ad7e190f62d3de37c2c44c593779 [^]

Related to issue 35089 and related to issue 35130:

Declare merge for modules:
* Aging Balance Report
* Cashflow Forecast Report

Added buildvalidation to check:
1. Both merged modules are not inside modules folder
2. There are no modules in the instance that depend on any of the merged modules

---
M modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_MERGE.xml
A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck.class
A src-util/buildvalidation/src/org/openbravo/buildvalidation/MergeDependenciesCheck.java
---
(0094560)
hgbot   
2017-02-23 11:33   
Repository: erp/devel/pi
Changeset: 4c7b6e37ceb26ca406e359c5559ee2c7ee255c12
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Feb 02 17:40:19 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4c7b6e37ceb26ca406e359c5559ee2c7ee255c12 [^]

Related to issue 35089 and related to issue 35130:

Added missed subclasses .class files

---
A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$1.class
A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$MergedModule.class
---
(0094562)
hgbot   
2017-02-23 11:33   
Repository: erp/devel/pi
Changeset: 256a41b3f7dd452467a3c6d536e3693a97eff94e
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Feb 03 11:34:17 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/256a41b3f7dd452467a3c6d536e3693a97eff94e [^]

Related to issue 35089 and related to issue 35130:

Build Validation shows a warning when Multi Business Partner Selector module is detected as orphan

---
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$1.class
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$MergedModule.class
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck.class
M src-util/buildvalidation/src/org/openbravo/buildvalidation/MergeDependenciesCheck.java
---
(0094564)
hgbot   
2017-02-23 11:33   
Repository: erp/devel/pi
Changeset: f48e0974234f8f0d345ffd2b602029ca95b9edf9
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Feb 06 12:51:50 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f48e0974234f8f0d345ffd2b602029ca95b9edf9 [^]

Related to issue 35089 and related to issue 35130:
Added net.sf.jasperreports.export.xls.detect.cell.type property to properly export numbers in Excel

---
M src/org/openbravo/erpCommon/ad_reports/AgingScheduleXLS.jrxml
M src/org/openbravo/erpCommon/ad_reports/CashflowForecastExcel.jrxml
---
(0094566)
hgbot   
2017-02-23 11:33   
Repository: erp/devel/pi
Changeset: 82e00b6399143505b821618b4cb806eaccca42c5
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Feb 07 13:54:23 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/82e00b6399143505b821618b4cb806eaccca42c5 [^]

Related to issue 35089 and related to issue 35130:
Fixed db consistency after merge

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
---
(0094568)
hgbot   
2017-02-23 11:33   
Repository: erp/devel/pi
Changeset: 9610f6267285fd195efec94fcff0d7991cda34a3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Feb 07 13:56:33 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9610f6267285fd195efec94fcff0d7991cda34a3 [^]

Related to issue 35089 and related to issue 35130:
Updated execution limits

---
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck.class
M src-util/buildvalidation/src/org/openbravo/buildvalidation/MergeDependenciesCheck.java
---
(0094570)
hgbot   
2017-02-23 11:33   
Repository: erp/devel/pi
Changeset: 078a7874e6d0a0a8a0c1fb6cd07f2c19cfcc2cc3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Feb 23 11:32:02 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/078a7874e6d0a0a8a0c1fb6cd07f2c19cfcc2cc3 [^]

Fixed issue 35089 and fixed issue 35130:
Updated execution limits

---
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck.class
M src-util/buildvalidation/src/org/openbravo/buildvalidation/MergeDependenciesCheck.java
---
(0094574)
hgbot   
2017-02-23 12:13   
Repository: erp/devel/pi
Changeset: 3edc1a4902b1afae153a1e2c54f49e15108323fc
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Feb 23 12:14:48 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3edc1a4902b1afae153a1e2c54f49e15108323fc [^]

Fixed issue 35089 and fixed issue 35130:

Fixed build validation when MultipleBP selector is not installed

---
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$1.class
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$MergedModule.class
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck.class
M src-util/buildvalidation/src/org/openbravo/buildvalidation/MergeDependenciesCheck.java
---
(0094576)
vmromanos   
2017-02-23 12:56   
Test plan I:
Log in as Openbravo Admin
Go to Aging Balance Report window. Verify the window is available
Fill the mandatory filters and launch the report in HTML, PDF and XLS format.
Verify all of them are properly generated.

Other testing done related to the merges:
0. In the same instance, ensure we get the same figures with the external module and after the merge
1. Publishing the OB 3 template [org.openbravo.v3] with the new 2 merges.
2. Update of an old instance without Aging/CashflowForecast to the new OB version works fine (very basic scenario)
3. Once the new OB3 is available in the central repository, try to install any of the merged modules (Aging/CashflowForecast) in an old local instance
4. In an old instance with the Aging/CashFlow, if I try to update OB3, it properly detectes the merge and deletes the merged modules
5. Update of an old instance with Aging/CashflowForecast, its translation modules and the es_ES translation pack works fine
6. Update of an old instance with the Aging/Cashflow, its translation and the splp works fine
7. The new build validation properly shows an error when:
7.1. Detected Cashflow Forecast/Aging Balance modules installed in the instance
7.2. Detected any declared dependency to Cashflow Forecast/Aging Balance
8. The build validatio shows a warning when:
8.1. Detected orphan Multi business partner selector module
9. The build validation doesn't show warning/error in other scenarios
(0094749)
vmromanos   
2017-03-03 15:05   
Code review + testing OK
(0095207)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095208)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095211)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095213)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095215)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095217)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095219)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095221)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095223)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095225)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test