Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035119Retail ModulesWeb POSpublic2017-02-01 10:022017-02-10 13:49
Reporterguillermogil 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035119: OBPOS_NewReceipt hook is not opening popups on login
DescriptionOBPOS_NewReceipt hook is not opening popups on login although it is working fine if you click '*' (new) button.
Steps To Reproduce- Implement OBPOS_NewReceipt hook

Example:
OB.UTIL.HookManager.registerHook('OBPOS_NewReceipt', function (args, callbacks) {
  OB.MobileApp.view.waterfall('onShowPopup', {
    popup: 'receiptPropertiesDialog'
  });
  OB.UTIL.HookManager.callbackExecutor(args, callbacks);
});
You will see on login that there is an scrim and no popup
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035269 closed mario_castello Test I35119_ShowPoupInNewOrderHokkOnLogin is failing in quarantine 
related to defect 0036985 closed ranjith_qualiantech_com We are triggering twice window:ready 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-01 10:02guillermogilNew Issue
2017-02-01 10:02guillermogilAssigned To => Retail
2017-02-01 10:02guillermogilResolution time => 1487718000
2017-02-01 10:02guillermogilTriggers an Emergency Pack => No
2017-02-03 13:23jorge-garciaAssigned ToRetail => jorge-garcia
2017-02-03 13:23jorge-garciaStatusnew => acknowledged
2017-02-03 13:25jorge-garciaStatusacknowledged => scheduled
2017-02-06 08:41hgbotCheckin
2017-02-06 08:41hgbotNote Added: 0094059
2017-02-06 08:41hgbotStatusscheduled => resolved
2017-02-06 08:41hgbotResolutionopen => fixed
2017-02-06 08:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/595473a3ad7fca588a1b7fb667bca94cc5e50701 [^]
2017-02-06 08:47hgbotCheckin
2017-02-06 08:47hgbotNote Added: 0094060
2017-02-06 10:50marvintmReview Assigned To => marvintm
2017-02-06 10:50marvintmStatusresolved => closed
2017-02-06 10:50marvintmFixed in Version => RR17Q2
2017-02-06 13:03guillermogilNote Added: 0094081
2017-02-06 13:03guillermogilStatusclosed => new
2017-02-06 13:03guillermogilResolutionfixed => open
2017-02-06 13:03guillermogilFixed in VersionRR17Q2 =>
2017-02-06 17:37jorge-garciaStatusnew => scheduled
2017-02-07 15:25hgbotCheckin
2017-02-07 15:25hgbotNote Added: 0094127
2017-02-07 15:26jorge-garciaStatusscheduled => resolved
2017-02-07 15:26jorge-garciaFixed in Version => RR17Q2
2017-02-07 15:26jorge-garciaResolutionopen => fixed
2017-02-10 13:49marvintmStatusresolved => closed
2017-02-15 10:57jorge-garciaRelationship addedrelated to 0035269
2017-10-02 16:59migueldejuanaRelationship addedrelated to 0036985

Notes
(0094059)
hgbot   
2017-02-06 08:41   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 595473a3ad7fca588a1b7fb667bca94cc5e50701
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Feb 03 14:47:23 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/595473a3ad7fca588a1b7fb667bca94cc5e50701 [^]

Fixed issue 35119: OBPOS_NewReceipt hook is not opening popups on login

Render pointofsale window when the load of models of masterdata is done.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0094060)
hgbot   
2017-02-06 08:47   
Repository: tools/automation/pi-mobile
Changeset: 8a9749abe6a06354c541d25f06cfc300146b6477
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Feb 03 14:55:21 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/8a9749abe6a06354c541d25f06cfc300146b6477 [^]

Verifies issue 35119: OBPOS_NewReceipt hook is not opening popups on login

Added test I35119_ShowPoupInNewOrderHokkOnLogin.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35119_ShowPoupInNewOrderHokkOnLogin.java
---
(0094081)
guillermogil   
2017-02-06 13:03   
Reopened due to a wrong behavior on showing the popup on the hook.
It is opening perfectly but it is not working properly, values are not getting saved.
It seems to be due to duplicated window ready triggers.
(0094127)
hgbot   
2017-02-07 15:25   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4729f5935750dd6a632b63033c2bd3ab21305d46
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Feb 06 16:59:28 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4729f5935750dd6a632b63033c2bd3ab21305d46 [^]

Related to issue 35119: OBPOS_NewReceipt hook is not opening popups on login

Avoid execution of rendering the main window of the application if it’s
already done.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---