Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0035107Openbravo ERP09. Financial managementpublic2017-01-31 13:562017-09-21 16:50
maite 
CSousa 
highminoralways
closedfixed 
5
 
3.0PR17Q4 
aferraz
Core
No
0035107: To include "line_id" information in fact_acct when posting "Undeductable" invoice line tax in Purchase Invoice
When posting a Purchase Invoice, in case tax rate is defined as "Tax not deductible", an specific fact_acct record is created beucase product's account should be used instead of tax's account. In that case, it would be usefull to add "line_id" information in fact_acct record to track specific invoice line related with each accounting entry
1. Access Tax Rate window, search for "Adquisiciones IVA 4%" and set it as "Tax not deductible"
2. Register new Purchase Invoice for any Org and BP. Add any line and set "Adquisiciones IVA 4%" tax. Process invoice and post it
3. Verify accounting information related with this invoice via database and realize that "line_id" field is empty in records pointing to taxes:

select line_id from fact_acct where record_id='INVOICE_ID' and c_tax_id is not null;
In DocInvoice.java class, add "line_id" information when docLine1 is created (line 871):

docLine1.m_TrxLine_ID = data[j].cInvoicelineId;
No tags attached.
Issue History
2017-01-31 13:56maiteNew Issue
2017-01-31 13:56maiteAssigned To => Triage Finance
2017-01-31 13:56maiteModules => Core
2017-01-31 13:56maiteTriggers an Emergency Pack => No
2017-01-31 13:56maiteIssue Monitored: networkb
2017-04-20 11:23CSousaNote Added: 0096085
2017-05-08 13:29CSousaStatusnew => scheduled
2017-05-08 13:29CSousaAssigned ToTriage Finance => CSousa
2017-09-18 16:24hgbotCheckin
2017-09-18 16:24hgbotNote Added: 0099121
2017-09-18 16:24hgbotStatusscheduled => resolved
2017-09-18 16:24hgbotResolutionopen => fixed
2017-09-18 16:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0daf8bc29298e93172de694ef63555fe248b15d5 [^]
2017-09-18 16:26aferrazReview Assigned To => aferraz
2017-09-18 16:26aferrazNote Added: 0099122
2017-09-18 16:26aferrazStatusresolved => closed
2017-09-18 16:26aferrazFixed in Version => 3.0PR17Q4
2017-09-21 16:50hudsonbotCheckin
2017-09-21 16:50hudsonbotNote Added: 0099410

Notes
(0096085)
CSousa   
2017-04-20 11:23   
1. Access Tax Rate window, search for "Adquisiciones IVA 4%" and set it as "Tax not deductible"
2. Register new Purchase Invoice for any Org and BP. Add any line and set "Adquisiciones IVA 4%" tax. Process invoice and post it
3. Verify accounting information related with this invoice via database and realize that "line_id" field is filled in records pointing to taxes:

select line_id from fact_acct where record_id='INVOICE_ID' and c_tax_id is not null;
(0099121)
hgbot   
2017-09-18 16:24   
Repository: erp/devel/pi
Changeset: 0daf8bc29298e93172de694ef63555fe248b15d5
Author: Carlos Sousa <carlos.sousa <at> openbravo.com>
Date: Thu Apr 20 11:18:53 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0daf8bc29298e93172de694ef63555fe248b15d5 [^]

Fixes issue 35107: To include "line_id" information in fact_acct when
posting "Undeductable" invoice line tax in Purchase Invoice.

"line_id" information included in fact_acct when a
"Undeductable" invoice line tax in Purchase Invoice has been posted

---
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
---
(0099122)
aferraz   
2017-09-18 16:26   
Code review + Testing OK
(0099410)
hudsonbot   
2017-09-21 16:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test