0035081: Wrong behaviour when the attribute included in an attribute set is named lot, serno or DateFrom - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

ID

Project

Category

View Status

Date Submitted

Last Update

0035081

Openbravo ERP

04. Warehouse management

public

2017-01-30 10:56

2017-03-21 15:26

Reporter

ngarcia

Assigned To

collazoandy4

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

5

OS Version

Product Version

Target Version

Fixed in Version

3.0PR17Q2

Merge Request Status

Review Assigned To

markmm82

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0035081: Wrong behaviour when the attribute included in an attribute set is named lot, serno or DateFrom

Description

Wrong behaviour when the attribute included in an attribute set is named lot, serno or DateFrom. Its values are saved in the lot, serno and guaranteedate of the m_attributesetinstance table, which are reserved for attribute sets defined as Lot, Serial No. and Expiration date respectively

Steps To Reproduce

As group admin role:
   Create the following three attributes:
      1. Name: serno
         Instance Attribute: N
         List: N
         Mandatory: Y
      2. Name: lot
         Instance Attribute: N
         List: N
         Mandatory: Y
      3. Name: DateFrom
         Instance Attribute: N
         List: N
         Mandatory: Y
   Create a new attribute set:
      Lot: N
      Serial No.: N
      Expiration Date: N
   Add the previously created attributes to it
   Create a new product and assign the previously created attribute set to it
   Create a Goods Receipt, add the previously created product and check the Attribute Set Value field is shown
   Open it and add a value to its attributes

   Check in the m_attributesetinstance tables that the values are saved in lot, serno and guaranteedate of the m_attributesetinstance table when it should not

Proposed Solution

Check if it should not be allowed to create attributes with the following names:

- lot
- serno
- DateFrom

Additional Information

Tags

No tags attached.

Relationships

related to

defect

0035080

closed

collazoandy4

Cannot set an attribute set value in a warehouse document line in case it does not contain an instance attribute

Attached Files

Issue History

Date Modified

Username

Field

Change

2017-01-30 10:56

New Issue

2017-01-30 10:56

Assigned To

=> Triage Finance

2017-01-30 10:56

Modules

=> Core

2017-01-30 10:56

Resolution time

=> 1487545200

2017-01-30 10:56

Triggers an Emergency Pack

=> No

2017-01-30 10:57

Relationship added

related to 0035080

2017-01-30 15:54

Assigned To

Triage Finance => collazoandy4

2017-02-09 16:31

collazoandy4

Status

new => scheduled

2017-02-09 16:32

collazoandy4

Note Added: 0094185

2017-03-20 00:37

Note Added: 0095407

2017-03-20 17:46

Checkin

2017-03-20 17:46

Note Added: 0095433

2017-03-20 17:46

Status

scheduled => resolved

2017-03-20 17:46

Resolution

open => fixed

2017-03-20 17:46

Fixed in SCM revision

=> http://code.openbravo.com/erp/devel/pi/rev/5cf30e40a1ab9545d4c3aa36aec239b041b4cede [^]

2017-03-20 17:50

Review Assigned To

=> markmm82

2017-03-20 17:50

Note Added: 0095434

2017-03-20 17:50

Status

resolved => closed

2017-03-20 17:50

Fixed in Version

=> 3.0PR17Q2

2017-03-21 15:26

Checkin

2017-03-21 15:26

Note Added: 0095474

Notes

Test Plan 1 Defining new attributes in an attribute set without use of the predefined attributes lot, serno and DateFrom
As group admin role:
   0- Create the following three attributes:
      a. Name: serno
         Instance Attribute: N
         List: N
         Mandatory: Y
      b. Name: lot
         Instance Attribute: N
         List: N
         Mandatory: Y
      c. Name: DateFrom
         Instance Attribute: N
         List: N
         Mandatory: Y

   1- Create a new attribute set:
      Lot: N
      Serial No.: N
      Expiration Date: N
   2- Add the previously created attributes to it
   3- Create a new product and assign the previously created attribute set to it
   4- Create a Goods Receipt, add the previously created product and check the Attribute Set Value field is shown
   5- Open it and add a value to its attributes, for instance:
      serno: 1
      lot: 2
      DateFrom: 3
   6- Save and notice when the popup is closed, the description field is updated with concatenation of the previously filled attribute values: 1_2_3.
   7- Open the selector again, and notice all the attributes are correctly filled with its values.
   Check in the m_attributesetinstance tables that the values are NOT saved in lot, serno and guaranteedate of the m_attributesetinstance table.

Test Plan 2 Defining new attributes in an attribute set AND using the predefined attributes lot, serno and DateFrom
As group admin role:
   0- You can use the same attributes created in step 0 from Test Plan 1.
   1- Create a new attribute set:
      Lot: Y
      Serial No.: Y
      Expiration Date: Y
   2- Add the previously created attributes to it
   3- Create a new product and assign the previously attribute set to it
   4- Create a Goods Receipt, add the previously created product and check the Attribute Set Value field is shown
   5- Open it and add a value to its attributes, for instance:
      serno: 1
      lot: 2
      DateFrom: 3
      Lot: 4
      Serial No.: 5
      Expiration Date: 2017-03-17
   6- Save and notice when the popup is closed, the description field is updated with concatenation of the previously filled attribute values: 1_2_3_L4_#5_17-03-2017.
   7- Open the selector again, and notice all the attributes are correctly filled with its values.
   Check in the m_attributesetinstance tables that the values related to the predefined attributes are saved in lot, serno and guaranteedate of the m_attributesetinstance table.

Test Plan 3 Using the predefined attributes lot, serno and DateFrom
As group admin role:
   1- Create a new attribute set:
      Lot: Y
      Serial No.: Y
      Expiration Date: Y
   2- Do not add attributes to it
   3- Create a new product and assign the previously attribute set to it
   4- Create a Goods Receipt, add the previously created product and check the Attribute Set Value field is shown
   5- Open it and add a value to its attributes, for instance:
      Lot: 1
      Serial No.: 2
      Expiration Date: 2017-03-17
   6- Save and notice when the popup is closed, the description field is updated with concatenation of the previously filled attribute values: L1_#2_17-03-2017.
   7- Open the selector again, and notice all the attributes are correctly filled with its values.
   Check in the m_attributesetinstance tables that the values related to the predefined attributes are saved in lot, serno and guaranteedate of the m_attributesetinstance table.