Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035079Retail ModulesStoreServerpublic2017-01-30 10:442017-03-09 16:30
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q2Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035079: Use getColumnValue instead of datamap for performance reasons
DescriptionIn the related issue changes have been made to do specific routing in case of values in product or warehouse records. The new code uses the datamap [1] to get column values from replicated data. This is fine but later a new approach is available which is much faster (a method called getColumnValue [2]).

[1]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.storeserver.synchronization-but/rev/6c3ca8c0adec#l4.56 [^]

https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.storeserver.synchronization-but/rev/6c3ca8c0adec#l5.50 [^]

https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.storeserver.synchronization-but/rev/6c3ca8c0adec#l6.56 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/6d03ea7ce9a4/src/org/openbravo/replication/symmetricds/extensions/AbstractOpenbravoRouter.java#l59 [^]
Steps To ReproduceSee description
Proposed SolutionSee this commit [1] for a similar change which need to be made.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/diff/a38a9fa72d35/src/org/openbravo/replication/symmetricds/extensions/AbstractOrganizationBasedRouter.java#l1.24 [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0035037 closed mtaal Override synchronized table and export dataset to consider nosica store id 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-01-30 10:44mtaalNew Issue
2017-01-30 10:44mtaalAssigned To => mtaal
2017-01-30 10:44mtaalTriggers an Emergency Pack => No
2017-01-30 10:44mtaalRelationship addedrelated to 0035037
2017-03-08 12:10mtaalStatusnew => scheduled
2017-03-08 12:10mtaalNote Added: 0094819
2017-03-08 12:10mtaalStatusscheduled => resolved
2017-03-08 12:10mtaalResolutionopen => fixed
2017-03-09 09:39mtaalReview Assigned To => AugustoMauch
2017-03-09 16:30AugustoMauchNote Added: 0094883
2017-03-09 16:30AugustoMauchStatusresolved => closed

Notes
(0094819)
mtaal   
2017-03-08 12:10   
Resolved with this commit:
https://bitbucket.org/gpscode/com.openbravo.but.integration.copystores.synchronization/commits/cf733591cbe9fe252e731e069a60061970dd22a4 [^]
(0094883)
AugustoMauch   
2017-03-09 16:30   
Code reviewed and verified