Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0035077 | Retail Modules | Web POS | public | 2017-01-19 09:34 | 2017-03-15 14:11 |
|
| Reporter | marvintm | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | RR17Q1 | Fixed in Version | RR17Q1 | |
| Merge Request Status | |
| Review Assigned To | guilleaer |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0035077: Discounts priority is not properly taken into account if incremental refresh updates the discount information |
| Description | Discounts defined in the system should be applied following order of priority. When the Web POS is initially loaded, this works correctly. However, if incremental refresh later on updates some discounts, this may stop working properly.
The reason for this is that the query executed in the client-side doesn't contain an explicit order, which means that it implicitly uses the "_idx" property, automatically generated when records are loaded from the backend. The query in the backed does have proper order, so it works correctly on the first load.
However, if incremental refresh is triggered and it either adds new discounts, or updates previously existing discounts, their corresponding value for the idx column will reset to 0, and in this case, their effective priority will no longer be valid. |
| Steps To Reproduce | - Define two discounts over the same product, disc1 and disc2 (disc1 priority=20, disc2 priority=40). They should not have the "apply next discount" checked.
- Log in the Web POS. Add the product to the ticket. Notice that the disc1 is applied. Delete the ticket.
- Go to the backend. Change the disc2 name and save.
- Go back to the web pos, and refresh the page (F5).
- Add the same product again. Notice that now the disc2 is applied instead. This is wrong. |
| Proposed Solution | In the executor.js file, in the query executed for the Discounts, an orderby of priority and id should be added. Once this is done, the problem will no longer happen. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | blocks | defect | 0035006 | | closed | ranjith_qualiantech_com | Discounts priority is not properly taken into account if incremental refresh updates the discount information |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-01-30 09:46 | marvintm | Type | defect => backport |
| 2017-01-30 09:46 | marvintm | Target Version | => RR17Q1 |
| 2017-01-30 12:57 | hgbot | Checkin | |
| 2017-01-30 12:57 | hgbot | Note Added: 0093930 | |
| 2017-01-30 12:57 | hgbot | Status | scheduled => resolved |
| 2017-01-30 12:57 | hgbot | Resolution | open => fixed |
| 2017-01-30 12:57 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c22376541cdcaed876f82bac2cb2faa2a87a08da [^] => http://code.openbravo.com/retail/backports/3.0RR17Q1/org.openbravo.retail.posterminal/rev/e4d2663673c31535c305556f157652706534358a [^] |
| 2017-01-30 12:58 | hgbot | Checkin | |
| 2017-01-30 12:58 | hgbot | Note Added: 0093931 | |
| 2017-02-02 11:31 | guilleaer | Review Assigned To | => guilleaer |
| 2017-02-02 11:31 | guilleaer | Status | resolved => closed |
| 2017-02-02 11:31 | guilleaer | Fixed in Version | => RR17Q1 |
| 2017-03-15 14:11 | hgbot | Checkin | |
| 2017-03-15 14:11 | hgbot | Note Added: 0095040 | |