Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035025Retail ModulesWeb POSpublic2017-01-23 10:412017-04-06 17:43
ReporterSandrahuguet 
Assigned Toebecerra 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035025: Multiple and unnecessary requests to BPLocation in new business partner selector
DescriptionMultiple and unnecessary requests to BPLocation in new business partner selector. See attached screenshot.
Steps To Reproduce- Enable all high volumes preference
- Log in the WebPOS
- Open developers tools
- Tap on delete ticket, notice that there are multiple requests to BPLocation
Proposed Solution
Additional Information
TagsPerformance
Relationships
depends on backport 0035719RR17Q1.1 closed jorge-garcia Multiple and unnecessary requests to BPLocation in new business partner selector 
related to defect 0035108 new Retail [RR17Q1][StoreServer][HighVol] It is possible to add products to a receipt different to the right one 
related to defect 0035109 scheduled migueldejuana [RR17Q1][StoreServer][HighVol] Adding products to the receipt is too slow 
Attached Filespng multiplerequest.png (234,584) 2017-01-23 10:41
https://issues.openbravo.com/file_download.php?file_id=10333&type=bug
png

diff posterminal_35025.diff (2,063) 2017-01-23 13:52
https://issues.openbravo.com/file_download.php?file_id=10337&type=bug
diff posterminal_35025_2.diff (2,668) 2017-02-01 12:36
https://issues.openbravo.com/file_download.php?file_id=10372&type=bug
diff posterminal_35025_3.diff (10,614) 2017-02-01 18:00
https://issues.openbravo.com/file_download.php?file_id=10375&type=bug
diff posterminal_35025_4.diff (696) 2017-02-02 13:21
https://issues.openbravo.com/file_download.php?file_id=10377&type=bug
diff posterminal_35025_5.diff (2,482) 2017-02-03 09:59
https://issues.openbravo.com/file_download.php?file_id=10392&type=bug
diff posterminal_35025_6.diff (2,814) 2017-02-27 14:36
https://issues.openbravo.com/file_download.php?file_id=10499&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-01-23 10:41SandrahuguetNew Issue
2017-01-23 10:41SandrahuguetAssigned To => ebecerra
2017-01-23 10:41SandrahuguetFile Added: multiplerequest.png
2017-01-23 10:41SandrahuguetTriggers an Emergency Pack => No
2017-01-23 13:35SandrahuguetTag Attached: Performance
2017-01-23 13:52ebecerraFile Added: posterminal_35025.diff
2017-01-26 11:00hgbotCheckin
2017-01-26 11:00hgbotNote Added: 0093836
2017-01-26 11:00hgbotStatusnew => resolved
2017-01-26 11:00hgbotResolutionopen => fixed
2017-01-26 11:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0de1e8153ab54ea3a85966843aa178717edf1107 [^]
2017-01-26 15:39SandrahuguetReview Assigned To => marvintm
2017-01-27 10:28ebecerraNote Added: 0093870
2017-01-31 08:51marvintmNote Added: 0093953
2017-01-31 08:51marvintmStatusresolved => new
2017-01-31 08:51marvintmResolutionfixed => open
2017-02-01 11:20jorge-garciaRelationship addedrelated to 0035108
2017-02-01 12:36ebecerraFile Added: posterminal_35025_2.diff
2017-02-01 18:00ebecerraFile Added: posterminal_35025_3.diff
2017-02-02 13:21ebecerraFile Added: posterminal_35025_4.diff
2017-02-03 09:59ebecerraFile Added: posterminal_35025_5.diff
2017-02-07 09:30hgbotCheckin
2017-02-07 09:30hgbotNote Added: 0094109
2017-02-07 09:30hgbotStatusnew => resolved
2017-02-07 09:30hgbotResolutionopen => fixed
2017-02-07 09:30hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0de1e8153ab54ea3a85966843aa178717edf1107 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/90c74c3d4836ea5c760aae880079bf1e6b24c31a [^]
2017-02-10 14:43marvintmNote Added: 0094220
2017-02-10 14:43marvintmStatusresolved => new
2017-02-10 14:43marvintmResolutionfixed => open
2017-02-16 18:15aaroncaleroNote View State: private: 93953
2017-02-17 09:38aaroncaleroNote View State: public: 93953
2017-02-23 09:47ebecerraFile Added: posterminal_35025_6.diff
2017-02-27 12:42jonibcIssue Monitored: jonibc
2017-02-27 14:36ebecerraFile Deleted: posterminal_35025_6.diff
2017-02-27 14:36ebecerraFile Added: posterminal_35025_6.diff
2017-03-08 12:58hgbotCheckin
2017-03-08 12:58hgbotNote Added: 0094830
2017-03-08 12:58hgbotStatusnew => resolved
2017-03-08 12:58hgbotResolutionopen => fixed
2017-03-08 12:58hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/90c74c3d4836ea5c760aae880079bf1e6b24c31a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e5322aa10299b508f8845f2cb435b3fe7f27266e [^]
2017-03-09 17:25marvintmStatusresolved => closed
2017-03-09 17:25marvintmFixed in Version => RR17Q2
2017-03-17 09:30SandrahuguetRelationship addedrelated to 0035109
2017-04-06 17:43marvintmStatusclosed => new
2017-04-06 17:43marvintmResolutionfixed => open
2017-04-06 17:43marvintmFixed in VersionRR17Q2 =>
2017-04-06 17:43marvintmStatusnew => scheduled
2017-04-06 17:43marvintmStatusscheduled => resolved
2017-04-06 17:43marvintmFixed in Version => RR17Q2
2017-04-06 17:43marvintmResolutionopen => fixed
2017-04-06 17:43marvintmStatusresolved => closed

Notes
(0093836)
hgbot   
2017-01-26 11:00   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0de1e8153ab54ea3a85966843aa178717edf1107
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Thu Jan 26 11:00:02 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0de1e8153ab54ea3a85966843aa178717edf1107 [^]

Fixed issue 35025: Optmize call to get BPLocation

---
M web/org.openbravo.retail.posterminal/js/components/modalreceiptproperties.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0093870)
ebecerra   
2017-01-27 10:28   
The multiples request to BPLocation was solved and now only two call to backend are done when a new ticket is created.

* Showing address shipping and invoice buttons in receipt panel (js/components/bplocation.js -> OB.UI.BPLocationShip.buttonShowing)

* Showing address shipping and invoice buttons receipt properties dialog (js/components/modalreceiptproperties.js -> OB.UI.ModalReceiptPropertiesImpl.init on model "change" event)
(0093953)
marvintm   
2017-01-31 08:51   
It's ok to do a request to bplocation to find out if two buttons need to be shown. However, these requests shouldn't happen every time a new ticket is created, they should happen only once, when terminal is loaded for the first time.
(0094109)
hgbot   
2017-02-07 09:30   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 90c74c3d4836ea5c760aae880079bf1e6b24c31a
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Mon Feb 06 12:14:23 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/90c74c3d4836ea5c760aae880079bf1e6b24c31a [^]

Fixed issue 35025: Optmize call to get BPLocation (v2)

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
M web/org.openbravo.retail.posterminal/js/components/businesspartner_selector.js
M web/org.openbravo.retail.posterminal/js/components/modalreceiptproperties.js
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0094220)
marvintm   
2017-02-10 14:43   
Now there is a flow which is not working correctly:

- In VBS Customer, I create an address just for shipping and assign it to the ticket, and then another just for invoicing, and assign it to the ticket
- Before, two buttons would appear. However, now, only one button appears, and this is not correct.

Problem seems to be this line:

OB.MobileApp.model.get('businessPartner').locations

which should be this instead:

 OB.MobileApp.model.get('businessPartner').get('locations')
(0094830)
hgbot   
2017-03-08 12:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e5322aa10299b508f8845f2cb435b3fe7f27266e
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Wed Mar 08 12:57:33 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e5322aa10299b508f8845f2cb435b3fe7f27266e [^]

Fixed issue 35025: Update default BP locations cache when edit address

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
---