Openbravo Issue Tracking System - Openbravo ERP |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0035015 | Openbravo ERP | 04. Warehouse management | public | 2017-01-19 18:28 | 2017-03-15 20:18 |
|
Reporter | maite | |
Assigned To | collazoandy4 | |
Priority | urgent | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | | Fixed in Version | 3.0PR17Q2 | |
Merge Request Status | |
Review Assigned To | markmm82 |
OBNetwork customer | OBPS |
Web browser | |
Modules | Core |
Support ticket | 45080 |
Regression level | Pre packaging ( pi ) |
Regression date | 2017-01-04 |
Regression introduced in release | pi |
Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/e55d9bf9a2b7 [^] |
Triggers an Emergency Pack | No |
|
Summary | 0035015: Organization's natural tree error in cost adjustment line's structure |
Description | Cost adjustment lines maintain a "tree" structure through property "parentCostAdjustmentLine", to understand what lines were adjusted as a consequence of another line
In case this structure is violated, following error will be raised:
ERROR:
Entity 1000000 - 19-01-2017 - 19-01-2017 - C- - maite - -1 - 1.00 - 20 (CostAdjustmentLine) with organization F&B España - Región Norte references an entity 1000000 - 19-01-2017 - 05-01-2017 - V+ - maite - 1 - 0 - 10 through its property parentCostAdjustmentLine but this referenced entity belongs to an organization F&B España - Región Sur which is not part of the natural tree of F&B España - Región Norte |
Steps To Reproduce | 1. Create new product for * organization. Define price of 20 to Tarifa de Ventas and price of 10 to Tarifa Bebidas Alegres
2. Create purchase order for "España region norte", "Bebidas Alegres", date=13-01-2017. Add line for previous product with price=10 and process
3. Create Goods Receipt for "España region norte", "Bebidas Alegres", date=13-01-2017. Run "create lines from" and select previous order. Process
4. Run "Costing Background Process" and verify that transacion has been properly calculated
5. Create Goods Shipment for "España region norte", "Bebidas Alegres", date=19-01-2017. Add line for same product and process.
6. Run "Costing Background Process" and verify that transacion has been properly calculated
7. Create purchase order for "España region sur", "Bebidas Alegres", date=05-01-2017. Add line for previous product with price=12 and process
8. Create Goods Receipt for "España region sur", "Bebidas Alegres", date=05-01-2017. Run "create lines from" and select previous order. Process
9. Run "Costing Background Process" and verify that transacion has been properly calculated
10. Access "Costing Rule" window, select "España" record and run "Fix Backdated Transactions" process setting date 01-01-2017. Error will be raised:
Entity 1000000 - 19-01-2017 - 19-01-2017 - C- - maite - -1 - 1.00 - 20 (CostAdjustmentLine) with organization F&B España - Región Norte references an entity 1000000 - 19-01-2017 - 05-01-2017 - V+ - maite - 1 - 0 - 10 through its property parentCostAdjustmentLine but this referenced entity belongs to an organization F&B España - Región Sur which is not part of the natural tree of F&B España - Región Norte |
Proposed Solution | In order to maintain organization's structure consistency, it is necessary that all Adjustment Header and Adjustment Lines are created for "Legal" organization.
When posting Cost Adjustment document, transaction's organization should be considered (instead of cost adjustment line's organization) so previous line will post to "generic" organization |
Additional Information | |
Tags | No tags attached. |
Relationships | caused by | defect | 0034802 | | closed | rqueralta | Unhomogeneous behavior in Cost Adjustments: price difference/backdated/negative stock adjustments are created for generic orgs |
|
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2017-01-19 18:28 | maite | New Issue | |
2017-01-19 18:28 | maite | Assigned To | => Triage Finance |
2017-01-19 18:28 | maite | OBNetwork customer | => Yes |
2017-01-19 18:28 | maite | Modules | => Core |
2017-01-19 18:28 | maite | Support ticket | => 45080 |
2017-01-19 18:28 | maite | Resolution time | => 1485385200 |
2017-01-19 18:28 | maite | Triggers an Emergency Pack | => No |
2017-01-19 18:28 | maite | Relationship added | caused by 0034802 |
2017-01-19 18:30 | maite | Proposed Solution updated | |
2017-01-19 21:00 | markmm82 | Assigned To | Triage Finance => collazoandy4 |
2017-01-25 16:31 | markmm82 | Status | new => scheduled |
2017-01-25 16:35 | markmm82 | Regression level | => Pre packaging ( pi ) |
2017-01-25 16:35 | markmm82 | Regression date | => 2017-01-04 |
2017-01-25 16:35 | markmm82 | Regression introduced in release | => pi |
2017-01-25 16:35 | markmm82 | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/e55d9bf9a2b7 [^] |
2017-01-25 16:38 | collazoandy4 | Note Added: 0093826 | |
2017-01-25 16:40 | hgbot | Checkin | |
2017-01-25 16:40 | hgbot | Note Added: 0093827 | |
2017-01-25 16:40 | hgbot | Status | scheduled => resolved |
2017-01-25 16:40 | hgbot | Resolution | open => fixed |
2017-01-25 16:40 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d0aae00d14ab54c0e6f6afe210cddf0124ab558f [^] |
2017-01-25 16:42 | markmm82 | Review Assigned To | => markmm82 |
2017-01-25 16:42 | markmm82 | Note Added: 0093828 | |
2017-01-25 16:42 | markmm82 | Status | resolved => closed |
2017-01-25 16:42 | markmm82 | Fixed in Version | => 3.0PR17Q2 |
2017-01-25 20:55 | markmm82 | Status | closed => new |
2017-01-25 20:55 | markmm82 | Resolution | fixed => open |
2017-01-25 20:55 | markmm82 | Fixed in Version | 3.0PR17Q2 => |
2017-01-25 20:56 | markmm82 | Note Deleted: 0093828 | |
2017-01-25 20:57 | hgbot | Checkin | |
2017-01-25 20:57 | hgbot | Note Added: 0093831 | |
2017-01-25 21:00 | markmm82 | Status | new => scheduled |
2017-01-25 21:01 | markmm82 | Status | scheduled => resolved |
2017-01-25 21:01 | markmm82 | Fixed in Version | => 3.0PR17Q2 |
2017-01-25 21:01 | markmm82 | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/d0aae00d14ab54c0e6f6afe210cddf0124ab558f [^] => https://code.openbravo.com/erp/devel/pi/rev/09fe534692aa [^] |
2017-01-25 21:01 | markmm82 | Resolution | open => fixed |
2017-01-25 21:01 | markmm82 | Note Added: 0093832 | |
2017-01-25 21:01 | markmm82 | Status | resolved => closed |
2017-01-26 17:13 | markmm82 | Note Deleted: 0093832 | |
2017-01-26 17:14 | markmm82 | Status | closed => new |
2017-01-26 17:14 | markmm82 | Resolution | fixed => open |
2017-01-26 17:14 | markmm82 | Fixed in Version | 3.0PR17Q2 => |
2017-01-27 13:01 | psanjuan | Note Added: 0093890 | |
2017-01-27 13:24 | psanjuan | Note Added: 0093893 | |
2017-01-27 13:25 | psanjuan | Note Edited: 0093893 | bug_revision_view_page.php?bugnote_id=0093893#r14364 |
2017-01-27 13:26 | psanjuan | Note Added: 0093894 | |
2017-01-27 13:47 | psanjuan | Note Edited: 0093893 | bug_revision_view_page.php?bugnote_id=0093893#r14367 |
2017-01-27 13:52 | psanjuan | Note Edited: 0093893 | bug_revision_view_page.php?bugnote_id=0093893#r14368 |
2017-01-27 13:54 | psanjuan | Note Edited: 0093893 | bug_revision_view_page.php?bugnote_id=0093893#r14369 |
2017-01-27 13:57 | psanjuan | Note Edited: 0093894 | bug_revision_view_page.php?bugnote_id=0093894#r14371 |
2017-01-27 14:04 | psanjuan | Note Edited: 0093894 | bug_revision_view_page.php?bugnote_id=0093894#r14372 |
2017-01-27 14:05 | psanjuan | Note Edited: 0093893 | bug_revision_view_page.php?bugnote_id=0093893#r14373 |
2017-01-27 14:05 | psanjuan | Note Edited: 0093894 | bug_revision_view_page.php?bugnote_id=0093894#r14374 |
2017-01-27 14:07 | psanjuan | Note Added: 0093895 | |
2017-01-27 14:14 | psanjuan | Note Edited: 0093893 | bug_revision_view_page.php?bugnote_id=0093893#r14375 |
2017-01-27 14:14 | psanjuan | Note Edited: 0093894 | bug_revision_view_page.php?bugnote_id=0093894#r14376 |
2017-01-27 14:14 | psanjuan | Note Edited: 0093895 | bug_revision_view_page.php?bugnote_id=0093895#r14378 |
2017-01-27 14:20 | psanjuan | Note Edited: 0093895 | bug_revision_view_page.php?bugnote_id=0093895#r14379 |
2017-01-27 14:44 | psanjuan | Note Edited: 0093895 | bug_revision_view_page.php?bugnote_id=0093895#r14380 |
2017-01-27 14:46 | psanjuan | Note Added: 0093898 | |
2017-01-27 14:46 | psanjuan | Note Edited: 0093898 | bug_revision_view_page.php?bugnote_id=0093898#r14382 |
2017-01-27 14:57 | hgbot | Checkin | |
2017-01-27 14:57 | hgbot | Note Added: 0093899 | |
2017-01-27 15:00 | markmm82 | Status | new => scheduled |
2017-01-27 17:47 | markmm82 | Status | scheduled => resolved |
2017-01-27 17:47 | markmm82 | Fixed in Version | => 3.0PR17Q2 |
2017-01-27 17:47 | markmm82 | Fixed in SCM revision | https://code.openbravo.com/erp/devel/pi/rev/09fe534692aa [^] => http://code.openbravo.com/erp/devel/pi/rev/66c0ea64eed97dda72b11ee21778ea39ac5b6698 [^] |
2017-01-27 17:47 | markmm82 | Resolution | open => fixed |
2017-01-27 17:48 | markmm82 | Note Added: 0093901 | |
2017-01-27 17:48 | markmm82 | Status | resolved => closed |
2017-01-30 16:54 | markmm82 | Note Added: 0093939 | |
2017-01-30 17:54 | hgbot | Checkin | |
2017-01-30 17:54 | hgbot | Note Added: 0093942 | |
2017-03-15 20:18 | hudsonbot | Checkin | |
2017-03-15 20:18 | hudsonbot | Note Added: 0095118 | |
2017-03-15 20:18 | hudsonbot | Checkin | |
2017-03-15 20:18 | hudsonbot | Note Added: 0095119 | |
2017-03-15 20:18 | hudsonbot | Checkin | |
2017-03-15 20:18 | hudsonbot | Note Added: 0095133 | |
2017-03-15 20:18 | hudsonbot | Checkin | |
2017-03-15 20:18 | hudsonbot | Note Added: 0095142 | |
Notes |
|
(0093826)
|
collazoandy4
|
2017-01-25 16:38
|
|
Test Plan 1
As F&B International Group Admin
- Go to Product window
Create new Product for "*" organization. Define Price for "Bebidas Alegres"= 10 and "Tarifa de ventas"= 20
- Go to Purchase Order window
Register Purchase Order for "España region norte" organization, "Bebidas alegres" business partner and date = 13-01-2017.
Add line for previous product and price=10. Process it
- Go to Goods Receipt window
Register Goods Receipt for "España region norte" organization, "Bebidas alegres" business partner and date = 13-01-2017.
Run "create lines from" process, select previous order and process it
- Go to Process Request window
Run Costing Background process and verify that transaction has been properly calculated
- Go to Goods Shipment
Register Goods Shipment for "España region norte" organization, "Alimentos y Supermercados" business partner and date = 19-01-2017.
Add line for previous product. Process shipment
- Go to Process Request window
Run Costing Background process and verify that transaction has been properly calculated
- Go to Purchase Order window
Register Purchase Order for "España region sur" organization, "Bebidas alegres" business partner and date = 05-01-2017.
Add line for previous product with price = 12. Process it
- Go to Goods Receipt window
Register Goods Receipt for "España region sur" organization, "Bebidas alegres" business partner and date = 05-01-2017.
Run "create lines from" process, select previous order and process it
- Go to Process Request window
Run Costing Background process and verify that transaction has been properly calculated
- Go to Costin Rule window
Select "España" record and run "Fix Backdated Transactions"
In the popup set process date = 01-01-2017 clic on OK and no error is raice now
Test Plan 2
As F&B International Group Admin
- Go to Product window
Create new Product for "España" organization. Define Price for "Bebidas Alegres"= 5 and "Tarifa de ventas"= 7
- Go to Purchase Order window
Register Purchase Order for "España norte" organization and "Bebidas alegres" business partner.
Add line for previous product and qty=10. Process it
- Go to Goods Receipt window
Register Goods Receipt for "España norte" organization and "Bebidas alegres" business partner.
Run "create lines from" process, select previous order and process it
- Go to Process Request window
Run Costing Background process and verify that cost for this transaction is calculated to 50
- Go to Goods Shipment
Register Goods Shipment for "España norte" organization and "Alimentos y Supermercados" business partner.
Add line for previous product and qty=2. Process shipment
- Go to Process Request window
Run Costing Background process and verify that cost is calculated to 10
- Go to Purchase Invoice window
Register Purchase Invoice for "España norte" organization and "Bebidas alegres" business partner.
Run "create lines from" process, select previous receipt.
Edit invoice line to set price=7 and complete
- Run "Process Price Difference Adjustment" process for "España norte" organization, today's date and previous product
- Go to Cost Adjustment window
Verify that record has been created for "F&B España, S.A" organization
Verify in Lines tab that record has been created for "F&B España - Región Norte" organizatio |
|
|
(0093827)
|
hgbot
|
2017-01-25 16:40
|
|
Repository: erp/devel/pi
Changeset: d0aae00d14ab54c0e6f6afe210cddf0124ab558f
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Jan 24 09:24:06 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/d0aae00d14ab54c0e6f6afe210cddf0124ab558f [^]
Fixes issue 35015: Adjustment Lines are created for "Legal" organization
In order to maintain organization's structure consistency, it is necessary that
Adjustment Lines are created for "Legal" organization same as Adjustment Header
is actually created.
---
M src/org/openbravo/costing/CostAdjustmentUtils.java
---
|
|
|
(0093831)
|
hgbot
|
2017-01-25 20:57
|
|
Repository: erp/devel/pi
Changeset: 09fe534692aa1276d5c045874e655bbe0a60fcda
Author: Mark <markmm82 <at> gmail.com>
Date: Wed Jan 25 14:40:48 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/09fe534692aa1276d5c045874e655bbe0a60fcda [^]
Related to issue 35015: Posting the cost adjustment with trx's organization
When posting Cost Adjustment document, transaction's organization is considered
(instead of cost adjustment line's organization) to avoid lines will be post to
"generic" organization.
---
M src/org/openbravo/erpCommon/ad_forms/DocLineCostAdjustment_data.xsql
---
|
|
|
|
|
|
(0093893)
|
psanjuan
|
2017-01-27 13:24
(edited on: 2017-01-27 14:14) |
|
Test Case 1 - Backdated Transaction Adjustment (different organizations)
1. Create new product for * organization. Define price of 20 to Tarifa de Ventas and price of 10 to Tarifa Bebidas Alegres
2. Create purchase order for "España region norte", "Bebidas Alegres", date=13-01-2017. Add line for previous product with price=10 and process
3. Create Goods Receipt for "España region norte", "Bebidas Alegres", date=13-01-2017. Run "create lines from" and select previous order. Process
4. Run "Costing Background Process" and verify that transacion has been properly calculated
5. Create Goods Shipment for "España region norte", "Bebidas Alegres", date=19-01-2017. Add line for same product and process.
6. Run "Costing Background Process" and verify that transacion has been properly calculated
7. Create purchase order for "España region sur", "Bebidas Alegres", date=05-01-2017. Add line for previous product with price=12 and process
8. Create Goods Receipt for "España region sur", "Bebidas Alegres", date=05-01-2017. Run "create lines from" and select previous order. Process
9. Run "Costing Background Process" and verify that transacion has been properly calculated
10. Access "Costing Rule" window, select "España" record and run "Fix Backdated Transactions" process setting date 01-01-2017.
11. Go to Cost Adjustement window and verify that a new record has been created with below information:
Header
Organization = F&B España (legal with accounting).
Source Process = Backdated Transaction
Lines
Organization = Field Organization is not shown anymore.
Line Nº 10 = Source = Yes, Inventory Transaction ) Vendor receipt dated on 05-01-2017 (at a price of 20.00). Adjustement Amount = 0.00 . Unit Cost = Yes, Is Backdated Tr = Yes.
Line Nº 20 Source = No, Inventory Transaction ) Customer Shipment dated on 19-01-2017. Adjustement Amount = 13.34 (33.34-20). Unit Cost = Yes, Is Backdated Tr = No.
Needs Posting = Yes.
Post the adjustment line.
Verify below posting is shown for F&B España Euro GL:
13.34 (999000) Coste de Productos Vendidos DEBIT
13.34 (350000) Productos Terminados CREDIT
same as corresponding one for F&B International Group.
Go To Accounting tab and verify that F&B España - Region Norte is the Organization shown as customer shipment being adjusted belongs to Region Norte Org.
Test Case 2 - Manual Cost Adjustment.
Go to product window and select the product just created.
Go to Transactions tab and select the one related to F&B España - Region Sur, that is second receipt dated on 05-01-2017. Verify that the cost of that transaction is currently 200.00
Click on Manual Cost Adjustement. Enter a Total Cost Amount = 300 with an accounting date = 05-01-2017.
Press Done.
Go to Cost Adjustment window and verify that a new one has been created for F&B España, source "Manual Cost Correction".
Line 10 for an adjust amount = 100.00 (vendor receipt Of F&B España Region Sur).
Line 20 for an adjust amount= 13.32 (Customer shipment of F&B España Region Norte)
Post it.
Go to accounting tab and filter by F&B España Euro General Ledger.
Verify that there are two lines related to Region Sur org for an amount = 100.00
and two more lines related to Region Norte org for an amount = 13.32
|
|
|
(0093894)
|
psanjuan
|
2017-01-27 13:26
(edited on: 2017-01-27 14:14) |
|
Test Case 3 - Process Price Difference Adjustment process (One organization)
As F&B International Group Admin
- Go to Product window
- Create new Product for "España" organization. Define Price for "Bebidas Alegres"= 5 and "Tarifa de ventas"= 7
- Go to Purchase Order window
- Register Purchase Order for "España norte" organization and "Bebidas alegres" business partner.
- Add line for previous product and qty=10. Process it
- Go to Goods Receipt window and register Goods Receipt for "España norte" organization and "Bebidas alegres" business partner.
- Run "create lines from" process, select previous order and process it
- Go to Process Request window
- Run Costing Background process and verify that cost for this transaction is calculated to 50.00
- Go to Goods Shipment and register Goods Shipment for "España norte" organization and "Alimentos y Supermercados" business partner.
- Add line for previous product and qty=2. Process shipment
- Go to Process Request window
- Run Costing Background process and verify that cost is calculated to 10
- Go to Purchase Invoice window and register Purchase Invoice for "España norte" organization and "Bebidas alegres" business partner.
- Run "create lines from" process, select previous receipt.
- Edit invoice line to set price=7 and complete
- Run "Process Price Difference Adjustment" process for "España norte" organization, today's date and previous product
- Go to Cost Adjustment window
- Verify that a cost adjustment has been created for "F&B España, S.A" organization (Header).
- Verify in Lines tab that two records have been created with below information:
* Source one V+ for an adjutsment amount = 20.00 (70-50)
* No Source one C- for an adjustment amount = 4.00 (14-10)
Organization field can not be shown.
Make sure that the product created has the ledger account "Invoice Price Difference" setup for the corresponding General Ledgers in the "Accounting" tab.
- Post cost adjustment lines.
- Verify cost adjustment transaction is post to both F&B España Euro and F&B International Group US general ledger configurations.
- Go to Accounting tab and verify that the Organization shown is "F&B España - Region Norte".
|
|
|
(0093895)
|
psanjuan
|
2017-01-27 14:07
(edited on: 2017-01-27 14:44) |
|
Test Case 4 - Price Correction Background process (one organizations).
As F&B International Group Admin
- Go to Process Request window and create a new record with below setup:
Client = F&B International Group
Organization = *
Timing = Run inmediatly
Process = Price Correction Background.
- Go to Product window
- Create new Product for "*" organization. Define Price for "Bebidas Alegres"= 5 and "Tarifa de ventas"= 7
- Go to Purchase Order window
- Register Purchase Order for "España norte" organization and "Bebidas alegres" business partner, dated on 13-01-2017
- Add line for previous product and qty=10. Process it
- Go to Goods Receipt window and register Goods Receipt for "España norte" organization and "Bebidas alegres" business partner, dated on 13-01-2017
- Run "create lines from" process, select previous order and process it
- Go to Process Request window
- Run Costing Background process and verify that cost for this transaction is calculated to 50.00
- Go to Goods Shipment and register Goods Shipment for "España norte" organization and "Alimentos y Supermercados" business partner, dated on 19-01-2017.
- Add line for previous product and qty=2. Process shipment
- Go to Process Request window
- Run Costing Background process and verify that cost is calculated to 10
- Go to Purchase Invoice window and register Purchase Invoice for "España norte" organization and "Bebidas alegres" business partner, dated on 19-01-2017.
- Run "create lines from" process, select previous receipt.
- Edit invoice line to set price=7 and complete
- Go to process request window and run price correction process.
- Go to Cost Adjustment window
- Verify that cost adjustment has been created for "F&B España, S.A" organization
- Verify in Lines tab that two records have been created:
* Source one V+ for an adjutsment amount = 20.00 (70-50)
* No Source one C- for an adjustment amount = 4.00 (14-10)
- Post cost adjustment.
- Verify cost adjustment transaction is post to both F&B España Euro and F&B International Group US general ledger configurations.
Go to Accounting tab and verify that only F&B España Region Norte org is shown.
Test Case 5 - Price Correction Background process (diffferent organizations).
Use same product as the one used in test case 4.
Go to Purchase Order window
- Register Purchase Order for "España Sur" organization and "Bebidas alegres" business partner, dated on 05-01-2017
- Add line for previous product and qty=10. Process it
- Go to Goods Receipt window and register Goods Receipt for "España sur" organization and "Bebidas alegres" business partner, dated on 05-01-2017
- Run "create lines from" process, select previous order and process it
- Go to Process Request window
- Run Costing Background process and verify that cost for this transaction is calculated to 50.00
- Go to Purchase Invoice window and create a new one for F&B España Region Sur dated on 05-01-2017, select previous receipt.
- Edit the line and change the price to 8. Complete and Post the invoice.
- Go to Process Request window and run price correction process.
Go to Cost Adjustment window and verify there are two new adjustments, both of them created for F&B España.
First one is a backdated adjustment related to Goods Receipt dated on 05-01-2017 for Region Sur, as source adjustment, no posting required, amount adj = 0.00; and Customer Shipment for Region Norte dated on 19-01-2017, posting required.
Post it.
Go to Accounting tab and verify that only Region Norte is shown in there.
Go to the second adjustment that is a price difference correction adjustment.
Verify it has two lines:
line 10 - vendor receipt dated on 05-01-2017 (Region Sur) for an amount = 30. Posting required.
Line 20 - customer shipment dated on 19-01-2017 - (Region Norte ) for an amount = 3.00 Posting required.
Post it.
Go to Accounting tab and filter by F&B España Euro GL.
Verify that Region Norte org is shown for the adjustment of 3.00 (Customer Shipment), and Region Sur is shown for the adjustment of 30.00 (Vendor Receipt)
|
|
|
|
Test Plan above verified, issue can be code reviewed and closed.
|
|
|
(0093899)
|
hgbot
|
2017-01-27 14:57
|
|
Repository: erp/devel/pi
Changeset: 66c0ea64eed97dda72b11ee21778ea39ac5b6698
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Jan 26 11:23:05 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/66c0ea64eed97dda72b11ee21778ea39ac5b6698 [^]
Related to issue 35015: Code review improvements
As Cost Adjustment Header's organization already is saved with the "legal"
organization, is not needed search it again to set as org of it lines, when
them are created. So the Cost Adjustment Line's organization will be taken
from the header's organization.
Also, as the header and lines will have the same organization is not needed to
show this field in the lines. So, the Organization field in the Cost Adjustment
Line tab has been hidden again.
---
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/costing/CostAdjustmentUtils.java
---
|
|
|
|
|
|
|
|
|
(0093942)
|
hgbot
|
2017-01-30 17:54
|
|
Repository: erp/devel/pi
Changeset: 3a37d8d398c83eb721321807fe9682d943cda884
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Jan 30 11:50:29 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/3a37d8d398c83eb721321807fe9682d943cda884 [^]
Related to issue 35015: Code review improvements
Removed validation on the legal organization, as it always will be bot null
---
M src/org/openbravo/costing/CostAdjustmentUtils.java
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|