Openbravo Issue Tracking System - Retail Modules | ||||||||||||
View Issue Details | ||||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | |||||||
0034999 | Retail Modules | StoreServer | public | 2017-01-18 15:43 | 2017-01-30 09:20 | |||||||
Reporter | mtaal | |||||||||||
Assigned To | mtaal | |||||||||||
Priority | normal | Severity | major | Reproducibility | have not tried | |||||||
Status | closed | Resolution | fixed | |||||||||
Platform | OS | 5 | OS Version | |||||||||
Product Version | ||||||||||||
Target Version | RR17Q2 | Fixed in Version | ||||||||||
Merge Request Status | ||||||||||||
Review Assigned To | AugustoMauch | |||||||||||
OBNetwork customer | ||||||||||||
Support ticket | ||||||||||||
Regression level | ||||||||||||
Regression date | ||||||||||||
Regression introduced in release | ||||||||||||
Regression introduced by commit | ||||||||||||
Triggers an Emergency Pack | No | |||||||||||
Summary | 0034999: Do more caching and re-organize code in MobileServerProvider in the Replication Module | |||||||||||
Description | The MobileServerProvider class [1] provides the mobile servers and node-ids by client and organization to the symmetric ds routers. This class can be improved in several ways: - the synchronized block is not completely correct as the global member is set in the beginning of the initialization method [2], thereby defeating the check done in other code to determine if initialization needs to happen [3]. - node ids by client and organization can also be cached [4] and [5] The code can be re-organized also to not call the original getters from the initialization code. [1] https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/963ec1086228/src/org/openbravo/replication/symmetricds/util/MobileServerProvider.java [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/963ec1086228/src/org/openbravo/replication/symmetricds/util/MobileServerProvider.java#l101 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/963ec1086228/src/org/openbravo/replication/symmetricds/util/MobileServerProvider.java#l81 [^] [4] https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/963ec1086228/src/org/openbravo/replication/symmetricds/util/MobileServerProvider.java#l93 [^] [5] https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/963ec1086228/src/org/openbravo/replication/symmetricds/util/MobileServerProvider.java#l177 [^] | |||||||||||
Steps To Reproduce | See the current implementation of the MobileServerProvider | |||||||||||
Proposed Solution | See the description | |||||||||||
Additional Information | ||||||||||||
Tags | No tags attached. | |||||||||||
Relationships |
| |||||||||||
Attached Files | ||||||||||||
Issue History | ||||||||||||
Date Modified | Username | Field | Change | |||||||||
2017-01-18 15:43 | mtaal | New Issue | ||||||||||
2017-01-18 15:43 | mtaal | Assigned To | => mtaal | |||||||||
2017-01-18 15:43 | mtaal | Triggers an Emergency Pack | => No | |||||||||
2017-01-18 15:47 | mtaal | Review Assigned To | => AugustoMauch | |||||||||
2017-01-18 16:22 | hgbot | Checkin | ||||||||||
2017-01-18 16:22 | hgbot | Note Added: 0093701 | ||||||||||
2017-01-18 16:22 | hgbot | Status | new => resolved | |||||||||
2017-01-18 16:22 | hgbot | Resolution | open => fixed | |||||||||
2017-01-18 16:22 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/f9af11aa6a4c90c3edc9cde15e8485850725dd87 [^] | |||||||||
2017-01-30 09:20 | AugustoMauch | Note Added: 0093913 | ||||||||||
2017-01-30 09:20 | AugustoMauch | Status | resolved => closed | |||||||||
2017-02-07 17:53 | AugustoMauch | Relationship added | has duplicate 0033409 |
Notes | |||||
|
|||||
|
|
||||
|
|||||
|
|