Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0034994Openbravo ERPA. Platformpublic2017-01-18 12:552017-03-15 20:18
inigosanchez 
inigosanchez 
normalmajorhave not tried
closedfixed 
5
 
3.0PR17Q2 
alostale
Core
Pre packaging ( pi )
2016-12-20
pi
https://code.openbravo.com/erp/devel/pi/rev/33acb5a389843bb26358ea747e92383505608b56 [^]
No
0034994: All platform buildvalidations should be reviewed
All platform buildvalidations should be reviewed in order to check if they have to be updated their execution limits. The problems found are:
- CheckUpdateConnectionPoolMerge: Execution limit should be defined between [null, 3.0.27659].
- DatabaseDecimalNumberCheck: Should't have any execution limit because it should be executed allways.
- DatabaseVersionCheck: Should't have any execution limit because it should be executed allways.
- DuplicatedJavaPackage: Limit is defined properly.
- JdkVersionCheck: Should't have any execution limit because it should be executed allways.
- PreferenceConflict: Limit is defined properly.
- RemoveCostingRuleProcessExecutions: Execution limit should be defined between [null, 3.0.25161].
-
See spreadsheet for more information: https://docs.google.com/a/openbravo.com/spreadsheets/d/1oEnWQy1-wrOREHxDy1b3Ar5jL9v4cVZ-TEI1IQiRZik/edit?usp=sharing [^]
No tags attached.
related to feature request 0030515 closed inigosanchez Add ability to determine if build validations should be executed depending on a particular module version 
depends on backport 00349983.0PR17Q1 closed inigosanchez All platform buildvalidations should be reviewed 
caused by defect 0034718 closed Sanjota Review buildvalidation performance 
Issue History
2017-01-18 12:55inigosanchezNew Issue
2017-01-18 12:55inigosanchezAssigned To => inigosanchez
2017-01-18 12:55inigosanchezModules => Core
2017-01-18 12:55inigosanchezTriggers an Emergency Pack => No
2017-01-18 13:00inigosanchezRegression date => 2016-12-20
2017-01-18 13:00inigosanchezRegression introduced in release => pi
2017-01-18 13:00inigosanchezRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/33acb5a389843bb26358ea747e92383505608b56 [^]
2017-01-18 13:02inigosanchezRelationship addedcaused by 0034718
2017-01-18 13:03inigosanchezRelationship addedrelated to 0030515
2017-01-18 13:08inigosanchezRegression level => Pre packaging ( pi )
2017-01-18 14:44inigosanchezDescription Updatedbug_revision_view_page.php?rev_id=14324#r14324
2017-01-18 14:45inigosanchezDescription Updatedbug_revision_view_page.php?rev_id=14325#r14325
2017-01-18 15:31inigosanchezStatusnew => scheduled
2017-01-18 16:49hgbotCheckin
2017-01-18 16:49hgbotNote Added: 0093703
2017-01-18 16:49hgbotStatusscheduled => resolved
2017-01-18 16:49hgbotResolutionopen => fixed
2017-01-18 16:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/337b0d3cd176d044c6473522e924c5bc463739f5 [^]
2017-01-18 16:50inigosanchezReview Assigned To => alostale
2017-01-20 08:12alostaleNote Added: 0093743
2017-01-20 08:12alostaleStatusresolved => closed
2017-01-20 08:12alostaleFixed in Version => 3.0PR17Q2
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095108

Notes
(0093703)
hgbot   
2017-01-18 16:49   
Repository: erp/devel/pi
Changeset: 337b0d3cd176d044c6473522e924c5bc463739f5
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Jan 18 15:50:27 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/337b0d3cd176d044c6473522e924c5bc463739f5 [^]

Fixed issue 34994: Limits of buildvalidations haven't defined properly.

Some of the execution limits of platform buildvalidations haven't defined properly. Now the problem have
been resolved by updating the following buildvalidations:

- CheckUpdateConnectionPoolMerge: Execution limit should be defined between [null, 3.0.27659].
- DatabaseDecimalNumberCheck: Should't have any execution limit because it should be executed allways.
- DatabaseVersionCheck: Should't have any execution limit because it should be executed allways.
- JdkVersionCheck: Should't have any execution limit because it should be executed allways.
- RemoveCostingRuleProcessExecutions: Execution limit should be defined between [null, 3.0.25161].

---
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/CheckUpdateConnectionPoolMerge.class
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DatabaseDecimalNumberCheck.class
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DatabaseVersionCheck.class
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/JdkVersionCheck.class
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/RemoveCostingRuleProcessExecutions.class
M src-util/buildvalidation/src/org/openbravo/buildvalidation/CheckUpdateConnectionPoolMerge.java
M src-util/buildvalidation/src/org/openbravo/buildvalidation/DatabaseDecimalNumberCheck.java
M src-util/buildvalidation/src/org/openbravo/buildvalidation/DatabaseVersionCheck.java
M src-util/buildvalidation/src/org/openbravo/buildvalidation/JdkVersionCheck.java
M src-util/buildvalidation/src/org/openbravo/buildvalidation/RemoveCostingRuleProcessExecutions.java
---
(0093743)
alostale   
2017-01-20 08:12   
reviewed
(0095108)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test