Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034989Openbravo ERPA. Platformpublic2017-01-18 10:552017-03-15 20:18
ReporterioritzCia 
Assigned Toalostale 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerOBPS
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034989: When login, the Openbravo.properties file is opened too often
DescriptionSee the log file attached and search for the following error:
Error reading properties
java.io.FileNotFoundException: /opt/OpenbravoERP/openbravo/config/Openbravo.properties (Trop de fichiers ouverts)

The file is opened too often, you can list the time the file has been opened with:

lsof -p <pid> (in our case java/tomcat pid)
lsof <file>

The code that opens the file is in src/org/openbravo/base/secureApp/UserLock.java file in UserLock constructor at the beginning
Steps To ReproduceLaunch several webservices in parallel
We can provide tools to do it
Proposed Solution
Additional Information
TagsPerformance
Relationships
Attached Fileslog openbravo.log (3,735,552) 2017-01-18 10:56
https://issues.openbravo.com/file_download.php?file_id=10321&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-01-18 10:55ioritzCiaNew Issue
2017-01-18 10:55ioritzCiaAssigned To => platform
2017-01-18 10:55ioritzCiaOBNetwork customer => Yes
2017-01-18 10:55ioritzCiaWeb browser => Google Chrome
2017-01-18 10:55ioritzCiaModules => Core
2017-01-18 10:55ioritzCiaResolution time => 1487113200
2017-01-18 10:55ioritzCiaTriggers an Emergency Pack => No
2017-01-18 10:56ioritzCiaFile Added: openbravo.log
2017-01-18 10:58ioritzCiaWeb browserGoogle Chrome => Google Chrome
2017-01-18 10:58ioritzCiaDescription Updatedbug_revision_view_page.php?rev_id=14315#r14315
2017-01-18 13:04alostaleTag Attached: Performance
2017-01-18 13:05alostaleAssigned Toplatform => alostale
2017-01-18 13:05alostaleReview Assigned To => caristu
2017-01-18 13:05alostaleWeb browserGoogle Chrome => Google Chrome
2017-01-18 13:10hgbotCheckin
2017-01-18 13:10hgbotNote Added: 0093691
2017-01-18 13:10hgbotStatusnew => resolved
2017-01-18 13:10hgbotResolutionopen => fixed
2017-01-18 13:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a95f58378760062ea202eb077eb2112ce431edc3 [^]
2017-01-27 10:19caristuNote Added: 0093869
2017-01-27 10:19caristuStatusresolved => closed
2017-01-27 10:19caristuFixed in Version => 3.0PR17Q2
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095106

Notes
(0093691)
hgbot   
2017-01-18 13:10   
Repository: erp/devel/pi
Changeset: a95f58378760062ea202eb077eb2112ce431edc3
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jan 18 13:08:14 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a95f58378760062ea202eb077eb2112ce431edc3 [^]

fixed bug 34989: When login, the Openbravo.properties file is opened too often

  User locking mechanism was reading coonfiguration from Openbravo.properties in
  source path instead of using the standard cached properties. This caused unneeded
  overhead on loging.

  It has been fixed by:
   - Use the standard cached Openbravo.properties to retrieve this configuration
   - Read this config only once and set it in static fields
   - Some checks are now only done in case this feature is configured

---
M src/org/openbravo/base/secureApp/UserLock.java
---
(0093869)
caristu   
2017-01-27 10:19   
Code reviewed.
(0095106)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test