Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034965Retail ModulesWeb POSpublic2017-01-16 12:402017-01-19 11:18
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034965: OB-Dal query caching is not properly handled in some external modules
DescriptionSeveral external modules use the findUsingCache functionality, which allows to cache results of frequently used queries to improve performance.

However, they are using this feature improperly, because they are not specifying the "modelsAffectedByCache" property. This means that the cache is not cleared if incremental masterdata is executed, which may lead to wrong behavior. This property should therefore be added to those findUsingCache calls.


The affected modules are:
- org.openbravo.retail.activediscountspopup. File: active-discounts-hook.js
- org.openbravo.retail.discount.twofamiliescombo. File: twofamilies-rule-impl.js
- org.openbravo.retail.discounts.combo: File: combo-rule-impl.js
- org.openbravo.retail.discounts.scaledprice. File: scaledprice.js
Steps To ReproduceFor example, in the Two Family discount combo module:
- Define a two family combo
- Log in the Web POS. Realize that the combo is there. Do a ticket with this combo.
- Go to the backend, and change the combo definition.
- Let incremental refresh be executed automatically (not through F5)
- The new combo should now be in the Web POS. However, if a new ticket is done, the combo definition used is still the previous one.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034846pi closed jorge-garcia Scanning could not work if the model has change but cache is not deleted 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-01-16 12:40marvintmNew Issue
2017-01-16 12:40marvintmAssigned To => Retail
2017-01-16 12:40marvintmTriggers an Emergency Pack => No
2017-01-16 12:42marvintmDescription Updatedbug_revision_view_page.php?rev_id=14281#r14281
2017-01-16 12:42marvintmRelationship addedrelated to 0034846
2017-01-18 11:41ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-01-18 11:41ranjith_qualiantech_comStatusnew => scheduled
2017-01-18 13:07hgbotCheckin
2017-01-18 13:07hgbotNote Added: 0093685
2017-01-18 13:07hgbotCheckin
2017-01-18 13:07hgbotNote Added: 0093686
2017-01-18 13:07hgbotCheckin
2017-01-18 13:07hgbotNote Added: 0093687
2017-01-18 13:07hgbotCheckin
2017-01-18 13:07hgbotNote Added: 0093688
2017-01-19 09:44ranjith_qualiantech_comStatusscheduled => resolved
2017-01-19 09:44ranjith_qualiantech_comResolutionopen => fixed
2017-01-19 11:17marvintmReview Assigned To => marvintm
2017-01-19 11:17marvintmStatusresolved => closed

Notes
(0093685)
hgbot   
2017-01-18 13:07   
Repository: erp/pmods/org.openbravo.retail.activediscountspopup
Changeset: e9c4b2fc4530cae0a2b9e7c159d41bd28363d4ab
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 18 17:36:38 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.activediscountspopup/rev/e9c4b2fc4530cae0a2b9e7c159d41bd28363d4ab [^]

Related to issue 34965 : Added logic to manage find models using cache

---
M web/org.openbravo.retail.activediscountspopup/js/active-discounts-hook.js
---
(0093686)
hgbot   
2017-01-18 13:07   
Repository: erp/pmods/org.openbravo.retail.activediscountspopup
Changeset: e9c4b2fc4530cae0a2b9e7c159d41bd28363d4ab
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 18 17:36:38 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.activediscountspopup/rev/e9c4b2fc4530cae0a2b9e7c159d41bd28363d4ab [^]

Related to issue 34965 : Added logic to manage find models using cache

---
M web/org.openbravo.retail.activediscountspopup/js/active-discounts-hook.js
---
(0093687)
hgbot   
2017-01-18 13:07   
Repository: erp/pmods/org.openbravo.retail.discounts.scaledprice
Changeset: a9b1fc89c88b5d78e9c76d3bb81815cb038bdd37
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 18 17:36:31 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.scaledprice/rev/a9b1fc89c88b5d78e9c76d3bb81815cb038bdd37 [^]

Related to issue 34965 : Added logic to manage find models using cache

---
M web/org.openbravo.retail.discounts.scaledprice/js/scaledprice.js
---
(0093688)
hgbot   
2017-01-18 13:07   
Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: 65dec8d2dd29a204ad6c5ec21954f884831193b3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 18 17:33:49 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/65dec8d2dd29a204ad6c5ec21954f884831193b3 [^]

Related to issue 34965 : Added logic to manage find models using cache

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---