0034940: can't select product in Return from Customer > Insert Orphan Line

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0034940

Openbravo ERP

07. Sales management

public

2017-01-13 09:33

2017-01-17 13:45

Reporter

alostale

Assigned To

alostale

Priority

immediate

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0PR16Q4.1

Fixed in Version

3.0PR16Q4.1

Merge Request Status

Review Assigned To

vmromanos

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Production - QA Approved

Regression date

2016-08-29

Regression introduced in release

3.0PR16Q4

Regression introduced by commit

https://code.openbravo.com/erp/devel/pi/rev/e3d66eaa40b5 [^]

Triggers an Emergency Pack

Summary

0034940: can't select product in Return from Customer > Insert Orphan Line

Description

When trying to insert an orphan line in a return from customer, it is not possible to select the product: the selector is not displayed.

This is caused by a JS error which prevents the flow to continue:

  Uncaught TypeError: Cannot read property 'register' of undefined

  in file cancelAndReplace.js, line:

  OB.EventHandlerRegistry.register(OB.CancelAndReplace.SALES_ORDERLINES_TAB, OB.EventHandlerRegistry.PREDELETE, OB.CancelAndReplace.ClientSideEventHandlersPreDelete.showMessage, 'OBCancelAndReplace_ShowMessage');

The problem is caused because cancelAndReplace.js is loaded within js static resources for classic windows, but the infrastructure it relies on (OB.EventHandlerRegistry) is not causing to fail when tried to be loaded in classic mode.

Steps To Reproduce

1. Create a preference 'RM Allow Orphan Line' with value 'Y'
2. Log in again
3. Create a new record in Return from Customer window
4. Click on Insert Orphan line
  -> ERROR:
      * realize it's not possible to select a product as the product selector is not available.
      * JS error can be seen in console

Proposed Solution

Cancel and Replace is not designed to work in classic mode, so its JS shouldn't be loaded in this case.

Additional Information