Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0034940Openbravo ERP07. Sales managementpublic2017-01-13 09:332017-01-17 13:45
immediateminorhave not tried
Production - QA Approved
3.0PR16Q4 [^]
0034940: can't select product in Return from Customer > Insert Orphan Line
When trying to insert an orphan line in a return from customer, it is not possible to select the product: the selector is not displayed.

This is caused by a JS error which prevents the flow to continue:
  Uncaught TypeError: Cannot read property 'register' of undefined

  in file cancelAndReplace.js, line:

  OB.EventHandlerRegistry.register(OB.CancelAndReplace.SALES_ORDERLINES_TAB, OB.EventHandlerRegistry.PREDELETE, OB.CancelAndReplace.ClientSideEventHandlersPreDelete.showMessage, 'OBCancelAndReplace_ShowMessage');

The problem is caused because cancelAndReplace.js is loaded within js static resources for classic windows, but the infrastructure it relies on (OB.EventHandlerRegistry) is not causing to fail when tried to be loaded in classic mode.
1. Create a preference 'RM Allow Orphan Line' with value 'Y'
2. Log in again
3. Create a new record in Return from Customer window
4. Click on Insert Orphan line
  -> ERROR:
      * realize it's not possible to select a product as the product selector is not available.
      * JS error can be seen in console
Cancel and Replace is not designed to work in classic mode, so its JS shouldn't be loaded in this case.
No tags attached.
blocks defect 0034938 closed alostale can't select product in Return from Customer > Insert Orphan Line 
Issue History
2017-01-13 09:47alostaleTypedefect => backport
2017-01-13 09:47alostaleTarget Version => 3.0PR16Q4.1
2017-01-13 09:49alostaleAssigned Toalostale => Triage Finance
2017-01-13 09:49alostaleStatusscheduled => feedback
2017-01-13 09:50alostaleStatusfeedback => new
2017-01-17 13:33vmromanosStatusnew => scheduled
2017-01-17 13:33vmromanosAssigned ToTriage Finance => alostale
2017-01-17 13:39hgbotCheckin
2017-01-17 13:39hgbotNote Added: 0093633
2017-01-17 13:39hgbotStatusscheduled => resolved
2017-01-17 13:39hgbotResolutionopen => fixed
2017-01-17 13:39hgbotFixed in SCM revision => [^]
2017-01-17 13:45vmromanosNote Added: 0093635
2017-01-17 13:45vmromanosStatusresolved => closed
2017-01-17 13:45vmromanosFixed in Version => 3.0PR16Q4.1

2017-01-17 13:39   
Repository: erp/backports/3.0PR16Q4.1
Changeset: afb941dffaf8adc83579364324f9eb9b0145886d
Author: Asier Lostalé <asier.lostale <at>>
Date: Fri Jan 13 10:03:39 2017 +0100
URL: [^]

Fixed bug 34940: 3.0 selectors cannot be used in classic mode

  When a 3.0 selector was included within classic mode, the JS failed to load.

  The problem was cancelAndReplace.js was included within classic mode JS but it
  depends on resources not available in this mode.

  Because cancel and replace is not designed to work in classic mode, its JS is
  now not included in this mode.

M modules/org.openbravo.client.application/src/org/openbravo/client/application/
2017-01-17 13:45   
Code review + testing OK.
Verified Cancel and Replace keeps on working fine.