Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034938Openbravo ERP07. Sales managementpublic2017-01-13 09:332017-01-17 13:45
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2016-08-29
Regression introduced in release3.0PR16Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/e3d66eaa40b5 [^]
Triggers an Emergency PackNo
Summary0034938: can't select product in Return from Customer > Insert Orphan Line
DescriptionWhen trying to insert an orphan line in a return from customer, it is not possible to select the product: the selector is not displayed.

This is caused by a JS error which prevents the flow to continue:
  
  Uncaught TypeError: Cannot read property 'register' of undefined

  in file cancelAndReplace.js, line:

  OB.EventHandlerRegistry.register(OB.CancelAndReplace.SALES_ORDERLINES_TAB, OB.EventHandlerRegistry.PREDELETE, OB.CancelAndReplace.ClientSideEventHandlersPreDelete.showMessage, 'OBCancelAndReplace_ShowMessage');


The problem is caused because cancelAndReplace.js is loaded within js static resources for classic windows, but the infrastructure it relies on (OB.EventHandlerRegistry) is not causing to fail when tried to be loaded in classic mode.
Steps To Reproduce1. Create a preference 'RM Allow Orphan Line' with value 'Y'
2. Log in again
3. Create a new record in Return from Customer window
4. Click on Insert Orphan line
  -> ERROR:
      * realize it's not possible to select a product as the product selector is not available.
      * JS error can be seen in console
Proposed SolutionCancel and Replace is not designed to work in classic mode, so its JS shouldn't be loaded in this case.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00349393.0PR17Q1 closed alostale can't select product in Return from Customer > Insert Orphan Line 
depends on backport 00349403.0PR16Q4.1 closed alostale can't select product in Return from Customer > Insert Orphan Line 
caused by feature request 00349373.0PR16Q4 closed Triage Omni OMS Cancel & Replace functionality 
blocks defect 0034797 closed alostale Insert Orphan line preference allows to insert products without having into account organization. 
Attached Filespng Selection_145.png (47,750) 2017-01-13 09:38
https://issues.openbravo.com/file_download.php?file_id=10293&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-01-13 09:33alostaleNew Issue
2017-01-13 09:33alostaleAssigned To => Triage Finance
2017-01-13 09:33alostaleModules => Core
2017-01-13 09:33alostaleTriggers an Emergency Pack => No
2017-01-13 09:38alostaleFile Added: Selection_145.png
2017-01-13 09:42alostaleDescription Updatedbug_revision_view_page.php?rev_id=14261#r14261
2017-01-13 09:42alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14263#r14263
2017-01-13 09:42alostaleProposed Solution updated
2017-01-13 09:45alostaleRegression level => Production - QA Approved
2017-01-13 09:45alostaleRegression date => 2016-08-29
2017-01-13 09:45alostaleRegression introduced in release => 3.0PR16Q4
2017-01-13 09:45alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/e3d66eaa40b5 [^]
2017-01-13 09:45alostalePrioritynormal => immediate
2017-01-13 09:45alostaleAssigned ToTriage Finance => alostale
2017-01-13 09:45alostaleReview Assigned To => vmromanos
2017-01-13 09:46alostaleRelationship addedcaused by 0034937
2017-01-13 09:46alostaleRelationship addedblocks 0034797
2017-01-13 09:47alostaleStatusnew => scheduled
2017-01-13 10:06alostaleNote Added: 0093473
2017-01-13 10:06alostaleStatusscheduled => resolved
2017-01-13 10:06alostaleFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6398d4e21157f2e64580a955ed56368ea5af1e50 [^]
2017-01-13 10:06alostaleResolutionopen => fixed
2017-01-13 10:27alostaleNote Added: 0093474
2017-01-17 13:45vmromanosNote Added: 0093637
2017-01-17 13:45vmromanosStatusresolved => closed
2017-01-17 13:45vmromanosFixed in Version => 3.0PR17Q2

Notes
(0093473)
alostale   
2017-01-13 10:06   
Incorrect issue number in commit message:

Repository: erp/devel/pi
Changeset: 6398d4e21157f2e64580a955ed56368ea5af1e50
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jan 13 10:03:39 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6398d4e21157f2e64580a955ed56368ea5af1e50 [^] [^]

fixed bug 34939: 3.0 selectors cannot be used in classic mode

  When a 3.0 selector was included within classic mode, the JS failed to load.

  The problem was cancelAndReplace.js was included within classic mode JS but it
  depends on resources not available in this mode.

  Because cancel and replace is not designed to work in classic mode, its JS is
  now not included in this mode.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java
---
(0093474)
alostale   
2017-01-13 10:27   
Added test case to TestLink: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10520 [^]
(0093637)
vmromanos   
2017-01-17 13:45   
Code review + testing OK.
Verified Cancel and Replace keeps on working fine.