Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034903Openbravo ERPA. Platformpublic2017-01-11 07:322022-02-01 08:09
Reportertayyab217 
Assigned ToTriage Platform Base 
PrioritynormalSeveritytrivialReproducibilityalways
StatusacknowledgedResolutionopen 
PlatformOS30OS VersionUbuntu 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034903: Menu - 'Export to Spreedsheet' on window should export thedata with filename = Windowname_Tabame.csv
DescriptionNeed meaningful name while exporting data from Window tabs.

Currently its exporting the data with "ExportedData.csv" filename.

It should show at-least Windowname_tabname.csv as filename.

Steps To ReproduceGo to Window:Sales Order, Tab:Header
Click on Button:Export to Spreadsheet

System will generate file with "Exporteddata.csv"
Proposed Solution1. Show Windowname_tabname.csv as filename.

2. Show Windowname_tabname_currentdate&time.csv as filename.

Diff file attached for reference
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff export_naming.diff (1,615) 2017-01-11 07:32
https://issues.openbravo.com/file_download.php?file_id=10279&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-01-11 07:32tayyab217New Issue
2017-01-11 07:32tayyab217Assigned To => platform
2017-01-11 07:32tayyab217File Added: export_naming.diff
2017-01-11 07:32tayyab217Modules => Core
2017-01-11 07:32tayyab217Triggers an Emergency Pack => No
2017-01-20 09:07alostaleNote Added: 0093752
2017-01-20 09:07alostaleAssigned Toplatform => dbaz
2017-01-20 09:07alostaleStatusnew => feedback
2017-01-22 17:55dbazNote Added: 0093761
2017-01-22 17:56dbazAssigned Todbaz => platform
2017-01-22 17:56dbazStatusfeedback => new
2017-01-23 11:44alostaleOBNetwork customer => No
2017-01-23 11:44alostaleNote Added: 0093769
2017-01-23 11:44alostaleStatusnew => acknowledged
2017-01-23 11:44alostaleTypedefect => design defect
2022-02-01 08:09alostaleAssigned Toplatform => Triage Platform Base

Notes
(0093752)
alostale   
2017-01-20 09:07   
DBA, would you, from UX point of view, do this change?

If so, which is the format it should have?

Should the name be in the base language window/tab is defined in AD, or in current session's one.

On top of that, some additional checks must be done in order to generate a valid header (ie. escape remove double quotes in names, what about other non standard characters?).
(0093761)
dbaz   
2017-01-22 17:55   
The change makes sense. The current csv export filename doesn't provide any information.

Related to the file name, I would go to something like:
* First level export: WindowName
* Second level export: WindowName_ChildName
* Third level export: WindowName_ChildName_GrandChildName
...

So, in case of exporting "Window:Sales Order, Tab:Header", the name would be "SalesOrder" and not "SalesOrder_Header". This is because the first level tab name is not shown even in the main tab title, so include it in the name could lead to confusion. With this same example, if we move to the lines, the name would be "SalerOrder_Lines"

Including the datetime in the file name could be ok too, because it is already included in some printing documents (fex: Sales Order) in a format like '20170122-174248'.

Since the headers of the exported content is in the language in which is visualized in the interface, I would do the same for the file name.

The filename name and length should be ok for all the supported OS: https://en.wikipedia.org/wiki/Filename#Reserved_characters_and_words [^]
(0093769)
alostale   
2017-01-23 11:44   
Moving to design defect: provided patch cannot be directly applied as it still requires of some re-working.