Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034874Openbravo ERPI. Performancepublic2017-01-09 17:452017-03-15 20:18
ReporterSandrahuguet 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tomarkmm82
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034874: it is necessary to add an index in fin_payment.fin_rev_payment_id to improve the performance
DescriptionIt is necessary to add an index in fin_payment.fin_rev_payment_id to improve the performance when use

payment.getFINPaymentReversedPaymentList();
Steps To ReproduceN/A
Proposed SolutionCREATE INDEX reversepayment
  ON public.fin_payment
  USING btree
  (fin_payment_id COLLATE pg_catalog."default");
Additional Information
TagsPerformance
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-01-09 17:45SandrahuguetNew Issue
2017-01-09 17:45SandrahuguetAssigned To => Triage Finance
2017-01-09 17:45SandrahuguetModules => Core
2017-01-09 17:45SandrahuguetTriggers an Emergency Pack => No
2017-01-09 17:48vmromanosNote Added: 0093274
2017-01-09 18:50markmm82Assigned ToTriage Finance => collazoandy4
2017-01-10 17:46collazoandy4Statusnew => scheduled
2017-01-11 16:51SandrahuguetTag Attached: Performance
2017-01-16 19:53hgbotCheckin
2017-01-16 19:53hgbotNote Added: 0093612
2017-01-16 19:53hgbotStatusscheduled => resolved
2017-01-16 19:53hgbotResolutionopen => fixed
2017-01-16 19:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a09d6ae570dde223583290eb2e911c9640e97658 [^]
2017-01-16 19:58markmm82Review Assigned To => markmm82
2017-01-16 19:58markmm82Note Added: 0093613
2017-01-16 19:58markmm82Statusresolved => closed
2017-01-16 19:58markmm82Fixed in Version => 3.0PR17Q2
2017-01-17 13:50vmromanosNote Added: 0093638
2017-01-17 13:50vmromanosStatusclosed => new
2017-01-17 13:50vmromanosResolutionfixed => open
2017-01-17 13:50vmromanosFixed in Version3.0PR17Q2 =>
2017-01-17 15:10SandrahuguetProposed Solution updated
2017-01-17 16:06hgbotCheckin
2017-01-17 16:06hgbotNote Added: 0093648
2017-01-18 11:01lorenzofidalgoIssue Monitored: lorenzofidalgo
2017-01-18 15:40hgbotCheckin
2017-01-18 15:40hgbotNote Added: 0093694
2017-01-18 15:40hgbotStatusnew => resolved
2017-01-18 15:40hgbotResolutionopen => fixed
2017-01-18 15:40hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/a09d6ae570dde223583290eb2e911c9640e97658 [^] => http://code.openbravo.com/erp/devel/pi/rev/82d9f1cfdafdd5f6e3fb7542241bfff49c15554b [^]
2017-01-18 21:21markmm82Note Added: 0093713
2017-01-18 21:21markmm82Statusresolved => closed
2017-01-18 21:21markmm82Fixed in Version => 3.0PR17Q2
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095102
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095104
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095107

Notes
(0093274)
vmromanos   
2017-01-09 17:48   
Create a partial index on this column. See documentation: http://wiki.openbravo.com/wiki/Constraints_and_Triggers#Not_Null_Partial_Indexes_On_Nullable_Columns [^]
(0093612)
hgbot   
2017-01-16 19:53   
Repository: erp/devel/pi
Changeset: a09d6ae570dde223583290eb2e911c9640e97658
Author: Andy <collazoandy4 <at> gmail.com>
Date: Fri Jan 13 12:25:24 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/a09d6ae570dde223583290eb2e911c9640e97658 [^]

Fixed issue 34874: Added an index in fin_payment.fin_rev_payment_id

Added an index in fin_payment.fin_rev_payment_id to improve the performance

---
M src-db/database/model/tables/FIN_PAYMENT.xml
---
(0093613)
markmm82   
2017-01-16 19:58   
Code review + Testing OK
(0093638)
vmromanos   
2017-01-17 13:50   
Reopened because that solution is wrong:

1. It is not a partial index as I clearly explained in the note https://issues.openbravo.com/view.php?id=34874#c93274 [^]
2. There is no need to create a multi-column index. Just one column (FIN_REV_PAYMENT_ID) would be enough
(0093648)
hgbot   
2017-01-17 16:06   
Repository: erp/devel/pi
Changeset: b7dc8dff230a0ec7c8dbf2e6a6ab113d516abbe9
Author: Mark <markmm82 <at> gmail.com>
Date: Tue Jan 17 10:05:09 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/b7dc8dff230a0ec7c8dbf2e6a6ab113d516abbe9 [^]

Related to issue 34874: Backed out changeset a09d6ae570dd

This patch contains an incorrect definition for the partial index, and there is no need to create a multi-column index. Just one column (FIN_REV_PAYMENT_ID) would be enough

---
M src-db/database/model/tables/FIN_PAYMENT.xml
---
(0093694)
hgbot   
2017-01-18 15:40   
Repository: erp/devel/pi
Changeset: 82d9f1cfdafdd5f6e3fb7542241bfff49c15554b
Author: Mark <markmm82 <at> gmail.com>
Date: Tue Jan 17 11:57:35 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/82d9f1cfdafdd5f6e3fb7542241bfff49c15554b [^]

Fixed issue 34874: Added an index in fin_payment.fin_rev_payment_id

Added an index in fin_payment.fin_rev_payment_id to improve the performance

---
M src-db/database/model/tables/FIN_PAYMENT.xml
---
(0093713)
markmm82   
2017-01-18 21:21   
Code review + Testing OK
(0095102)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095104)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095107)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test