Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034864Openbravo ERPA. Platformpublic2017-01-09 11:022017-03-15 20:18
Reporterumartirena 
Assigned ToNaroaIriarte 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in release3.0PR16Q2
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/afa165be3e5900d1114d33e5106114d0e089876a [^]
Triggers an Emergency PackNo
Summary0034864: Ordering in GL Item grid in Add Payment process definition does not work. It deletes the lines.
DescriptionOrdering in GL Item grid in Add Payment process definition does not work. It deletes the lines.
Steps To ReproduceIn live builds:
 * Go to "Payment In" window.
 * Create a new record.
 * Click on "Add Details" button.
 * In GL Items section click on "Add New".
 * Add a GL Item and save the record.
 * Sort by GL Item.
 * The previous record disappears.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00348913.0PR17Q1 closed NaroaIriarte Ordering in GL Item grid in Add Payment process definition does not work. It deletes the lines. 
depends on backport 00348923.0PR16Q4.1 closed NaroaIriarte Ordering in GL Item grid in Add Payment process definition does not work. It deletes the lines. 
depends on backport 00348933.0PR16Q3.4 closed NaroaIriarte Ordering in GL Item grid in Add Payment process definition does not work. It deletes the lines. 
caused by feature request 0031468 closed NaroaIriarte It would be nice to prevent sorting and filtering some columns. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-01-09 11:02umartirenaNew Issue
2017-01-09 11:02umartirenaAssigned To => platform
2017-01-09 11:02umartirenaModules => Core
2017-01-09 11:02umartirenaTriggers an Emergency Pack => No
2017-01-09 11:02umartirenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14220#r14220
2017-01-09 12:56NaroaIriarteAssigned Toplatform => NaroaIriarte
2017-01-09 13:04NaroaIriarteStatusnew => acknowledged
2017-01-09 15:40NaroaIriarteSeveritymajor => minor
2017-01-10 09:26NaroaIriarteReview Assigned To => alostale
2017-01-10 09:26NaroaIriarteRegression introduced in release => 3.0PR16Q2
2017-01-10 09:26NaroaIriarteRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/afa165be3e5900d1114d33e5106114d0e089876a [^]
2017-01-10 09:26NaroaIriartePrioritynormal => immediate
2017-01-10 09:26NaroaIriarteStatusacknowledged => scheduled
2017-01-10 09:26NaroaIriarteRelationship addedcaused by 0031468
2017-01-10 09:50NaroaIriarteRegression level => Production - Confirmed Stable
2017-01-10 12:52NaroaIriarteStatusscheduled => acknowledged
2017-01-10 12:56NaroaIriarteStatusacknowledged => scheduled
2017-01-11 16:07hgbotCheckin
2017-01-11 16:07hgbotNote Added: 0093366
2017-01-11 16:07hgbotStatusscheduled => resolved
2017-01-11 16:07hgbotResolutionopen => fixed
2017-01-11 16:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d1fba62ec6569659b96e367d70dc9d8caa437ff9 [^]
2017-01-13 12:55alostaleNote Added: 0093519
2017-01-13 12:55alostaleStatusresolved => closed
2017-01-13 12:55alostaleFixed in Version => 3.0PR17Q2
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095087

Notes
(0093366)
hgbot   
2017-01-11 16:07   
Repository: erp/devel/pi
Changeset: d1fba62ec6569659b96e367d70dc9d8caa437ff9
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Wed Jan 11 16:03:20 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d1fba62ec6569659b96e367d70dc9d8caa437ff9 [^]

Fixed issue 34864: The GL item section of add payment was not working fine

The grid of the G/L item section of the Add payment process was not workinf fine. The problem was that it was shown as sortable and as filterable and it must not be filterable nor sortable. This has been caused by the changeset[1]. This proyect set every column as sortable and as filterable and so was the problem.
To fix this the values of "canSort" and "canFilter" have been changed in the needed cases, which are the ones that satisfy the condition of having the canDelete property or the canAdd property set to yes and are in Pick and Execute window.
The code which handles the logic has been moved from the OBViewFieldHandler.getGridFieldProperties() to UIDefinition.getGridFieldProperties().

[1]http://code.openbravo.com/erp/devel/pi/rev/afa165be3e5900d1114d33e5106114d0e089876a [^]

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinition.java
---
(0093519)
alostale   
2017-01-13 12:55   
code reviewed

tested:
- It's not possible to filter nor sort in P&E grids that allow adding or removing records
- The rest of grids continue allowing filtering sorting by default
- It's possible to overwrite this behavior through grid configuration
(0095087)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test