Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034863Openbravo ERPA. Platformpublic2017-01-09 10:002017-03-15 20:18
Reporterumartirena 
Assigned Toinigosanchez 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034863: "Your password has expired" message while logging in is not properly translated to the language of the application
Description"Your password has expired" message while logging in is not properly translated to the language of the application. While executing the login and checking if the users password is expired or not (DefaultAuthenticationManager.java), the session variable of the language is empty so it always uses English by default.
Steps To ReproduceSetup an environment with any translation apart from English (French i.e. as the required message is properly translated there).

Logging as "Openbravo" in the backoffice.
Go to users window, find any user and set the password as "Expired".
Set default language of the system any language different to English(French).
Logout and Logging with the new user.
The following message appears in English when it should be in the other language. "Your password has expired. Please provide a new one"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0031796 closed jonibc Extend functionality with the option to define a day limit for the password to be changed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-01-09 10:00umartirenaNew Issue
2017-01-09 10:00umartirenaAssigned To => platform
2017-01-09 10:00umartirenaModules => Core
2017-01-09 10:00umartirenaTriggers an Emergency Pack => No
2017-01-09 10:01umartirenaResolution time => 1485126000
2017-01-09 12:15inigosanchezStatusnew => scheduled
2017-01-09 12:15inigosanchezAssigned Toplatform => inigosanchez
2017-01-09 12:59alostaleRelationship addedrelated to 0031796
2017-01-09 13:00alostaleTypedesign defect => defect
2017-01-09 16:15inigosanchezNote Added: 0093270
2017-01-09 17:19inigosanchezReview Assigned To => alostale
2017-01-09 17:22hgbotCheckin
2017-01-09 17:22hgbotNote Added: 0093272
2017-01-09 17:22hgbotStatusscheduled => resolved
2017-01-09 17:22hgbotResolutionopen => fixed
2017-01-09 17:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8f8221fada5b54564f985dc1fac546db818676a1 [^]
2017-01-13 12:41alostaleNote Added: 0093513
2017-01-13 12:41alostaleStatusresolved => closed
2017-01-13 12:41alostaleFixed in Version => 3.0PR17Q2
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095071

Notes
(0093270)
inigosanchez   
2017-01-09 16:15   
Testing issue with "Translation: Spanish-Spain (es_ES) español-España" module installed -> "Your password has expired" message should be translated properly.
(0093272)
hgbot   
2017-01-09 17:22   
Repository: erp/devel/pi
Changeset: 8f8221fada5b54564f985dc1fac546db818676a1
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Jan 09 13:29:01 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8f8221fada5b54564f985dc1fac546db818676a1 [^]

Fixed issue 34863: message while logging in is not properly translated

While executing the login and checking if the users password is expired or not (DefaultAuthenticationManager.java), the session variable of the language is empty so it always uses English language by default. For this reason 'CPExpirationPassword' message was not properly translated.

In order to reach an homogeneous behaviour related with translations it has been added language in LoginHandler class. Now the problem has been fixed and message is translated properly.

---
M src/org/openbravo/base/secureApp/LoginHandler.java
---
(0093513)
alostale   
2017-01-13 12:41   
code reviewed

tested

- Defining a non English lang at system level, it correctly shows login page in that language as well as expired password message
- it's possible to correctly change session language
(0095071)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test