0034862: Disable trigger sql statement gives error in oracle

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0034862

Retail Modules

StoreServer

public

2017-01-08 09:09

2017-01-08 10:19

Reporter

mtaal

Assigned To

mtaal

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

invalid

Platform

OS Version

Product Version

Target Version

RR17Q1.1

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0034862: Disable trigger sql statement gives error in oracle

Description

The build on oracle fails [1] and [2]. This because the insert statement here [1] does not have enough values.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/4557d1c17a88/src/org/openbravo/replication/symmetricds/extensions/BatchDatabaseWriterControl.java#l94 [^]

[2]
https://ci.openbravo.com/view/storeserver/job/ret-ms-mix-db-central-oracle/29/artifact/SANDBOX/tomcat-logs/ret-ms-mix-db-central-oracle.log [^]

[3]
2017-01-07 15:47:56,696 [central-data-loader-1] ERROR org.jumpmind.symmetric.service.impl.DataLoaderService - Failed to load batch Store1-4
org.jumpmind.db.sql.SqlException: ORA-00947: not enough values

    at org.jumpmind.db.sql.AbstractSqlTemplate.translate(AbstractSqlTemplate.java:283)
    at org.jumpmind.db.sql.AbstractSqlTemplate.translate(AbstractSqlTemplate.java:274)
    at org.jumpmind.db.sql.JdbcSqlTransaction.executeCallback(JdbcSqlTransaction.java:381)
    at org.jumpmind.db.sql.JdbcSqlTransaction.execute(JdbcSqlTransaction.java:272)
    at org.openbravo.replication.symmetricds.extensions.BatchDatabaseWriterControl.doPreBatchAction(BatchDatabaseWriterControl.java:93)
    at org.openbravo.replication.symmetricds.extensions.BatchDatabaseWriterControl.beforeWrite(BatchDatabaseWriterControl.java:86)
    at org.openbravo.replication.symmetricds.extensions.BatchDatabaseWriterControl$Proxy$_$$_WeldClientProxy.beforeWrite(BatchDatabaseWriterControl$Proxy$_$$_WeldClientProxy.java)
    at org.jumpmind.symmetric.io.data.writer.AbstractDatabaseWriter.filterBefore(AbstractDatabaseWriter.java:278)
    at org.jumpmind.symmetric.io.data.writer.AbstractDatabaseWriter.write(AbstractDatabaseWriter.java:148)
    at org.jumpmind.symmetric.io.data.writer.NestedDataWriter.write(NestedDataWriter.java:64)
    at org.jumpmind.symmetric.model.ProcessInfoDataWriter.write(ProcessInfoDataWriter.java:65)
    at org.jumpmind.symmetric.io.data.writer.NestedDataWriter.write(NestedDataWriter.java:64)
    at org.jumpmind.symmetric.io.data.writer.TransformWriter.write(TransformWriter.java:207)
    at org.jumpmind.symmetric.io.data.DataProcessor.forEachDataInTable(DataProcessor.java:200)
    at org.jumpmind.symmetric.io.data.DataProcessor.forEachTableInBatch(DataProcessor.java:170)

Steps To Reproduce

Check the store server build

Proposed Solution

Share the same sql statement in different places to prevent wrong sql for oracle. There is already a symmetric ds trigger handler which also needs to enable/disable triggers [1].

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/4557d1c17a88/src/org/openbravo/replication/symmetricds/util/SymmetricDSTriggerHandler.java [^]

Additional Information