Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034860Retail ModulesStoreServerpublic2017-01-07 12:282017-01-11 17:24
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q2Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034860: Improve fast/forced replication after a ticket has been send to the server
DescriptionThere is specific code in the SynchronizedServerProcessCaller that waits for the ticket to be synchronized from the central to the store server [1]. Some store server test cases log an error when waiting more than 6 seconds for data to be replicated from central to store [2].

This can be caused by not enough threads being available [3]. Or maybe we should wait longer than the push/route interval times.

gr. Martin

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/7097e311033f/src/org/openbravo/mobile/core/servercontroller/SynchronizedServerProcessCaller.java#l121 [^]

[2]
https://ci.openbravo.com/view/storeserver/job/ret-ms-store1-pgsql/498/testReport/org.openbravo.test.mobile.retail.multiserver.selenium.tests.store1/MS001_SalesFlow/test/ [^]

[3]
https://github.com/JumpMind/symmetric-ds/blob/3.8/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/PushService.java#L123 [^]
Steps To ReproduceSee the store server test environment
Proposed SolutionChange the default number of available threads to 3 for the push service. One thread is for the standard periodical run, the other 2 threads are then for instant pushing.

Change the wait procedure so that it first tries 20 times waiting 300 millis and then wait 20 times waiting 600 millis each. This will be waiting 18 seconds which is 8 seconds more than the push interval.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-01-07 12:28mtaalNew Issue
2017-01-07 12:28mtaalAssigned To => mtaal
2017-01-07 12:28mtaalTriggers an Emergency Pack => No
2017-01-07 12:54hgbotCheckin
2017-01-07 12:54hgbotNote Added: 0093241
2017-01-07 12:55hgbotCheckin
2017-01-07 12:55hgbotNote Added: 0093242
2017-01-07 13:00hgbotCheckin
2017-01-07 13:00hgbotNote Added: 0093243
2017-01-11 11:25mtaalStatusnew => scheduled
2017-01-11 11:25mtaalNote Added: 0093341
2017-01-11 11:25mtaalStatusscheduled => resolved
2017-01-11 11:25mtaalResolutionopen => fixed
2017-01-11 11:25mtaalReview Assigned To => AugustoMauch
2017-01-11 17:24AugustoMauchNote Added: 0093369
2017-01-11 17:24AugustoMauchStatusresolved => closed

Notes
(0093241)
hgbot   
2017-01-07 12:54   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 4557d1c17a882d22e614d0a777b7e5f5b002c49c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Jan 07 12:54:22 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/4557d1c17a882d22e614d0a777b7e5f5b002c49c [^]

Related to issue 34860: Improve fast/forced replication after a ticket has been send to the server
Set default push threads to 3 to be more flexible in pushing data on request

---
M src/org/openbravo/replication/symmetricds/templates/engine-properties.ftl
---
(0093242)
hgbot   
2017-01-07 12:55   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 137386ccc39da77c09f82bf2c91ccb14692f7ee8
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Jan 07 12:55:05 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/137386ccc39da77c09f82bf2c91ccb14692f7ee8 [^]

Related to issue 34860: Improve fast/forced replication after a ticket has been send to the server
Do the wait for data to be replicated in 2 steps, first waiting 300 ms per try, then 600 ms per try.

---
M src/org/openbravo/mobile/core/servercontroller/SynchronizedServerProcessCaller.java
---
(0093243)
hgbot   
2017-01-07 13:00   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 85a9a96476f8338e56f2d04429d8188884d654de
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Jan 07 13:00:33 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/85a9a96476f8338e56f2d04429d8188884d654de [^]

Related to issue 34860: Improve fast/forced replication after a ticket has been send to the server
Removed unintended System.err.println line

---
M src/org/openbravo/mobile/core/servercontroller/SynchronizedServerProcessCaller.java
---
(0093341)
mtaal   
2017-01-11 11:25   
Resolved by previous commits
(0093369)
AugustoMauch   
2017-01-11 17:24   
Code reviewed