Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034846Retail ModulesWeb POSpublic2017-01-03 17:062017-01-16 12:42
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionpiFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelPre packaging ( pi )
Regression date2016-12-14
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8435373ee62da7f6c0d667ba227e1e37c10f87e9 [^]
Triggers an Emergency PackNo
Summary0034846: Scanning could not work if the model has change but cache is not deleted
DescriptionWhen we use findUsingCache, the result of the search is cached in memory.

This is working fine until a new incremental refresh is done and the model of Product has change (for example, changing the UPC/EAN code associated). If the cache is not deleted, the result returned will not change.
Steps To Reproduce1) Go to backend and add/change the UPC/EAN code
2) Clean the cache of the browser and log in the webpos
3) Scan that UPC/EAN code and check the product is added to the receipt.
4) Clean this receipt
5) Go again to backend, and change the UPC/EAN code of that product again
6) Wait until the incremental refresh is done (don't do a browser refresh nor clean the cache).
7) Scan the new UPC/EAN code and check no products is added.
Proposed SolutionIn OB.DAL.findUsingCache from 'productSearch' and 'productPrice' should have a parameter after the error callback like this

{modelsAffectedByCache: ['Product']} --> This is for 'productSearch' part.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0034887RR17Q1 closed jorge-garcia Scanning could not work if the model has change but cache is not deleted 
depends on backport 0034888RR16Q4.1 closed jorge-garcia Scanning could not work if the model has change but cache is not deleted 
caused by defect 0032365 closed jorge-garcia Scanning with external barcode scanner performance can be improved 
related to defect 0034868 closed jorge-garcia Find using cache does not work if high volumes is deactivate 
related to defect 0034965 closed ranjith_qualiantech_com OB-Dal query caching is not properly handled in some external modules 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-01-03 17:06jorge-garciaNew Issue
2017-01-03 17:06jorge-garciaAssigned To => Retail
2017-01-03 17:06jorge-garciaRegression level => Pre packaging ( pi )
2017-01-03 17:06jorge-garciaRegression date => 2016-12-14
2017-01-03 17:06jorge-garciaRegression introduced in release => main
2017-01-03 17:06jorge-garciaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8435373ee62da7f6c0d667ba227e1e37c10f87e9 [^]
2017-01-03 17:06jorge-garciaTriggers an Emergency Pack => No
2017-01-03 17:07jorge-garciaRelationship addedcaused by 0032365
2017-01-09 12:05jorge-garciaStatusnew => scheduled
2017-01-09 12:05jorge-garciaAssigned ToRetail => jorge-garcia
2017-01-09 13:57jorge-garciaRelationship addedrelated to 0034868
2017-01-10 12:10jorge-garciaStatusscheduled => resolved
2017-01-10 12:10jorge-garciaResolutionopen => fixed
2017-01-10 12:10jorge-garciaNote Added: 0093304
2017-01-10 12:10jorge-garciaStatusresolved => new
2017-01-10 12:10jorge-garciaResolutionfixed => open
2017-01-10 12:10jorge-garciaStatusnew => scheduled
2017-01-11 09:17hgbotCheckin
2017-01-11 09:17hgbotNote Added: 0093321
2017-01-11 09:17hgbotStatusscheduled => resolved
2017-01-11 09:17hgbotResolutionopen => fixed
2017-01-11 09:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b3cf9ddc2aa3836d1666351387ee6abbac33ce3e [^]
2017-01-16 12:42marvintmRelationship addedrelated to 0034965
2017-01-16 12:42marvintmReview Assigned To => marvintm
2017-01-16 12:42marvintmStatusresolved => closed
2017-01-16 12:42marvintmFixed in Version => RR17Q2

Notes
(0093304)
jorge-garcia   
2017-01-10 12:10   
Create backports for 17Q1 and 16Q4.1
(0093321)
hgbot   
2017-01-11 09:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b3cf9ddc2aa3836d1666351387ee6abbac33ce3e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 09 12:07:43 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b3cf9ddc2aa3836d1666351387ee6abbac33ce3e [^]

Fixed issue 34846: Scanning could not work if the model has change but
cache is not deleted

Added logic to manage find models using cache for these models:
* Find product.
* Find product price.
* Find product service.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---