Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034843Retail ModulesWeb POSpublic2017-01-03 15:182017-01-19 12:40
Reporterdbaz 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034843: [UX] Several small UI problems in Login screen
DescriptionThere are several small UI problems in the Login screen:
* The bottom margin of the Login button should be bigger.
* The warning message right now is not well legible, due to the red color on green background. Yellow color could work ok, since it is a warning (not an error). Also, the font-size and position is not the best one. It should be better before the Login button.
* The bottom margin of the 'Not supported browser' screen should be bigger.

Attached to the issue there are the current images, the proposed visualization and a diff that solves the issue.
Steps To ReproduceSee attached images.
Proposed SolutionSee attached diff.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng LoginBase_current.png (184,890) 2017-01-03 15:18
https://issues.openbravo.com/file_download.php?file_id=10239&type=bug
png

png LoginWarning_current.png (188,911) 2017-01-03 15:18
https://issues.openbravo.com/file_download.php?file_id=10240&type=bug
png

png LoginNotSupported_current.png (149,368) 2017-01-03 15:19
https://issues.openbravo.com/file_download.php?file_id=10241&type=bug
png

png LoginBase_proposal.png (184,880) 2017-01-03 15:19
https://issues.openbravo.com/file_download.php?file_id=10242&type=bug
png

png LoginWarning_proposal.png (198,130) 2017-01-03 15:19
https://issues.openbravo.com/file_download.php?file_id=10243&type=bug
png

png LoginNotSupported_proposal.png (149,086) 2017-01-03 15:19
https://issues.openbravo.com/file_download.php?file_id=10244&type=bug
png

diff org.openbravo.mobile.core.diff (1,837) 2017-01-03 15:20
https://issues.openbravo.com/file_download.php?file_id=10245&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-01-03 15:18dbazNew Issue
2017-01-03 15:18dbazAssigned To => Retail
2017-01-03 15:18dbazOBNetwork customer => No
2017-01-03 15:18dbazTriggers an Emergency Pack => No
2017-01-03 15:18dbazFile Added: LoginBase_current.png
2017-01-03 15:18dbazFile Added: LoginWarning_current.png
2017-01-03 15:19dbazFile Added: LoginNotSupported_current.png
2017-01-03 15:19dbazFile Added: LoginBase_proposal.png
2017-01-03 15:19dbazFile Added: LoginWarning_proposal.png
2017-01-03 15:19dbazAssigned ToRetail => dbaz
2017-01-03 15:19dbazAssigned Todbaz => Retail
2017-01-03 15:19dbazFile Added: LoginNotSupported_proposal.png
2017-01-03 15:20dbazFile Added: org.openbravo.mobile.core.diff
2017-01-04 07:02ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-01-04 07:03ranjith_qualiantech_comStatusnew => scheduled
2017-01-04 10:00hgbotCheckin
2017-01-04 10:00hgbotNote Added: 0093154
2017-01-04 10:00hgbotStatusscheduled => resolved
2017-01-04 10:00hgbotResolutionopen => fixed
2017-01-04 10:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9726ee78e6a4efb9f2a68d1b2ae5eede55646be4 [^]
2017-01-04 11:29dbazNote Added: 0093161
2017-01-04 11:29dbazStatusresolved => new
2017-01-04 11:29dbazResolutionfixed => open
2017-01-05 08:46hgbotCheckin
2017-01-05 08:46hgbotNote Added: 0093210
2017-01-05 08:46hgbotStatusnew => resolved
2017-01-05 08:46hgbotResolutionopen => fixed
2017-01-05 08:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9726ee78e6a4efb9f2a68d1b2ae5eede55646be4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8ace301cd8f473bf30a3b9f0240c6555bc192309 [^]
2017-01-19 12:03marvintmNote Added: 0093730
2017-01-19 12:03marvintmStatusresolved => new
2017-01-19 12:03marvintmResolutionfixed => open
2017-01-19 12:39marvintmStatusnew => scheduled
2017-01-19 12:39marvintmStatusscheduled => resolved
2017-01-19 12:39marvintmFixed in Version => RR17Q2
2017-01-19 12:39marvintmResolutionopen => fixed
2017-01-19 12:40marvintmReview Assigned To => marvintm
2017-01-19 12:40marvintmNote Added: 0093731
2017-01-19 12:40marvintmStatusresolved => closed

Notes
(0093154)
hgbot   
2017-01-04 10:00   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9726ee78e6a4efb9f2a68d1b2ae5eede55646be4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 04 14:30:07 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9726ee78e6a4efb9f2a68d1b2ae5eede55646be4 [^]

Fixed issue 34843 : Changes in Login Button Design

* Changed Login Button & Login Warning CSS

---
M web/org.openbravo.mobile.core/assets/css/ob-login.css
M web/org.openbravo.mobile.core/source/component/ob-login.js
---
(0093161)
dbaz   
2017-01-04 11:29   
This setContent is unneeded
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9726ee78e6a4efb9f2a68d1b2ae5eede55646be4#l2.45 [^]
because always is overwritten by this one:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9726ee78e6a4efb9f2a68d1b2ae5eede55646be4#l2.60 [^]

Copyright year should be updated too (2017) in both files.
(0093210)
hgbot   
2017-01-05 08:46   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 8ace301cd8f473bf30a3b9f0240c6555bc192309
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jan 05 13:15:19 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8ace301cd8f473bf30a3b9f0240c6555bc192309 [^]

Fixed issue 34843 : Changes in Login Button Design

* Removed Incorrect Code, Modified Copyright Year

---
M web/org.openbravo.mobile.core/assets/css/ob-login.css
M web/org.openbravo.mobile.core/source/component/ob-login.js
---
(0093730)
marvintm   
2017-01-19 12:03   
Changes to the main login page are correct as far as I can see. However, I don't see any changes in the "Non supported browser" screen, so this part is missing.
(0093731)
marvintm   
2017-01-19 12:40   
After further review, the changes done are correct, and the "not supported browser" window is properly shown, so the issue can be closed.