Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034839Openbravo ERP07. Sales managementpublic2017-01-03 13:222017-04-05 09:01
Reporterpsanjuan 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionProfessional Appliance
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tomarkmm82
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2016-09-28
Regression introduced in release3.0PR16Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/17fbbe90b24e [^]
Triggers an Emergency PackNo
Summary0034839: Not possible to select a shipment in RFC window if that shipment has not been created from an order.
DescriptionNot possible to select a shipment in RFC window if that shipment has not been created from an order.
Steps To ReproduceIn Livebuilds Q4.
Go to product window and create a new one named Product 1 for F&B España.
Enter a purchase price list (Tarifa Bebidas Alegres) and a sales price list (Tarifa de Ventas) in tab "Price".
Enter any unit and list price.

Go to purchase order window and create a new one for F&B España, Bebidas Alegres business partner.
Go to Lines and select the product. Enter an ordered Qty = 500 Units.
Book the order.

Go to Goods Receipt windown and create a new one for F&B España, Bebidas Alegres business partner.
Use Create Lines From. Select the order. Enter a storage bin (RN-0-0-0) and receipt all quanity.
Complete the receipt.

Go to Sales order window and create a new one for F&B España, Alimentos y Supermercados business partner.
Go to Lines and select Product 1. Enter an ordered quantity = 10.
Book the order.

Go to Goods Shipment window and create a new one for F&B España, Alimentos y Supermercados business partner.
Use Create Lines From. Select the sales order just created. Enter a warehouse position RN-0-0-0, and select all lines. Press OK.
Complete the shipment. Write down shipment order number 210, for instance.

In Goods Shipment window create another one for F&B España, Alimentos y Supermercados business partner.
Go to lines tab and create a new one. Select Product 1. Change Movement quantity to 15. Storage bin RN-0-0-0.
Complete the shipment. Write down shipment order number 211, for instance.
 

Go to Return from Customer window, and create a new one for F&B España, Alimentos y Supermercados business partner.
Click on Pick/Edit Lines.

Verify that shipment number 210 (the one created from the sales order) is shown, while shipment number 211 (the one created from scrath) is not.

Proposed SolutionBoth shipment must be shown for selection in Return From Customer window.

Same flow is working in purchase cycle, anyway please double check.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00348513.0PR17Q1 closed rqueralta Not possible to select a shipment in RFC window if that shipment has not been created from an order. 
depends on backport 00348523.0PR16Q4.1 closed rqueralta Not possible to select a shipment in RFC window if that shipment has not been created from an order. 
caused by defect 0034031 closed AtulOpenbravo Return From Customer pick and edit is very slow with big data 
related to defect 0035682 closed markmm82 Return From Customer pick and edit is very slow with big data 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-01-03 13:22psanjuanNew Issue
2017-01-03 13:22psanjuanAssigned To => Triage Finance
2017-01-03 13:22psanjuanModules => Core
2017-01-03 13:22psanjuanTriggers an Emergency Pack => No
2017-01-03 13:34psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14197#r14197
2017-01-03 13:34psanjuanProposed Solution updated
2017-01-03 13:35psanjuanRegression level => Production - QA Approved
2017-01-03 13:35psanjuanRegression introduced in release => 3.0PR16Q4
2017-01-03 13:40psanjuanSummaryNot possible to select a shipment in RFC window if that shipment has not been created from the order. => Not possible to select a shipment in RFC window if that shipment has not been created from an order.
2017-01-03 13:40psanjuanDescription Updatedbug_revision_view_page.php?rev_id=14199#r14199
2017-01-03 16:54markmm82Assigned ToTriage Finance => rqueralta
2017-01-04 16:11rqueraltaStatusnew => scheduled
2017-01-05 15:08rqueraltaNote Added: 0093231
2017-01-05 15:17rqueraltaRegression date => 2016-09-28
2017-01-05 15:17rqueraltaRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/17fbbe90b24e [^]
2017-01-05 19:10markmm82Relationship addedcaused by 0034031
2017-01-06 16:39hgbotCheckin
2017-01-06 16:39hgbotNote Added: 0093239
2017-01-06 16:39hgbotStatusscheduled => resolved
2017-01-06 16:39hgbotResolutionopen => fixed
2017-01-06 16:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/20d4ef128855c52deee8520777153f8714416269 [^]
2017-01-09 13:54psanjuanNote Added: 0093258
2017-01-09 14:04psanjuanNote Added: 0093259
2017-01-09 14:27psanjuanNote Edited: 0093258bug_revision_view_page.php?bugnote_id=0093258#r14224
2017-01-09 17:57markmm82Review Assigned To => markmm82
2017-01-09 17:57markmm82Note Added: 0093278
2017-01-09 17:57markmm82Statusresolved => closed
2017-01-09 17:57markmm82Fixed in Version => 3.0PR17Q2
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095069
2017-04-04 12:28aferrazRelationship addedrelated to 0035682
2017-04-05 09:01AtulOpenbravoNote Added: 0095839

Notes
(0093231)
rqueralta   
2017-01-05 15:08   
As F&B International Group Admin

 - Go to Product window
   Create a new one named Product 1 for F&B España.
   Enter a purchase price list (Tarifa Bebidas Alegres) and a sales price list (Tarifa de Ventas) in tab "Price".
   Enter any unit and list price.

 - Go to Purchase Order window
   Create a new one for F&B España, Bebidas Alegres business partner.
   Go to Lines and select the product. Enter an ordered Qty = 500 Units.
   Book the order.

 - Go to Goods Receipt window
   Create a new one for F&B España, Bebidas Alegres business partner.
   Use Create Lines From. Select the order. Enter a storage bin (RN-0-0-0) and receipt all quanity.
   Complete the receipt.

 - Go to Sales Order window
   Create a new one for F&B España, Alimentos y Supermercados business partner.
   Go to Lines and select Product 1. Enter an ordered quantity = 10.
   Book the order.

 - Go to Goods Shipment window
   Create a new one for F&B España, Alimentos y Supermercados business partner.
   Use Create Lines From. Select the sales order just created. Enter a warehouse position RN-0-0-0, and select all lines. Press OK.
   Complete the shipment. Write down shipment order number 210, for instance.

 - In Goods Shipment window create another one for F&B España, Alimentos y Supermercados business partner.
   Go to lines tab and create a new one. Select Product 1. Change Movement quantity to 15. Storage bin RN-0-0-0.
   Complete the shipment. Write down shipment order number 211, for instance.
 
 - Go to Return from Customer window
   Create a new one for F&B España, Alimentos y Supermercados business partner.
   Click on Pick/Edit Lines.

 - Verify that shipment number 210 (the one created from the sales order) is shown, and that shipment number 211 (the one created from scrath) is shown too.
(0093239)
hgbot   
2017-01-06 16:39   
Repository: erp/devel/pi
Changeset: 20d4ef128855c52deee8520777153f8714416269
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Wed Jan 04 14:29:14 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/20d4ef128855c52deee8520777153f8714416269 [^]

Fixed issue 34839: Not possible to select a GS in RFC not created from an order

 Restructured HQL inserter query for discount to select a GS in RFC has not been
 created from an order

---
M src/org/openbravo/common/datasource/ReturnFromCustomerHQLInserter.java
---
(0093258)
psanjuan   
2017-01-09 13:54   
(edited on: 2017-01-09 14:27)
Test plan above verified.

Also tested that:
- shipments created by using "Create Shipments from Orders" are also reflected in Pick/Edit lines window launched from Return from Customer
- together with shipments created from orders and shipments created from scratch in Goods Shipment window.
- and shipments including more than one line and a discount line or not.
(0093259)
psanjuan   
2017-01-09 14:04   
Issue can be code reviewed and closed.
(0093278)
markmm82   
2017-01-09 17:57   
Code review + Testing OK
(0095069)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095839)
AtulOpenbravo   
2017-04-05 09:01   
Manual test link created
https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10519 [^]