Openbravo Issue Tracking System - Retail Modules
View Issue Details
0034831Retail ModulesWeb POSpublic2016-12-29 18:222017-03-14 13:59
dbaz 
jorge-garcia 
normalmajoralways
closedfixed 
5
 
RR17Q2 
guilleaer
Coding ( Testing )
pi
No
0034831: [UX] Customer button gets 'ellipsis' when it is not needed
The customer button (the one in the top of the receipt) gets 'ellipsis' when it is not needed. It doesn't happen in 16Q4.

http://screencast.com/t/iwcXrhu9 [^]

The 'ellipsis' NEVER should be performed if there is free horizontal space, independently of the length of the button labels. In the 'Proposed Solution' section there is an example of how it should behave.
Login into the WebPOS with base sampledata.
The width and ellipsis of these buttons should behave like this example:

https://jsfiddle.net/r77t19zt/2/ [^]

As you can see, the own CSS:
* Takes advantage of using all the available space to show as much content as possible.
* Ensures that both buttons are always in the same line.
* Gives more priority to the full customer visualization while start shrinking -flex-shrink- (just in case of large addresses).
* Sets a maximum width -max-width: 70%;- (just in case of very very large button labels).
No tags attached.
depends on backport 0035510RR17Q1.1 closed jorge-garcia [UX] Customer button gets 'ellipsis' when it is not needed 
Issue History
2016-12-29 18:22dbazNew Issue
2016-12-29 18:22dbazAssigned To => Retail
2016-12-29 18:22dbazRegression level => Coding ( Testing )
2016-12-29 18:22dbazRegression introduced in release => pi
2016-12-29 18:22dbazTriggers an Emergency Pack => No
2016-12-29 19:05dbazProposed Solution updated
2016-12-30 09:51guilleaerNote Added: 0093069
2016-12-30 12:04dbazProposed Solution updated
2017-03-08 13:40hgbotCheckin
2017-03-08 13:41hgbotNote Added: 0094833
2017-03-08 13:41hgbotStatusnew => resolved
2017-03-08 13:41hgbotResolutionopen => fixed
2017-03-08 13:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/45d8c72790f7778bea8e93b61867305901ce5b6a [^]
2017-03-08 18:16marvintmAssigned ToRetail => jorge-garcia
2017-03-09 13:00guilleaerReview Assigned To => guilleaer
2017-03-09 13:00guilleaerStatusresolved => closed
2017-03-09 13:00guilleaerFixed in Version => RR17Q2
2017-03-14 13:59marvintmStatusclosed => new
2017-03-14 13:59marvintmResolutionfixed => open
2017-03-14 13:59marvintmFixed in VersionRR17Q2 =>
2017-03-14 13:59marvintmStatusnew => scheduled
2017-03-14 13:59marvintmStatusscheduled => resolved
2017-03-14 13:59marvintmFixed in Version => RR17Q2
2017-03-14 13:59marvintmResolutionopen => fixed
2017-03-14 13:59marvintmStatusresolved => closed

Notes
(0093069)
guilleaer   
2016-12-30 09:51   
As David mentioned I suggest to fix it using flexbox.

There are already some css classes created in mobile core (ob-standard.css) to take advantage of them. (.standardFlexContainer)
(0094833)
hgbot   
2017-03-08 13:41   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 45d8c72790f7778bea8e93b61867305901ce5b6a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Mar 08 13:38:29 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/45d8c72790f7778bea8e93b61867305901ce5b6a [^]

Fixed issue 34831: [UX] Customer button gets 'ellipsis' when it is not
needed

* Used flexible box for customer buttons in pointofsale tab of webPOS.
* Remove useless css classes.

---
M web/org.openbravo.retail.posterminal/css/obpos-main.css
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
M web/org.openbravo.retail.posterminal/js/components/businesspartner_selector.js
M web/org.openbravo.retail.posterminal/js/components/order.js
---