Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034798Retail ModulesWeb POSpublic2016-12-21 12:052016-12-22 18:25
Reporterxabiermerino 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034798: [SERQA 2205] Split lines does not work if the product has a service mandatory
DescriptionSplit lines does not work if the product has a service mandatory
Steps To Reproduce1.- Go to Backend and go to the service 'Configuration'
2.- Confirm that the proposal type is mandatory and the product associated is GPS nano
3.- Log into webPOS
4.- Create a ticket and select 3 units of GPS nano
5.- Split the line in three lines
6.- Realize that the line is split in two, the amount is in grey
Proposed SolutionThe problem is on the logic to check if a line has mandatory services, on the following code:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/515b485ea128/web/org.openbravo.retail.posterminal/js/model/order.js#l1611 [^]

When the product has mandatory services but the line has been added using split lines, the call to callbackAddProduct() is missing, so the execution is stopped.
Additional Information
TagsSER-QA
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-21 12:05xabiermerinoNew Issue
2016-12-21 12:05xabiermerinoAssigned To => Retail
2016-12-21 12:05xabiermerinoOBNetwork customer => Yes
2016-12-21 12:05xabiermerinoResolution time => 1483570800
2016-12-21 12:05xabiermerinoTriggers an Emergency Pack => No
2016-12-21 12:06xabiermerinoTag Attached: SER-QA
2016-12-21 12:12aaroncaleroProposed Solution updated
2016-12-21 13:35jorge-garciaAssigned ToRetail => jorge-garcia
2016-12-22 08:42hgbotCheckin
2016-12-22 08:42hgbotNote Added: 0092931
2016-12-22 08:42hgbotCheckin
2016-12-22 08:42hgbotNote Added: 0092932
2016-12-22 08:42hgbotStatusnew => resolved
2016-12-22 08:42hgbotResolutionopen => fixed
2016-12-22 08:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2fdaa6b081e1c96b06af9c07cd22fe4edd16a768 [^]
2016-12-22 18:25marvintmReview Assigned To => marvintm
2016-12-22 18:25marvintmStatusresolved => closed
2016-12-22 18:25marvintmFixed in Version => RR17Q1

Notes
(0092931)
hgbot   
2016-12-22 08:42   
Repository: tools/automation/pi-mobile
Changeset: 6836a507ba684b17a50740adae892e2bb1482e10
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Dec 21 17:45:45 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6836a507ba684b17a50740adae892e2bb1482e10 [^]

Verifies issue 34798: [SERQA 2205] Split lines does not work if the product has
a service mandatory

Added test I34798_SplitLinesWithMandatoryServices.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/I34798_SplitLinesWithMandatoryServices.java
---
(0092932)
hgbot   
2016-12-22 08:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2fdaa6b081e1c96b06af9c07cd22fe4edd16a768
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Dec 21 17:45:13 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2fdaa6b081e1c96b06af9c07cd22fe4edd16a768 [^]

Fixed issue 34798: [SERQA 2205] Split lines does not work if the product has a
service mandatory

If the user tries to split a line with mandatory services, the execution is
blocked because a callback is not execute.

The solution is to execute that callback in that specific scenario.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---