Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034797Openbravo ERP07. Sales managementpublic2016-12-21 11:052017-03-15 20:18
Reporternataliag 
Assigned Toalostale 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket44837
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034797: Insert Orphan line preference allows to insert products without having into account organization.
DescriptionIf you have the button “Insert Orphan Line” active and you create a return from customer using a specific organization and you insert a line using that Orphan line button you can select a product from a different organization and made the return.
Steps To Reproduce1- In back end select the F&B International Group Admin and go to “Preference” window.
2- Create a new preference Setting the property “RM Allow Orphan Line” to value Y and log out and log in again.
3- Go to “Return from Customer” window and create a new register using as organization F&B US,Inc. Click on “Insert Orphan Line”
3.1- In the product selector only products in the current org tree are accessible in drop down list: ie. try to filer by "Zumo de Piña" and check it's not accesible -> OK
3.2- But in selector's popup products from other organizations are available: open product selector's popup click the magnifier icon and filter by "Zumo de Piña", check it's available -> ERROR

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0034938 closed alostale can't select product in Return from Customer > Insert Orphan Line 
has duplicate defect 0036176 closed caristu Business Partner Category information not shown in Business Partner selector due to "_extraProperties" are missed 
Attached Filesjpg issue34797.JPG (98,303) 2016-12-21 20:17
https://issues.openbravo.com/file_download.php?file_id=10206&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2016-12-21 11:05nataliagNew Issue
2016-12-21 11:05nataliagAssigned To => Triage Finance
2016-12-21 11:05nataliagOBNetwork customer => Yes
2016-12-21 11:05nataliagModules => Core
2016-12-21 11:05nataliagSupport ticket => 44837
2016-12-21 11:05nataliagResolution time => 1484089200
2016-12-21 11:05nataliagTriggers an Emergency Pack => No
2016-12-21 11:22heccamIssue Monitored: heccam
2016-12-21 15:23markmm82Assigned ToTriage Finance => rqueralta
2016-12-21 15:26markmm82Statusnew => scheduled
2016-12-21 20:16rqueraltaNote Added: 0092919
2016-12-21 20:16rqueraltaStatusscheduled => feedback
2016-12-21 20:17rqueraltaFile Added: issue34797.JPG
2016-12-21 20:24heccamNote Added: 0092920
2016-12-22 13:44nataliagNote Added: 0092942
2016-12-22 13:45nataliagStatusfeedback => scheduled
2016-12-26 17:20markmm82Note Added: 0092997
2016-12-26 17:20markmm82Assigned Torqueralta => nataliag
2016-12-26 17:20markmm82Statusscheduled => feedback
2016-12-27 08:37heccamNote Added: 0093005
2017-01-02 10:42nataliagNote Added: 0093084
2017-01-02 10:42nataliagAssigned Tonataliag => markmm82
2017-01-02 10:42nataliagStatusfeedback => scheduled
2017-01-06 17:26markmm82Assigned Tomarkmm82 => rqueralta
2017-01-12 09:35vmromanosNote Added: 0093377
2017-01-13 09:46alostaleRelationship addeddepends on 0034938
2017-01-13 11:43alostaleSummaryInsert Orphan line preference allow to insert products without having into account organization. => Insert Orphan line preference allows to insert products without having into account organization.
2017-01-13 11:43alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14273#r14273
2017-01-13 11:43alostaleAssigned Torqueralta => alostale
2017-01-13 11:49alostaleReview Assigned To => caristu
2017-01-13 11:49hgbotCheckin
2017-01-13 11:49hgbotNote Added: 0093503
2017-01-13 11:49hgbotStatusscheduled => resolved
2017-01-13 11:49hgbotResolutionopen => fixed
2017-01-13 11:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4cd8e4f37081841dbe8b682db0e1ceb3625bfece [^]
2017-01-13 14:51caristuNote Added: 0093548
2017-01-13 14:51caristuStatusresolved => closed
2017-01-13 14:51caristuFixed in Version => 3.0PR17Q2
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095092
2017-06-22 11:17caristuRelationship addedhas duplicate 0036176

Notes
(0092919)
rqueralta   
2016-12-21 20:16   
In the popup Insert Orphan Lines, the field Product is not shown, therefore they can not complete all of the steps to reproduce this issue. See the attached image.
(0092920)
heccam   
2016-12-21 20:24   
Please check the video. https://youtu.be/hg66ne-ZH-c [^]
(0092942)
nataliag   
2016-12-22 13:44   
In livebuilds the field product is not shown but using a local instance the problem can be reproduced.
(0092997)
markmm82   
2016-12-26 17:20   
When the popup is loaded the product selector is hidden so steps can't be finished. Can you please specify on wich version you are working on?
(0093005)
heccam   
2016-12-27 08:37   
In our case Openbravo3.0 PR16Q3.2
(0093084)
nataliag   
2017-01-02 10:42   
We have reproduced the problem in a local instance also in PR16Q3 and using Openbravo for retail RR16Q3.4. Doing the steps reported in the local instance, the popup appears with the product selector field on it
(0093377)
vmromanos   
2017-01-12 09:35   
If this issue is reproducible in PI, then we will fix it.
If it's not reproducible anymore, then there is nothing to fix and the issue should be closed
(0093503)
hgbot   
2017-01-13 11:49   
Repository: erp/devel/pi
Changeset: 4cd8e4f37081841dbe8b682db0e1ceb3625bfece
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jan 13 11:47:44 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4cd8e4f37081841dbe8b682db0e1ceb3625bfece [^]

fixed bug 34797: 3.0 selector as process param don't apply filter expression

  When a 3.0 selector is used as parameter within a process (ad_process), filter
  expressions it might define were not applied in popup filters.

  There were 2 problems in the code:
   - Incorrect default assignment using bitwise or operator instead of boolean OR.
   - Incorrect retrieval of selector definition id

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js
---
(0093548)
caristu   
2017-01-13 14:51   
Code reviewed + tested in pi@1a343ca1fb00

Now the filtering is also applied in the pop-up of the selector.
(0095092)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test