Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034791Openbravo ERPA. Platformpublic2016-12-20 18:402016-12-23 08:56
ReporterJONHM 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034791: Reports are printed with null values when parent Organization's address is empty
DescriptionReports are printed with null values when parent Organization's address is empty
Steps To Reproduce-As F&B Admin role:
1) Open [Organization] window and select record "F&B España, S.A"
2) Switch to "Information" tab and delete the address line.
3) Then, create a new line in the same tab, with address empty and save the record.
4) Open [Sales Order] window and create a new Sales Order (Business Partner: Alimentos y Supermercados S.A.) FOR ORGANIZATION "F&B España - Region Norte"
5) And also create a new line for that Sales Order (Agua sin gas 1L)
6) Finally, press "Print" button of the toolbar. Select "No, just print it" and open the downloaded report.

--> Notice that every numeric value is null
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-20 18:40JONHMNew Issue
2016-12-20 18:40JONHMAssigned To => platform
2016-12-20 18:40JONHMModules => Core
2016-12-20 18:40JONHMTriggers an Emergency Pack => No
2016-12-21 09:37alostaleAssigned Toplatform => Triage Finance
2016-12-21 09:43caristuAssigned ToTriage Finance => caristu
2016-12-21 09:59hgbotCheckin
2016-12-21 09:59hgbotNote Added: 0092892
2016-12-21 09:59hgbotStatusnew => resolved
2016-12-21 09:59hgbotResolutionopen => fixed
2016-12-21 09:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6352395146ac87517192a912da873bb93654495d [^]
2016-12-21 10:08caristuNote Added: 0092893
2016-12-21 10:08caristuReview Assigned To => alostale
2016-12-21 20:51hudsonbotCheckin
2016-12-21 20:51hudsonbotNote Added: 0092923
2016-12-23 08:56alostaleNote Added: 0092961
2016-12-23 08:56alostaleStatusresolved => closed
2016-12-23 08:56alostaleFixed in Version => 3.0PR17Q1

Notes
(0092892)
hgbot   
2016-12-21 09:59   
Repository: erp/devel/pi
Changeset: 6352395146ac87517192a912da873bb93654495d
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Dec 21 09:57:25 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6352395146ac87517192a912da873bb93654495d [^]

fixes issue 34791: Null values in reports if parent org address is empty

The standard reports make use of the applyCountryDateFormat and getCountryNumberFormat utility methods to format dates and numbers. These methods obtain the formats from the Location Settings defined for the organization's country whose id is received as parameter.

In case the organization received from this methods does not have a country (address) defined, then these methods were failing silently. Since now, if the organization does not have an address defined properly, these methods are using the default formats.

---
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0092893)
caristu   
2016-12-21 10:08   
Note that the standard reports are using the Location Settings of the first legal entity in the natural tree (starting from the document's organization) to format the final document.

In case someone needs to use the Location Settings of the document's organization, then the .jrxml template should be modified.
(0092923)
hudsonbot   
2016-12-21 20:51   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/abc21394bfb8 [^]
Maturity status: Test
(0092961)
alostale   
2016-12-23 08:56   
code reviewed + tested