Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034786Retail ModulesWeb POSpublic2016-12-20 12:592017-01-24 09:32
Reporterranjith_qualiantech_com 
Assigned Toguilleaer 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034786: Payment Method Popup ID Duplicated After Completing Ticket
DescriptionPayment Method Popup ID was duplicated, if the Payment Method Popup is opened several times. If ID is duplicated then "Problems in Popup" will be shown
Steps To ReproduceInstance With Gift Card Module
1) Add any product to receipt
2) Click Pay and Click More Button
3) Close Payment Method Popup
4) Complete the ticket
5) IN New Ticket, Add any product to receipt
6) Click Pay and Click More Button

Payment Method Popup ID Duplicated
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0034955RR17Q1 closed guilleaer Payment Method Popup ID Duplicated After Completing Ticket 
caused by design defect 0034327 closed ranjith_qualiantech_com [UX] If popups are not working properly, an error message should be shown 
Attached Filesdiff org.openbravo.mobile.core.diff (2,948) 2017-01-11 22:15
https://issues.openbravo.com/file_download.php?file_id=10287&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-12-20 12:59ranjith_qualiantech_comNew Issue
2016-12-20 12:59ranjith_qualiantech_comAssigned To => Retail
2016-12-20 12:59ranjith_qualiantech_comTriggers an Emergency Pack => No
2016-12-20 13:14ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-12-20 13:14ranjith_qualiantech_comStatusnew => scheduled
2016-12-20 13:19hgbotCheckin
2016-12-20 13:19hgbotNote Added: 0092855
2017-01-09 10:02ranjith_qualiantech_comRelationship addedcaused by 0034327
2017-01-10 16:49guilleaerAssigned Toranjith_qualiantech_com => guilleaer
2017-01-11 22:08dbazNote Added: 0093374
2017-01-11 22:09dbazFile Added: org.openbravo.mobile.core.diff
2017-01-11 22:15dbazFile Deleted: org.openbravo.mobile.core.diff
2017-01-11 22:15dbazFile Added: org.openbravo.mobile.core.diff
2017-01-13 16:03hgbotCheckin
2017-01-13 16:03hgbotNote Added: 0093553
2017-01-13 16:03hgbotStatusscheduled => resolved
2017-01-13 16:03hgbotResolutionopen => fixed
2017-01-13 16:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/530f8d565b096a2d1270fe5070bb2cbf274c4d65 [^]
2017-01-13 19:35guilleaerStatusresolved => new
2017-01-13 19:35guilleaerResolutionfixed => open
2017-01-13 19:36guilleaerStatusnew => scheduled
2017-01-13 19:36guilleaerStatusscheduled => resolved
2017-01-13 19:36guilleaerFixed in Version => RR17Q2
2017-01-13 19:36guilleaerResolutionopen => fixed
2017-01-18 16:52hgbotCheckin
2017-01-18 16:52hgbotNote Added: 0093704
2017-01-24 09:32marvintmReview Assigned To => marvintm
2017-01-24 09:32marvintmStatusresolved => closed

Notes
(0092855)
hgbot   
2016-12-20 13:19   
Repository: tools/automation/pi-mobile
Changeset: 2a16dd690669464f15efce9df0ce6ea60c1a7cb1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Dec 20 17:49:13 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2a16dd690669464f15efce9df0ce6ea60c1a7cb1 [^]

Verifies issue 34786 : Modified automated test 'I32981_VerifyGiftCardLineSelection' failed in quarantine

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I32981_VerifyGiftCardLineSelection.java
---
(0093374)
dbaz   
2017-01-11 22:08   
It seems that this is the culprit:

https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/216 [^]

Attached a diff with a draft of a possible fix.
(0093553)
hgbot   
2017-01-13 16:03   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 530f8d565b096a2d1270fe5070bb2cbf274c4d65
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Jan 12 15:35:42 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/530f8d565b096a2d1270fe5070bb2cbf274c4d65 [^]

Fixed issue 34786: More Payment Methods popup has been refactored and it works fine after complete a sale

The popup is now defined in the posterminal window (As we do with the majority of the popups). Buttons which are in the list are generated dynamically when the popup is opened for the first time or when new payments methods have to be added.

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
A web/org.openbravo.retail.posterminal/js/components/modalmorepaymentmethods.js
---
(0093704)
hgbot   
2017-01-18 16:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7e201e43de542f2df88338219370db1e7a8db420
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Jan 18 16:51:50 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7e201e43de542f2df88338219370db1e7a8db420 [^]

Related to issue 34786: Update copyright year

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---