Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034780Openbravo ERPA. Platformpublic2016-12-20 11:102022-02-01 08:08
Reportershuehner 
Assigned ToTriage Platform Base 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusscheduledResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034780: Check in WindowSettingsActionHandler about: Tab set to read-only as it is based on a view should be probably done at comple time
DescriptionWindowSettingsActionHandler has code to emit warnings like the following:
585c6c2a 2016-12-19 23:29:19,911 [ajp-bio-127.0.0.1-8009-exec-1] WARN org.openbravo.client.application.WindowSettingsActionHandler - Tab "Accounting" is set to read only because is assigned with a table defined as a view.

From message and reading code that could be probably done at compile time which makes it much easier to mass-check the definitions (i.e. using CI)

Note:
The ActionHandler checks user/role permissions first before the check however that check for window/tab/table definition should be probably still done not taking user-permissions into account as a role might appear triggering this issue at any time.

Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034782 closed rqueralta Modules Tabs based on views should be marked as read-only as per warning message in openbravo.log 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-20 11:10shuehnerNew Issue
2016-12-20 11:10shuehnerAssigned To => platform
2016-12-20 11:10shuehnerOBNetwork customer => No
2016-12-20 11:10shuehnerModules => Core
2016-12-20 11:10shuehnerTriggers an Emergency Pack => No
2016-12-20 11:22shuehnerNote Added: 0092833
2016-12-20 11:22shuehnerRelationship addedrelated to 0034782
2016-12-20 21:23markmm82Assigned Toplatform => rqueralta
2016-12-20 21:24markmm82Statusnew => scheduled
2016-12-29 23:38rqueraltaNote Added: 0093062
2017-09-26 20:43aferrazAssigned Torqueralta => platform
2022-02-01 08:08alostaleAssigned Toplatform => Triage Platform Base

Notes
(0092833)
shuehner   
2016-12-20 11:22   
Example SQL to find candidates for this:
select t.uipattern, w.name,t.name, tabl.tablename, tabl.isview from ad_tab t, ad_table tabl, ad_window w where w.ad_window_id = t.ad_window_id and t.ad_table_id = tabl.ad_table_id and t.name = 'Accounting' and tabl.tablename ilike '%_V';

The ones not having uipattern RO.

There seem to be none in core, however the module 'Accounting tabs for transactions' has examples (i.e. installed online erp demo)
(0093062)
rqueralta   
2016-12-29 23:38   
Test plan:

As System Admin
  - Install "Accounting tab for transactions" module
  - Run the example the below SQL to find candidates:
    select t.uipattern, w.name,t.name, tabl.tablename, tabl.isview from ad_tab t, ad_table tabl, ad_window w where w.ad_window_id = t.ad_window_id and t.ad_table_id = tabl.ad_table_id and t.name = 'Accounting' and tabl.tablename ilike '%_V';
  - Verify that all recovered records have uipattern = RO