Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0034772Openbravo ERP07. Sales managementpublic2016-12-19 13:412019-05-24 10:52
airaceburu 
airaceburu 
normalmajorN/A
closedfixed 
5
 
 
vmromanos
Core
No
0034772: New total field in select payment popup of the remittance window
A new total field in select payment popup of the remittance window is needed to control the total amount of the remittance.
N/A
No tags attached.
diff newTotalFieldRemittance.diff (19,952) 2019-03-14 09:44
https://issues.openbravo.com/file_download.php?file_id=12747&type=bug
Issue History
2016-12-19 13:41airaceburuNew Issue
2016-12-19 13:41airaceburuAssigned To => airaceburu
2016-12-19 13:41airaceburuModules => Core
2016-12-19 13:41airaceburuTriggers an Emergency Pack => No
2019-03-14 09:44airaceburuFile Added: newTotalFieldRemittance.diff
2019-03-14 09:44airaceburuAssigned Toairaceburu => Triage Finance
2019-05-14 15:23vmromanosStatusnew => scheduled
2019-05-14 15:23vmromanosAssigned ToTriage Finance => airaceburu
2019-05-14 15:25vmromanosNote Added: 0111671
2019-05-14 15:33vmromanosNote Edited: 0111671bug_revision_view_page.php?bugnote_id=0111671#r18771
2019-05-14 15:35vmromanosNote Edited: 0111671bug_revision_view_page.php?bugnote_id=0111671#r18772
2019-05-24 09:11hgbotCheckin
2019-05-24 09:11hgbotNote Added: 0112112
2019-05-24 09:11hgbotStatusscheduled => resolved
2019-05-24 09:11hgbotResolutionopen => fixed
2019-05-24 09:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/bcf07ecebf3c6413534a7ee5642d16616fcf9152 [^]
2019-05-24 09:12airaceburuAssigned Toairaceburu => Triage Finance
2019-05-24 10:51vmromanosReview Assigned To => vmromanos
2019-05-24 10:51vmromanosAssigned ToTriage Finance => airaceburu
2019-05-24 10:52vmromanosNote Added: 0112118
2019-05-24 10:52vmromanosStatusresolved => closed

Notes
(0111671)
vmromanos   
2019-05-14 15:25   
(edited on: 2019-05-14 15:35)
Test plan:

With Remittances module installed and sample data applied

Log in as F&B Admin

Go to Financial Account Window and select Cuenta de Banco Financial Account
Move to Payment Method Tab and create a new record
  - Payment Method: Remittance
  - Receive Payments in Mutliple currencies: Yes
  - Make Payments in Multiple currencies: Yes
Save the record

Go to Payment In Window and create a new record with:
  - Organization: F&B España Región Norte
  - Received From: Alimentos y Supermercados
  - Deposit To: Cuenta de Banco
  - Payment Method: Remittance
  - Currency: EUR
  - Amount: 100
Click on select lines
In the pop up, move to G/L Items section and add a new one
Select Capital Social G/L Item and Received 100
Complete the Payment

Go to Payment In Window and create a new record with:
  - Organization: F&B España Región Norte
  - Received From: Alimentos y Supermercados
  - Deposit To: Cuenta de Banco
  - Payment Method: Remittance
  - Currency: USD
  - Amount: 100
Click on select lines
In the pop up, move to G/L Items section and add a new one
Select Capital Social G/L Item and Received 100
Complete the Payment

Go to Remittance window and create a new record with:
  - Organization: F&B España Región Norte
  - Financial Account: Cuenta de Banco
  - Name: Test
Click on select payments and remove the filter
Select payments from different currencies.
Verify the amounts are added grouping by currency in the new field.
Press Done.

Press Select Payments again.
The popup is opened with the previously selected payments.
Verify the total amounts per currency in the new field are OK.

Press the select/unselect all records.
Verify the total amounts per currency in the new field are OK.

Verify there are no errors in the browser developer console during these tests.


Click quickly in the same checkbox to select and unselect it. Verify the total amounts are properly calculated.


Repeat the tests in Chrome and Firefox.

(0112112)
hgbot   
2019-05-24 09:11   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: bcf07ecebf3c6413534a7ee5642d16616fcf9152
Author: Ander Iraceburu <ander.iraceburu <at> openbravo.com>
Date: Fri May 24 09:11:16 2019 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/bcf07ecebf3c6413534a7ee5642d16616fcf9152 [^]

Fixes issue 34772: New total field in select payment popup of the remittance window

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M web/org.openbravo.module.remittance/js/ob-rem-utilities.js
---
(0112118)
vmromanos   
2019-05-24 10:52   
Code review + testing OK.

Fixed in Remittances infrastructure 3.2.5000 or above