Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034720Retail ModulesWeb POSpublic2016-12-13 10:332016-12-22 17:40
ReporterAsantos9 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034720: Pay Open Tickets blocked
DescriptionTwo layaways tickets in 'Pay Open Tickets' with a delivery condition different of 'pick and carry' is blocked when 'Done' button is clicked.
Steps To Reproduce- Implement the next hook:

OB.UTIL.HookManager.registerHook('OBPOS_preAddPayment', function (args, callback) {
  setTimeout(function(){
    OB.UTIL.HookManager.callbackExecutor(args, callback);
  }, 0)
});

- Create two different layaways tickets with a product and delivery condition different of 'pick and carry'
- Press on the green tick
- Click on 'Done'

Note that the Web POS is bloqued.
Proposed SolutionA callback in addPayment missing
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-13 10:33Asantos9New Issue
2016-12-13 10:33Asantos9Assigned To => Retail
2016-12-13 10:33Asantos9OBNetwork customer => No
2016-12-13 10:33Asantos9Triggers an Emergency Pack => No
2016-12-13 10:35Asantos9Steps to Reproduce Updatedbug_revision_view_page.php?rev_id=13981#r13981
2016-12-15 13:11jorge-garciaStatusnew => scheduled
2016-12-15 13:11jorge-garciaAssigned ToRetail => jorge-garcia
2016-12-15 14:53marvintmOBNetwork customerNo => Yes
2016-12-15 14:53marvintmResolution time => 1482966000
2016-12-22 10:31hgbotCheckin
2016-12-22 10:31hgbotNote Added: 0092935
2016-12-22 10:31hgbotStatusscheduled => resolved
2016-12-22 10:31hgbotResolutionopen => fixed
2016-12-22 10:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9f8d7d89ddd55585dd0f3363723d83a601c22fdc [^]
2016-12-22 17:37hgbotCheckin
2016-12-22 17:37hgbotNote Added: 0092951
2016-12-22 17:40guilleaerReview Assigned To => guilleaer
2016-12-22 17:40guilleaerStatusresolved => closed
2016-12-22 17:40guilleaerFixed in Version => RR17Q1

Notes
(0092935)
hgbot   
2016-12-22 10:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9f8d7d89ddd55585dd0f3363723d83a601c22fdc
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Dec 22 10:29:10 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9f8d7d89ddd55585dd0f3363723d83a601c22fdc [^]

Fixed issue 34720: Pay Open Tickets blocked

Now, both preAddPayment hooks have a execute a callback. This callback is
received in the definition of the AddPayment function.

All necessary callbacks have been added all modules from retail integration.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0092951)
hgbot   
2016-12-22 17:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3154d7e46c51610488917d48421730502d4100d1
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Dec 22 17:36:59 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3154d7e46c51610488917d48421730502d4100d1 [^]

Related to issue 34720: Pay Open Tickets blocked

Remove some useless comments

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---