Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034716Openbravo ERPA. Platformpublic2016-12-12 13:052016-12-16 18:39
Reporterumartirena 
Assigned Tocaristu 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034716: Window action buttons are displayed when they should not under some circumstances.
DescriptionWindow action buttons are displayed when they should not under some circumstances. The problem is that FormInitializationComponent.java action handler is not called in a certain case.
Steps To ReproduceIn Live builds login in Openbravo ERP:
 * Go to Sales Order window.
 * Remove filters.
 * Select first record in the grid.
 * See that "Close" button is displayed.
 * Click on create a new record in form view.
 * Cancel the action.
 * Select again the first record in grid view.
 * See that now "Add Payment" and "Close" buttons are displayed. "Add Payment" should not be displayed for this document.
Proposed SolutionThe problem is that after creating a new record in form view and cancelling the action the FormInitializationComponent.java action handler is not called, so session variables, auxiliary inputs, etc. are not computed again.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00166443.0MP0 closed mtaal "Edit" status disappears after undo/cancel 
related to defect 0034801 closed platform Cancel changes button in form view doesn't works properly in User window. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-12 13:05umartirenaNew Issue
2016-12-12 13:05umartirenaAssigned To => caristu
2016-12-12 13:05umartirenaModules => Core
2016-12-12 13:05umartirenaTriggers an Emergency Pack => No
2016-12-12 14:22caristuStatusnew => scheduled
2016-12-12 16:49caristuRelationship addedrelated to 0016644
2016-12-12 18:52hgbotCheckin
2016-12-12 18:52hgbotNote Added: 0092296
2016-12-12 18:52hgbotStatusscheduled => resolved
2016-12-12 18:52hgbotResolutionopen => fixed
2016-12-12 18:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8593b3e21352e7146b98f9d480284c7f25a93764 [^]
2016-12-12 18:58caristuReview Assigned To => alostale
2016-12-13 11:03alostaleNote Added: 0092305
2016-12-13 11:03alostaleStatusresolved => closed
2016-12-13 11:03alostaleFixed in Version => 3.0PR17Q1
2016-12-16 18:39hudsonbotCheckin
2016-12-16 18:39hudsonbotNote Added: 0092700
2016-12-21 15:28inigosanchezRelationship addedrelated to 0034801

Notes
(0092296)
hgbot   
2016-12-12 18:52   
Repository: erp/devel/pi
Changeset: 8593b3e21352e7146b98f9d480284c7f25a93764
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Dec 12 18:51:39 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8593b3e21352e7146b98f9d480284c7f25a93764 [^]

fixes issue 34716: sometimes action buttons are displayed when they should not

After closing a new record in form view without saving the changes (either using the cancel button of the toolbar or the close button of the form) some action buttons were being displayed when they should not. This was happening because the form was not being restored as not new after closing it without saving the changes. Back in grid view, having the isNew flag as true was avoiding the required call to the FIC in SETSESSION mode which is needed to recalculate the display logic of the buttons.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0092305)
alostale   
2016-12-13 11:03   
code reviewed and tested
(0092700)
hudsonbot   
2016-12-16 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test