Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034712Retail ModulesWeb POSpublic2016-09-09 12:542016-12-19 06:24
Reporterumartirena 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q4Fixed in VersionRR16Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034712: SER QA 1790 Wrong remaining to pay amount when paying with multicurrency
DescriptionWrong remaining to pay amount when paying with multicurrency
Steps To ReproduceIn https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1#login: [^]

 * Click on "Layaway this Receipt"
 * Add a product: "Avalanche transceiver"
 * Go to payment window
 * Pay 100 in USA Cash
 * Click on cash payment method and see that remaining to pay is 74.42€
 * Click on Layaway, it will be synchronized to the backend.
 * Retrieve the layaway
 * Go to payments window. Realize that remaining to pay is 74.43€, which is wrong.
Proposed SolutionDon't recalculate payments coming from backend.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0033939 closed jorge-garcia SER QA 1790 Wrong remaining to pay amount when paying with multicurrency 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-09 12:16OrekariaTypedefect => backport
2016-12-09 12:16OrekariaTarget Version => RR16Q4
2016-12-09 14:57hgbotCheckin
2016-12-09 14:57hgbotNote Added: 0092246
2016-12-09 14:57hgbotStatusscheduled => resolved
2016-12-09 14:57hgbotResolutionopen => fixed
2016-12-09 14:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ef307311193872c449bf72e21bd70b7329244913 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/199b31927b19b08d377cf8e8d817d87990e10130 [^]
2016-12-09 14:57hgbotCheckin
2016-12-09 14:57hgbotNote Added: 0092248
2016-12-09 14:57hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/199b31927b19b08d377cf8e8d817d87990e10130 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/3f15d8c4c8ae388d65b438e945007854fb829b4b [^]
2016-12-09 15:20hgbotCheckin
2016-12-09 15:20hgbotNote Added: 0092262
2016-12-09 15:20hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/3f15d8c4c8ae388d65b438e945007854fb829b4b [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/61ef72900beea36ddba860d12d0901f941874338 [^]
2016-12-12 12:51marvintmStatusresolved => closed
2016-12-12 12:51marvintmFixed in Version => RR16Q4
2016-12-16 08:41hgbotCheckin
2016-12-16 08:41hgbotNote Added: 0092454
2016-12-16 08:41hgbotStatusclosed => resolved
2016-12-16 08:41hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/61ef72900beea36ddba860d12d0901f941874338 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/61ef72900beea36ddba860d12d0901f941874338 [^]
2016-12-19 06:24priyamNote Added: 0092741
2016-12-19 06:24priyamStatusresolved => closed

Notes
(0092246)
hgbot   
2016-12-09 14:57   
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 199b31927b19b08d377cf8e8d817d87990e10130
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Oct 19 09:55:28 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/199b31927b19b08d377cf8e8d817d87990e10130 [^]

Fixed issue 34712, backport of issue 33939: SER QA 1790 Wrong remaining to pay amount when paying
with multicurrency

The solution is to not recalculate the value paid in other currency. For that,
it’s necessary to use the data stored in the transaction amount from the
payment.

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0092248)
hgbot   
2016-12-09 14:57   
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 3f15d8c4c8ae388d65b438e945007854fb829b4b
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Oct 21 13:45:58 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/3f15d8c4c8ae388d65b438e945007854fb829b4b [^]

Fixed issue 34712, backport of issue 33939: SER QA 1790 Wrong remaining to pay amount when paying
with multicurrency

The financial account selected to use in cancel and replace has changed. Now the
query searches for those financial account with the same currency as defined at
organization level.

The second change use the previous flow to generate the information of the
payments in case the order is a cancel and replace ticket. In the rest of the
cases, the information of the payments are read directly from the real payment
(in it’s original currency).

---
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0092262)
hgbot   
2016-12-09 15:20   
Repository: retail/backports/3.0RR16Q4/pi-mobile
Changeset: 61ef72900beea36ddba860d12d0901f941874338
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Oct 03 17:39:50 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/61ef72900beea36ddba860d12d0901f941874338 [^]

Fixed issue 34712, backport of issue 33939: SER QA 1790 Wrong remaining to pay amount when paying
with multicurrency

Added test I33939_WrongRemainingAmtWithMultiCurrency.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I33939_WrongRemainingAmtWithMultiCurrency.java
---
(0092454)
hgbot   
2016-12-16 08:41   
Repository: tools/automation/pi-mobile
Changeset: 61ef72900beea36ddba860d12d0901f941874338
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Oct 03 17:39:50 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/61ef72900beea36ddba860d12d0901f941874338 [^]

Fixed issue 34712, backport of issue 33939: SER QA 1790 Wrong remaining to pay amount when paying
with multicurrency

Added test I33939_WrongRemainingAmtWithMultiCurrency.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I33939_WrongRemainingAmtWithMultiCurrency.java
---
(0092741)
priyam   
2016-12-19 06:24   
Closing as merge of pi-mobiles Q4 tag updated the issues.