Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034682Retail ModulesStoreServerpublic2016-12-02 22:272016-12-07 11:22
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q1Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034682: Custom router: add check that custom router implements the correct name, implement default name
DescriptionIf the programmer makes a mistake in setting the incorrect name or class of a custom router then it can be difficult to detect why data is not routed to store servers.

Therefore the requirement is to add checking of the name and classname of a custom router when it is entered/updated in the custom router window.
Steps To ReproduceEnter wrong values in the custom router window, no checking is done
Proposed SolutionSee description
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-02 22:27mtaalNew Issue
2016-12-02 22:27mtaalAssigned To => mtaal
2016-12-02 22:27mtaalOBNetwork customer => No
2016-12-02 22:27mtaalTriggers an Emergency Pack => No
2016-12-02 22:37hgbotCheckin
2016-12-02 22:37hgbotNote Added: 0092057
2016-12-02 22:37hgbotStatusnew => resolved
2016-12-02 22:37hgbotResolutionopen => fixed
2016-12-02 22:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/5284cd4bc453895a07f663118030a2adc09b0982 [^]
2016-12-02 23:04mtaalReview Assigned To => AugustoMauch
2016-12-07 11:22AugustoMauchNote Added: 0092170
2016-12-07 11:22AugustoMauchStatusresolved => closed

Notes
(0092057)
hgbot   
2016-12-02 22:37   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 5284cd4bc453895a07f663118030a2adc09b0982
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Dec 02 22:37:43 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/5284cd4bc453895a07f663118030a2adc09b0982 [^]

Fixes issue 34682: Custom router: add check that custom router implements the correct name, implement default name
Implements an eventhandler to check the router record.
Repair the classname property name
Let the AbstractClientFilteredRouter implement a default getName method so that subclasses do not need to implement
it anymore

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/replication/symmetricds/extensions/AbstractClientFilteredRouter.java
A src/org/openbravo/replication/symmetricds/eventhandler/CustomRouterEventHandler.java
---
(0092170)
AugustoMauch   
2016-12-07 11:22   
Code reviewed and verified