Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034680Retail ModulesStoreServerpublic2016-12-02 17:552016-12-07 16:53
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q1Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034680: Preferences are synchronized/used to create preferences in the store, but several ui-preferences are not needed in the store
DescriptionSee the screenshot and attached csv file. What can be seen is that there are specific UI related preferences which are updated while users work in the backoffice ERP. These user level ui preferences do not need to be synchronized to the store and can be ignored.
Steps To ReproduceCreate multi-server
Work in the backoffice
See that the ad_preference table gets updated and is synchronized to the store
Proposed SolutionPrevent synchronization to the store by using a specific router which ignores preferences for specific properties.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Selection_037.png (130,707) 2016-12-02 17:55
https://issues.openbravo.com/file_download.php?file_id=10154&type=bug
png

csv preferences.csv (23,891) 2016-12-02 17:55
https://issues.openbravo.com/file_download.php?file_id=10155&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-12-02 17:55mtaalNew Issue
2016-12-02 17:55mtaalAssigned To => mtaal
2016-12-02 17:55mtaalFile Added: Selection_037.png
2016-12-02 17:55mtaalOBNetwork customer => No
2016-12-02 17:55mtaalTriggers an Emergency Pack => No
2016-12-02 17:55mtaalFile Added: preferences.csv
2016-12-02 23:01hgbotCheckin
2016-12-02 23:04hgbotNote Added: 0092058
2016-12-02 23:04hgbotStatusnew => resolved
2016-12-02 23:04hgbotResolutionopen => fixed
2016-12-02 23:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/b629c7c9ce7bdc2a5e3c0171fa36b18681751766 [^]
2016-12-02 23:15mtaalReview Assigned To => AugustoMauch
2016-12-07 16:52hgbotCheckin
2016-12-07 16:52hgbotNote Added: 0092198
2016-12-07 16:53AugustoMauchNote Added: 0092199
2016-12-07 16:53AugustoMauchStatusresolved => closed

Notes
(0092058)
hgbot   
2016-12-02 23:01   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: b629c7c9ce7bdc2a5e3c0171fa36b18681751766
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Dec 02 23:01:37 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/b629c7c9ce7bdc2a5e3c0171fa36b18681751766 [^]

Fixes issue 34680: Preferences are synchronized/used to create preferences in the store, but several ui-preferences are not needed in the store
Implement preference router which prevents specific preferences to be routed. Use it for the synchronization of preferences.

---
M src-db/database/sourcedata/STRSYNC_CUSTOM_ROUTER.xml
M src-db/database/sourcedata/STRSYNC_SYNCHRONIZEDTABLE.xml
A src/org/openbravo/retail/storeserver/synchronization/router/PreferenceRouter.java
---
(0092198)
hgbot   
2016-12-07 16:52   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: d97682c640f915e7e90d31e0460992130df6b3f1
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Dec 07 16:52:05 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/d97682c640f915e7e90d31e0460992130df6b3f1 [^]

Related with issue 34680: Make explicit clause applies if property is defined

Adds a clause to check if the property local variableis not blank before checking if it is contained in a list. The previous solution was working even if the property was null, but it seemed to dependant from how the contains method handles null values.

---
M src/org/openbravo/retail/storeserver/synchronization/router/PreferenceRouter.java
---
(0092199)
AugustoMauch   
2016-12-07 16:53   
Code reviewed and verified in [1]@d97682c640f9

[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/ [^]