Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034674Retail ModulesDiscounts by Totalpublic2016-12-02 09:452017-01-25 15:33
Reporterguillermogil 
Assigned Toguillermogil 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034674: Implement Manual discounts by Total
DescriptionImplement Manual discounts by Total
A new discount type needs to be created in order to have the possibility to add in a manual way, from discounts window, a total discount.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037114 closed jorge-garcia By total discounts should ignore discount priority and be calculated at the end 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-02 09:45guillermogilNew Issue
2016-12-02 09:45guillermogilAssigned To => guillermogil
2016-12-02 09:45guillermogilTriggers an Emergency Pack => No
2017-01-12 12:33hgbotCheckin
2017-01-12 12:33hgbotNote Added: 0093384
2017-01-12 12:33hgbotCheckin
2017-01-12 12:33hgbotNote Added: 0093385
2017-01-12 12:35hgbotCheckin
2017-01-12 12:35hgbotNote Added: 0093386
2017-01-12 12:35hgbotStatusnew => resolved
2017-01-12 12:35hgbotResolutionopen => fixed
2017-01-12 12:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/c742ec5341ff91f4ebdfedf29ac6b08021640ac2 [^]
2017-01-12 13:14guillermogilReview Assigned To => marvintm
2017-01-16 09:59marvintmNote Added: 0093571
2017-01-16 11:03marvintmStatusresolved => closed
2017-01-16 11:03marvintmFixed in Version => RR17Q2
2017-01-25 15:32hgbotCheckin
2017-01-25 15:32hgbotNote Added: 0093820
2017-01-25 15:33hgbotCheckin
2017-01-25 15:33hgbotNote Added: 0093821
2017-10-19 12:38jorge-garciaRelationship addedrelated to 0037114

Notes
(0093384)
hgbot   
2017-01-12 12:33   
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal
Changeset: 28609db06102fa49df85f7f72ee13de3e2ef87b1
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Thu Jan 12 12:30:12 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/28609db06102fa49df85f7f72ee13de3e2ef87b1 [^]

Related to issue 34674: Implement Manual discounts by Total

Applied logic based on the new API

---
M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js
---
(0093385)
hgbot   
2017-01-12 12:33   
Repository: erp/pmods/org.openbravo.retail.discounts.discountmatrixmanagement
Changeset: 31ed3312a6cad5414c6d0896a8cc02c52855024b
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Thu Jan 12 12:27:36 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.discountmatrixmanagement/rev/31ed3312a6cad5414c6d0896a8cc02c52855024b [^]

Related to issue 34674: Implement Manual discounts by Total

Taking into account manual discounts by total

---
M web/org.openbravo.retail.discounts.discountmatrixmanagement/js/hookRoleDiscounts.js
---
(0093386)
hgbot   
2017-01-12 12:35   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: c742ec5341ff91f4ebdfedf29ac6b08021640ac2
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Thu Jan 12 12:26:30 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/c742ec5341ff91f4ebdfedf29ac6b08021640ac2 [^]

Fixed issue 34674: Implement Manual discounts by Total

Applied code review
Modified core in order to avoid wrappers

---
M src/org/openbravo/retail/discounts/bytotal/DiscTComponentProvider.java
M web/org.openbravo.retail.discounts.bytotal/js/preApplyDiscountsHook.js
M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js
M web/org.openbravo.retail.discounts.bytotal/js/promotionManualByTotal.js
M web/org.openbravo.retail.discounts.bytotal/js/ticketdiscountExtension.js
R web/org.openbravo.retail.discounts.bytotal/js/discountListLineRender.js
R web/org.openbravo.retail.discounts.bytotal/js/editLineExtension.js
R web/org.openbravo.retail.discounts.bytotal/js/promotionIncludeManualDisc.js
---
(0093571)
marvintm   
2017-01-16 09:59   
This change was also done in mobile.core:

https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1ef1860a9526 [^]

And these were done in posterminal:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3bdeb7d34718 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/64f2591b949e [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac0539441209 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a8757ecd024d [^]
(0093820)
hgbot   
2017-01-25 15:32   
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal
Changeset: 2bc5377a3d7a3c6c86fed7a837f003d7b6020055
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Jan 25 15:32:16 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/2bc5377a3d7a3c6c86fed7a837f003d7b6020055 [^]

Related to issue 34674: Implement Manual discounts by Total

Best deal case should avoid to do anything with manual discounts by total

---
M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js
---
(0093821)
hgbot   
2017-01-25 15:33   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 19bfbc6b9e14ea06679c00a29e9465da7f2f533a
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Jan 25 15:32:50 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/19bfbc6b9e14ea06679c00a29e9465da7f2f533a [^]

Related to issue 34674: Implement Manual discounts by Total

Avoid to stop the execution of manual discounts by total

---
M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js
---