Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034665Retail ModulesWeb POSpublic2016-12-01 12:012016-12-07 17:36
Reporteregoitz 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034665: The terminal should be locked until the full/incremental refresh finish
DescriptionRight now after click on f5 you can start using the application before the incremental refresh finishes.
That means that you can work having missing elements. for example discounts
Steps To Reproduce-Create a discount on the backend applicable to the product A
-click f5 on the terminal
-Add the product to a ticket before the incremental refresh finishes.
*the discount is not applied.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034735 closed jorge-garcia incremental refresh is stopped if one masterdata query is very slow 
related to defect 0034084 new Retail Pending test to be developed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-01 12:01egoitzNew Issue
2016-12-01 12:01egoitzAssigned To => Retail
2016-12-01 12:01egoitzResolution time => 1481497200
2016-12-01 12:01egoitzTriggers an Emergency Pack => No
2016-12-05 14:08egoitzNote Added: 0092091
2016-12-06 09:24marvintmStatusnew => scheduled
2016-12-06 09:24marvintmAssigned ToRetail => marvintm
2016-12-06 21:22hgbotCheckin
2016-12-06 21:22hgbotNote Added: 0092153
2016-12-06 21:22hgbotStatusscheduled => resolved
2016-12-06 21:22hgbotResolutionopen => fixed
2016-12-06 21:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9d8030870f6cd8d86820a2004b49d2333bd190ea [^]
2016-12-06 21:22hgbotCheckin
2016-12-06 21:22hgbotNote Added: 0092154
2016-12-06 21:22hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9d8030870f6cd8d86820a2004b49d2333bd190ea [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4b9f3131a589e2a296ad03b5971506dbc2d8def6 [^]
2016-12-07 17:36guilleaerReview Assigned To => guilleaer
2016-12-07 17:36guilleaerStatusresolved => closed
2016-12-07 17:36guilleaerFixed in Version => RR17Q1
2016-12-14 17:45malsasuaRelationship addedrelated to 0034735
2016-12-22 10:55marvintmRelationship addedrelated to 0034084

Notes
(0092091)
egoitz   
2016-12-05 14:08   
If the incremental refresh does not finish, you should be able to continue working.

The incremental could not finish because locks/problems on the database.
(0092153)
hgbot   
2016-12-06 21:22   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9d8030870f6cd8d86820a2004b49d2333bd190ea
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Dec 06 19:35:57 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9d8030870f6cd8d86820a2004b49d2333bd190ea [^]

Fixed issue 34665. Incremental masterdata refresh will no longer be triggered without giving feedback to the user first.
From now on, whenever it's time to launch incremental refresh, an alert will be shown. The process will be automatically started without any user action, unless the user cancels it (he has 3 seconds to cancel it). Once it is launched, it cannot be canceled, and the user needs to wait for it to finish before work can continue, to prevent problems of data inconsistency.

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0092154)
hgbot   
2016-12-06 21:22   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4b9f3131a589e2a296ad03b5971506dbc2d8def6
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Dec 06 19:30:33 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4b9f3131a589e2a296ad03b5971506dbc2d8def6 [^]

Fixed issue 34665. Now incremental refresh will happen before navigation to main window occurs.
Additionally, a trigger is now launched when incremental loading has finished. This allows applications to react to this.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---