Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034651Openbravo ERPZ. Otherspublic2016-11-28 17:462016-12-16 18:39
Reportermaite 
Assigned Tocollazoandy4 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket44468
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034651: Inconsistent payment created (without lines) due to "payment currency should map business partner currency" error
DescriptionError "For credit generation and/or credit consumption payment currency should map business partner currency" can be found in openbravo.log although no error is raised in UI and
- payment without lines
- related transaction
- related reconciliation
are created
Steps To Reproduce1. Register Purchase Invoice for "Bebidas Alegres", add any line and process
2. Navigate to Business Partner window and run "Set new currency" process. Set MXN amount, check "set amount" option and set any amount
3. Access "Cuenta de Banco" financial account and create new Bank Statement and Bank Statement Line setting Amount OUT > invoice's grand total amount. Process Bank Statement
4. Run "Match Statement" process and select CANCEL option.
5. Run "Add new transaction" (pressing + button) process from previous line and run "Add payment" process in payment selector (pressing + button)
6. Set "Bebidas alegres" in "To be paid to" field and only select previous invoice. Realize that "Overpayment action" is set to "Leave the credit to be used later" and press Done. Press Done again and OK to finish process
7. Realize that transaction document has been created in financial account. Navigate to Payment document and realize that it is in non consistent status as appears as "Payment Cleared" but it has no line
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-28 17:46maiteNew Issue
2016-11-28 17:46maiteAssigned To => Triage Finance
2016-11-28 17:46maiteOBNetwork customer => Yes
2016-11-28 17:46maiteModules => Advanced Payables and Receivables Mngmt
2016-11-28 17:46maiteSupport ticket => 44468
2016-11-28 17:46maiteResolution time => 1482102000
2016-11-28 17:46maiteTriggers an Emergency Pack => No
2016-11-28 17:46maiteIssue Monitored: networkb
2016-11-30 09:50aferrazAssigned ToTriage Finance => collazoandy4
2016-12-06 17:38collazoandy4Statusnew => scheduled
2016-12-06 21:06collazoandy4Note Added: 0092152
2016-12-13 16:28aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13987#r13987
2016-12-15 18:15hgbotCheckin
2016-12-15 18:15hgbotNote Added: 0092422
2016-12-15 18:15hgbotStatusscheduled => resolved
2016-12-15 18:15hgbotResolutionopen => fixed
2016-12-15 18:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/70909b3c068fbcc897465716eaab4673733c6e98 [^]
2016-12-15 18:16aferrazReview Assigned To => aferraz
2016-12-15 18:16aferrazNote Added: 0092423
2016-12-15 18:16aferrazStatusresolved => closed
2016-12-15 18:16aferrazFixed in Version => 3.0PR17Q1
2016-12-16 18:39hudsonbotCheckin
2016-12-16 18:39hudsonbotNote Added: 0092723

Notes
(0092152)
collazoandy4   
2016-12-06 21:06   
Test Plan
 Create a Purchase Invoice for "Bebidas Alegres", add any line and process
 Go to Business Partner window select "Bebidas Alegres" and run "Set new currency" process.
 Set MXN check "set amount" option and set any amount
 Go to Financial Account select "Cuenta de banco"
 Go to Imported Bank Statement tab and create a new line
 Go to Bank Statement Lines and create a new line with Amount out equal to the invoice grand total amount. Clic on Process button.
 Clic on "Match Statement" button and select CANCEL option from the dialog
 On Match column clic on Add new payment (plus button)
 Clic on Add payment (plus button)
 On the dialog open set "Bebidas alegres" in "To be paid to" field
 Set Invoices in Transaction type field and select a previous created invoice
 Clic on Done button
(0092422)
hgbot   
2016-12-15 18:15   
Repository: erp/devel/pi
Changeset: 70909b3c068fbcc897465716eaab4673733c6e98
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Dec 14 13:12:34 2016 -0800
URL: http://code.openbravo.com/erp/devel/pi/rev/70909b3c068fbcc897465716eaab4673733c6e98 [^]

Fixes issue 34651: An inconsistent payment without lines created

When a payment was created with a currency with not conversion rate again to a
business partner currency an inconsistent payment without lines was created. In
the validation process a now it's verify a valid conversion rate between the
payment currency and business partner currency.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentOnProcessActionHandler.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0092423)
aferraz   
2016-12-15 18:16   
Code review + Testing OK
(0092723)
hudsonbot   
2016-12-16 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test